EVP_{Digest,Encrypt}Init.3: remove duplicate word

Hi there I guess this should only be one one. Best, Martin Index: man/EVP_DigestInit.3 === RCS file: /cvs/src/lib/libcrypto/man/EVP_DigestInit.3,v retrieving revision 1.19 diff -u -p -r1.19 EVP_DigestInit.3 --- man/EVP_DigestInit.3

vacation.1: correct .forward file example

Hi I think the backslash at the beginning of the line is an error. Best, Martin Index: vacation.1 === RCS file: /home/reposync/cvs//src/usr.bin/vacation/vacation.1,v retrieving revision 1.23 diff -u -p -r1.23 vacation.1 --- vacatio

makemap(8): Parse aliases similar to expand_line

Hi While browsing the smtpd(8) source I discovered that makemap(8) uses strsep(3) to split the alias lines at commas. This is different from other code which uses expand_line (which uses expand_line_split). This leads to contrived alias lines such as martin: "/usr/local/bin/weird_mda abc,def

smptd(8) expand.c: Remove unnecessary assignment

Hi esc is always zero at that point, so no need to store zero in it. Diff with extra context. Best, Martin --- a/usr.sbin/smtpd/expand.c +++ b/usr.sbin/smtpd/expand.c @@ -198,37 +198,36 @@ expand_line_split(char **line, char **ret) i = 0; for (s = *line; (*s) && (i < sizeof(buf

libcrypto bio_cb.c: fix mangled debug output

Hi This fixes mangled output from the openssl(1) -debug option: Before: $ openssl aes-256-cbc -out test -debug BIO[0x9102a7e5ctrl(106) - FILE pointer BIO[0x9102a7e5ctrl return 1 BIO[0x9102a801ctrl(108) - FILE pointer BIO[0x9102a801ctrl return 1 ... After: $ openssl aes-256-cbc -out test -debug B

ypconnect(2): mention correct return value

Hi While looking at the recent YP changes I noticed that the RETURN VALUES section of the man page is incorrect. Here is an update (I just copied the text from socket(2) and adjusted the function name). Best, Martin Index: ypconnect.2 ===

pf.conf(5): document new anchors limit

Hi This is a diff to document the new anchors limit in pf.conf(5). I inserted it as second-to-last item, as the following paragraph talks about NMBCLUSTERS. While here: Is the double entry for table-entries intentional? Best, Martin Index: pf.conf.5 ===

[patch] ERR_print_errors.3

Hi there Unless I miss something ERR_print_errors_cb returns no value as well. Best, Martin Index: ERR_print_errors.3 === RCS file: /cvs/src/lib/libcrypto/man/ERR_print_errors.3,v retrieving revision 1.7 diff -u -p -r1.7 ERR_print_

[patch] Remove "do not return a value" from libcrypto/libssl manpages

Hi there! I found some more. Best, Martin Index: libcrypto/man/RC4.3 === RCS file: /cvs/src/lib/libcrypto/man/RC4.3,v retrieving revision 1.7 diff -u -p -r1.7 RC4.3 --- libcrypto/man/RC4.3 6 Jun 2019 01:06:59 - 1.7 +++ li

Re: [patch] mandoc: Remove argument names from function prototypes

Hi Ingo On Fri, Apr 03, 2020 at 01:55:56PM +0200, Ingo Schwarze wrote: > Hi Martin, > > Martin Vahlensieck wrote on Thu, Apr 02, 2020 at 10:57:04AM +0200: > > > I think these are superfluous. > > Correct, and it is irritating to have a general style of not using > a

[patch]: Change kern_unveil to [] array derefs

Hi! This makes these array derefs consistent with the others in the file. Also I believe this is the preferred way to do this. Best, Martin Index: kern_unveil.c === RCS file: /cvs/src/sys/kern/kern_unveil.c,v retrieving revision 1.

[patch] Remove old sshd_config(5) keyword from authpf(8) manual

Hi! >From my research in the cvs history of sshd_config.5 the `Protocol' keyword was removed in 2016, so remove it here as well. Best, Martin Index: authpf.8 === RCS file: /cvs/src/usr.sbin/authpf/authpf.8,v retrieving revision 1.5

[patch] ps.c mark usage() as __dead

Hi I'm not sure this is worth a diff, but here it is anyway. Best, Martin Index: ps.c === RCS file: /cvs/src/bin/ps/ps.c,v retrieving revision 1.76 diff -u -p -r1.76 ps.c --- ps.c16 Dec 2019 19:21:16 - 1.76 +++ ps.

[patch] Check for -1 explicitly in getpeereid.c

Hi there >From the getsockopt(2) manual page says getsockopt(2) returns -1 on error and 0 on success. Also getpeereid(3) only lists those 2 values. This diff makes the return value check in getpeereid explicit. I guess this is how it is done elsewhere in the tree (there is a commit turning a bunch

Re: [patch] Check for -1 explicitly in getpeereid.c

On Sun, Apr 26, 2020 at 03:30:51PM -0600, Theo de Raadt wrote: > Patrick Wildt wrote: > > > I don't know userland very well, so I have a question. In the middle of > > 2019 there have been plenty of changes in regards to changing checks of > > syscalls from < 0 to a more strict == -1, like this

{plus,}67.html: fix link crontab(5)

Hey there! Otherwise it's going to crontab(1). Best, Martin Index: 67.html === RCS file: /cvs/www/67.html,v retrieving revision 1.77 diff -u -p -r1.77 67.html --- 67.html 19 May 2020 18:21:41 - 1.77 +++ 67.html 20

[PATCH] from.c: stricter pledge(2)

Hey! This pledge was added with the use of unveil(2), but doesn't require the getpw promise anymore (it is only needed in mail_spool to get the username). This patch makes it stricter. Best, Martin Index: from.c === RCS file: /cvs

[PATCH]: sysupgrade(8) don't create /home/_sysupgrade/keep

Hi In the last revision install.sub stopped using /home/_sysupgrade/keep, so unless I miss something this line can be removed. Best, Martin Index: sysupgrade.sh === RCS file: /cvs/src/usr.sbin/sysupgrade/sysupgrade.sh,v retrieving

vmd: Fix grammar for random lladdr

Hi The grammar for lladdr of interfaces is according to the manpage: [locked] lladdr [etheraddr] This implies that `locked lladdr' is OK but looking at parse.y this does not seem to be the case. Making it optional would lead to a `lladdr' all by itself being valid, which I find weird. So I c

Re: vmd: Fix grammar for random lladdr

Ping. On Sat, May 22, 2021 at 09:58:46AM +0200, Martin Vahlensieck wrote: > Hi > > The grammar for lladdr of interfaces is according to the manpage: > > [locked] lladdr [etheraddr] > > This implies that `locked lladdr' is OK but looking at parse.y this > does not

Re: vmd: Fix grammar for random lladdr

Hi Dave On Tue, Jun 01, 2021 at 08:23:45PM -0400, Dave Voutila wrote: > > Martin Vahlensieck writes: > > > Hi > > > > The grammar for lladdr of interfaces is according to the manpage: > > > > [locked] lladdr [etheraddr] > > > > This implie

Mark ICMP code optional in pf.conf.5

Hi The code part for icmp{,6}-type is optional. Below is a diff marking it as such. Should the text be changed as well? Or am I missing a reason why it is not marked optional? Best, Martin Index: pf.conf.5 === RCS file: /cvs/src

ssh match.c: Remove always true condition

Hi After the last commit where consecutive `*' are folded, *pattern is never '*' here. Best, Martin Index: match.c === RCS file: /cvs/src/usr.bin/ssh/match.c,v retrieving revision 1.43 diff -u -p -r1.43 match.c --- match.c 3 No

Re: ssh match.c: Remove always true condition

Ping, diff reattached with extra context for easier review. On Wed, Jul 21, 2021 at 12:10:31PM +0200, Martin Vahlensieck wrote: > Hi > > After the last commit where consecutive `*' are folded, *pattern is > never '*' here. > > Best

Re: ssh match.c: Remove always true condition

Ping. On Tue, Aug 10, 2021 at 04:33:52PM +0200, Martin Vahlensieck wrote: > Ping, diff reattached with extra context for easier review. > > On Wed, Jul 21, 2021 at 12:10:31PM +0200, Martin Vahlensieck wrote: > > Hi > > > > After the last commit where consecutive

swapctl(8): Sync synopsis with usage

Hi swapctl defaults to -l since 2007. This syncs the manpage synopsis with the swapctl usage text. Best, Martin diff --git a/sbin/swapctl/swapctl.8 b/sbin/swapctl/swapctl.8 index 10a76bd6c01..d447f8fee8d 100644 --- a/sbin/swapctl/swapctl.8 +++ b/sbin/swapctl/swapctl.8 @@ -49,7 +49,7 @@ .Fl d

hkdf.c: Remove unecessary include

Hi Looks like hkdf.c does not need assert.h so remove it. Best, Martin Index: hkdf/hkdf.c === RCS file: /cvs/src/lib/libcrypto/hkdf/hkdf.c,v retrieving revision 1.4 diff -u -p -r1.4 hkdf.c --- hkdf/hkdf.c 21 Nov 2019 20:02:20 -

quotaon(8): small improvements

Hi Here are some small changes to quotaon(8). If you want I can split them up, but since they are small I am sending one diff. Here is a list of changes roughly in the order they appear in the diff: - Constify some function arguments - Use __progname instead of separate whoami variable + sma

Re: quotaon(8): small improvements

Friendly ping On Fri, Oct 29, 2021 at 10:06:44AM +0200, Martin Vahlensieck wrote: > Hi > > Here are some small changes to quotaon(8). If you want I can split > them up, but since they are small I am sending one diff. Here is > a list of changes roughly in the order they app

[PATCH] Fix link in Porting Guide

Hi This refers to the libc function. Best, Martin P.S.: I noticed that e.g. sysmerge(8) is mentioned like this but not a link. Is this intentional? Index: faq/ports/guide.html === RCS file: /cvs/www/faq/ports/guide.html,v retrievi

dhcpd: Remove prototypes without implementation

Hi pretty_print_option: Removed in options.c in revision 1.4 parse_timestamp: Removed in confpars.c in revision 1.13 tree_host_lookup: Removed in tree.c in revision 1.11 enter_dns_host: Removed in tree.c in revision 1.11 getLong: Removed in convert.c in revision 1.4 getShort: Removes in convert.c

base64.c: Remove trailing whitespace

Hi Remove trailing whitespace. Best, Martin Index: base64.c === RCS file: /cvs/src/lib/libc/net/base64.c,v retrieving revision 1.8 diff -u -p -r1.8 base64.c --- base64.c16 Jan 2015 16:48:51 - 1.8 +++ base64.c7 Nov

dhcpd: Put return type on its own line

Hi Put the return type on its own line. Found while checking dhcpd.h. Best, Martin Index: memory.c === RCS file: /cvs/src/usr.sbin/dhcpd/memory.c,v retrieving revision 1.29 diff -u -p -r1.29 memory.c --- memory.c6 Apr 2020 17:0

unbound.conf.5.in: remove reference to default pidfile

Hi Unbound on OpenBSD does not have a pidfile, so remove the reference in the manual. As the variable is empty, it also incorrectly formats the description as italic. Best, Martin Index: unbound.conf.5.in === RCS file: /cvs/src/usr

tcpdump: use unsigned char in isprint

Hi I think this is the way it was meant. Best, Martin Index: util.c === RCS file: /cvs/src/usr.sbin/tcpdump/util.c,v retrieving revision 1.30 diff -u -p -r1.30 util.c --- util.c 24 Jan 2020 22:46:37 - 1.30 +++ util.c

tcpdump: Don't link to libl and remove reference to yydebug

Hi This is unused. It has been in there since the import from NetBSD. Their logs show that tcpgram.y and tcplex.l have been removed in 1995. I am not sure what the policy is for the getopt(3) call: Should Y be removed in the optstring as well (not done in this diff)? Best, Martin Index: Makefi

Re: tcpdump: Don't link to libl and remove reference to yydebug

On Thu, Dec 03, 2020 at 10:56:17PM +0300, Vitaliy Makkoveev wrote: > > On 3 Dec 2020, at 13:20, Martin Vahlensieck > > wrote: > > > > Hi > > Hi. > Hi > > > > This is unused. It has been in there since the import from NetBSD. > > Their logs

yacc(1): skeleton.c: remove outdated comment

Hi yysccsid was removed in 1.30 back in 2009. Best, Martin Index: skeleton.c === RCS file: /cvs/src/usr.bin/yacc/skeleton.c,v retrieving revision 1.40 diff -u -p -r1.40 skeleton.c --- skeleton.c 3 Feb 2021 01:10:10 - 1.4

ssh(1): monitor.c: save a xstrdup

Hi Tiny diff to save an allocation. Best, Martin Index: monitor.c === RCS file: /cvs/src/usr.bin/ssh/monitor.c,v retrieving revision 1.231 diff -u -p -r1.231 monitor.c --- monitor.c 28 Jan 2022 06:18:42 - 1.231 +++ monit

Re: yacc(1): skeleton.c: remove outdated comment

ping, diff reattached On Thu, Feb 10, 2022 at 04:29:53PM +0100, Martin Vahlensieck wrote: > Hi > > yysccsid was removed in 1.30 back in 2009. > > Best, > > Martin > > Index: skeleton.c > === >

rpki-client: fix wrong conditional

Hi This pulls up and adjusts the check if i exceeds the bounds of pfds. Before it was technically wrong, as i > NPFDS means that the last write (i == NPFDS) was already out of bounds. Best, Martin Index: http.c === RCS file: /cvs/

Re: rpki-client: fix wrong conditional

gt; On Thu, Mar 10, 2022 at 05:33:28PM +0100, Martin Vahlensieck wrote: > > > > > Hi > > > > > > > > > > This pulls up and adjusts the check if i exceeds the bounds of pfds. > > > > > Before it was technically wrong, as i > NPFDS means

two small typos

Index: if_wg.c === RCS file: /home/reposync/cvs/src/sys/net/if_wg.c,v retrieving revision 1.22 diff -u -p -r1.22 if_wg.c --- if_wg.c 22 Feb 2022 01:15:02 - 1.22 +++ if_wg.c 15 Mar 2022 21:10:37 - @@ -2023,7 +2023,7

wg: remove argument names from prototypes

None of the other prototypes have argument names. Index: if_wg.c === RCS file: /home/reposync/cvs/src/sys/net/if_wg.c,v retrieving revision 1.22 diff -u -p -r1.22 if_wg.c --- if_wg.c 22 Feb 2022 01:15:02 - 1.22 +++ if_wg.

rpki-client(8): properly zero terminate pretty printed key

Hi It seems the pretty printed key is zero terminated only if the size of hex stays the same or increases between calls. This diff fixes it, so it is always properly terminated. While here, also drop *hex != '\0' from the if inside the loop, as it is checked directly above in the loop condition

sshd_config(5): Use correct path for system-wide known_hosts

Hi The path to the system-wide known_hosts file is /etc/ssh/ssh_known_hosts and not /etc/ssh/known_hosts. See auth2-hostbased.c line 221-223. Best, Martin Index: sshd_config.5 === RCS file: /cvs/src/usr.bin/ssh/sshd_config.5,v ret

readconf.c: Avoid a xstrdup

Hi There is no need to duplicate options->send_env[i] only free it in all cases. Just use options->send_env[i] directly. Best, Martin Index: readconf.c === RCS file: /cvs/src/usr.bin/ssh/readconf.c,v retrieving revision 1.366 diff

ssh-xmss.c: Add missing includes

Hi malloc(3) and friends require stdlib.h, SIZE_MAX requires stdint.h. Best, Martin Index: ssh-xmss.c === RCS file: /cvs/src/usr.bin/ssh/ssh-xmss.c,v retrieving revision 1.4 diff -u -p -r1.4 ssh-xmss.c --- ssh-xmss.c 19 Oct 2020 2

xmss_hash.c: remove superfluous includes

Hi Neither openssl/evp.h nor openssl/hmac.h are required. Best, Martin Index: xmss_hash.c === RCS file: /cvs/src/usr.bin/ssh/xmss_hash.c,v retrieving revision 1.2 diff -u -p -r1.2 xmss_hash.c --- xmss_hash.c 26 Feb 2018 03:56:44 -0

ssh: channels.c: Fix comment and add a const

Hi channel_new no longer frees remote_name. So update the comment accordingly. As remote_name is not modified, it can be const as well. Best, Martin Index: channels.c === RCS file: /home/reposync/cvs/src/usr.bin/ssh/channels.c,v

ssh: mux.c: mark argument as const

Index: mux.c === RCS file: /home/reposync/cvs/src/usr.bin/ssh/mux.c,v retrieving revision 1.92 diff -u -p -r1.92 mux.c --- mux.c 11 Jan 2022 01:26:47 - 1.92 +++ mux.c 13 Jan 2022 16:27:14 - @@ -227,7 +227,7 @@

ssh: sshkey.c: reduce code duplication

Hi I noticed that sshkey_unshield_private contains a exact duplicate of the code in private2_check_padding. So by pulling private2_check_padding up, the code can be reused. Or is there a reason for this split? Best, Martin P.S.: This diff also removes two trailing spaces while here. Index: s

ssh-add(1): fix NULL in fprintf

Hi When removing an identity from the agent using the private key file, ssh-add first tries to find the public key file. If that fails, it loads the public key from the private key file, but no comment is loaded. This means comment is NULL when it is used inside delete_one to print `Identity rem

Re: ssh-add(1): fix NULL in fprintf

On Mon, May 09, 2022 at 10:42:29AM -0600, Theo de Raadt wrote: > Martin Vahlensieck wrote: > > > if (!qflag) { > > - fprintf(stderr, "Identity removed: %s %s (%s)\n", path, > > - sshkey_type(key), comment); > > + fpri

apply(1): constify two arguments

Index: apply.c === RCS file: /cvs/src/usr.bin/apply/apply.c,v retrieving revision 1.29 diff -u -p -r1.29 apply.c --- apply.c 1 Apr 2018 17:45:05 - 1.29 +++ apply.c 12 May 2022 21:14:04 - @@ -54,7 +54,7 @@ char *s

libcrypto/err_prn.c: skip BIO*

Hi As far as I can tell, this ends up calling vprintf eventually, so skip the steps inbetween. Best, Martin Index: err_prn.c === RCS file: /home/reposync/cvs/src/lib/libcrypto/err/err_prn.c,v retrieving revision 1.19 diff -u -p -r1

Re: ssh-add(1): fix NULL in fprintf

Hi What's the status on this? Anthing required from my side? I have reattached the patch (with the changes Theo suggested). Best, Martin On Mon, May 09, 2022 at 08:39:38PM +0200, Martin Vahlensieck wrote: > On Mon, May 09, 2022 at 10:42:29AM -0600, Theo de Raadt wrote: > > Mart

Re: ssh-add(1): fix NULL in fprintf

ping, diff attached On Mon, May 16, 2022 at 09:21:42PM +0200, Martin Vahlensieck wrote: > Hi > > What's the status on this? Anthing required from my side? I have > reattached the patch (with the changes Theo suggested). > > Best, > > Martin > > On Mo

www: Move horizontal rule and update year

Hi Going back a few versions, it seems this hr was used to separate the past from the future. So put it back in the right place. While here also correct the year for future events, or should that be replaced by "None currently scheduled"? Best, Martin diff --git a/events.html b/events.html in