[diff] www/innovations.html: fix link

2018-07-22 Thread Clemens Goessnitzer
fix link to man.cgi(8) in www/innovations.html, diff attached Index: innovations.html === RCS file: /cvs/www/innovations.html,v retrieving revision 1.66 diff -u -p -r1.66 innovations.html --- innovations.html10 Jul 2018 17:47:28 -

[diff] usr.bin/ssh/session.c: indentation

2018-07-25 Thread Clemens Goessnitzer
small indentation fix, no functional change Index: session.c === RCS file: /cvs/src/usr.bin/ssh/session.c,v retrieving revision 1.304 diff -u -p -r1.304 session.c --- session.c 11 Jul 2018 18:53:29 - 1.304 +++ session.c 25 Jul 201

[patch] rebound: add NULL pointer checks

2018-09-07 Thread Clemens Goessnitzer
This patch adds 2 missing NULL pointer checks to rebound.c after malloc(). Clemens Index: rebound.c === RCS file: /cvs/src/usr.sbin/rebound/rebound.c,v retrieving revision 1.98 diff -u -p -r1.98 rebound.c --- rebound.c 1 May 2018 1

Re: [patch] rebound: add NULL pointer checks

2018-09-07 Thread Clemens Goessnitzer
On 07/09/18 21:15, Clemens Goessnitzer wrote: This patch adds 2 missing NULL pointer checks to rebound.c after malloc(). Clemens Updated patch to also check the return of calloc() Clemens Index: rebound.c === RCS file: /cvs

Re: [patch] rebound: add NULL pointer checks

2018-09-08 Thread Clemens Goessnitzer
On 08/09/18 11:40, Theo Buehler wrote: On Sat, Sep 08, 2018 at 11:07:30AM +0200, Anton Lindqvist wrote: On Fri, Sep 07, 2018 at 09:22:33PM +0200, Theo Buehler wrote: On Fri, Sep 07, 2018 at 09:15:30PM +0200, Clemens Goessnitzer wrote: This patch adds 2 missing NULL pointer checks to

usr.bin/bgplg: remove ping6 leftovers

2018-09-14 Thread Clemens Goessnitzer
In usr.bin/bgplg, ping6/Makefile is left-over from ping(6) unification. However, there is no ping6 folder anymore: $ cd /usr/src/usr.bin/bgplg/ping6/ && make *** Parse error in /usr/src/usr.bin/bgplg/ping6: Could not find /usr/src/usr.bin/bgplg/ping6/../../../sbin/ping6/Makefile (Makefile:9)

simplify dev_mkdb

2018-09-19 Thread Clemens Goessnitzer
simplify dev_mkdb: -) no need for getopt() since there are no possible options, just check if argc < 1 -) usage() only used once: move it to the single point of failure for user input -) bzero => memset, bcopy => memcpy -) no brackets for return

Re: simplify dev_mkdb

2018-09-20 Thread Clemens Goessnitzer
On Wed, Sep 19, 2018 at 12:46:37PM -0600, Theo de Raadt wrote: > Not sure it matters, but I should point out a difference. > > Your diff makes > > dev_mkdb -- > > illegal. > > In a POSIX world, many programs have to use getopt. Not sure if this is one. True, I did not consider that, sorr

[patch]: www/errata66.html: remove self reference

2019-10-27 Thread Clemens Goessnitzer
Index: errata66.html === RCS file: /cvs/www/errata66.html,v retrieving revision 1.2 diff -u -p -u -r1.2 errata66.html --- errata66.html 27 Oct 2019 20:01:00 - 1.2 +++ errata66.html 27 Oct 2019 22:07:59 - @@ -67

[patch] httpd: remove unnecessary NULL check

2019-11-03 Thread Clemens Goessnitzer
Is this NULL check needed? clt_pass is checked for being NULL and dereferenced four lines above: if ((clt_pass = strchr(decoded, ':')) == NULL) goto done; clt_user = decoded; *clt_pass++ = '\0'; if ((clt->clt_remote_user = strdup(clt_user)) == NULL)

small typo in www/faq/ports/guide.html

2015-07-29 Thread Clemens Goessnitzer
Hello @tech, I attached a patch to correct a small typo in www/faq/ports/guide.html. It is my very first patch, so please forgive any mistakes I made. Best regards, Clemens Index: guide.html === RCS file: /cvs/www/faq/ports/guide

wrong device name in axen(4)

2015-08-04 Thread Clemens Goessnitzer
Hello tech@, I think you spelled one device name wrong. Attached is a patch to correct this. Best regards, Clemens Index: share/man/man4/axen.4 === RCS file: /cvs/src/share/man/man4/axen.4,v retrieving revision 1.6 diff -u -p -u