Missing check in ftp(1)

2009-12-28 Thread Alexander Schrijver
If the directory entry isn't complete line can be NULL. I ran into it using 'mget -r .' on this FTP server: ftp://ftp.cs.cmu.edu Index: list.c === RCS file: /home/cvsync/src/usr.bin/ftp/list.c,v retrieving revision 1.3 diff -u -r1.3

Re: Missing check in ftp(1)

2010-06-26 Thread Alexander Schrijver
+ if (line == NULL); + break; while (**line == ' ' || **line == '\t') (*line)++; break; On Tue, Dec 29, 2009 at 02:16:46AM +0100, Alexander Schrijver wrote: > If the directory entry

Re: Missing check in ftp(1)

2010-06-27 Thread Alexander Schrijver
On Sun, Jun 27, 2010 at 02:04:27AM +0200, Peter Hessler wrote: > Hi Alexander > > This diff had some issues for me, namely the chunk below. > > :+ if (line == NULL); > > > However I did adjust it and came up with this instead, does it also fix > the issue for you? Ugh, th

httpd patterns double free

2016-02-11 Thread Alexander Schrijver
I ran into this issue when setting up my public_html folder using this configuration. prefork 2 server "default" { listen on * port 80 location match "/~*" { root "/users" } } types { text/csscss text/html html htm text/txtt

Re: httpd patterns double free

2016-02-14 Thread Alexander Schrijver
On Sun, Feb 14, 2016 at 12:20:53PM +0100, Martin Natano wrote: > Are you sure the issue you ran into is caused by server_close_http() > being called twice? The only caller thereof is server_free(), which also > frees the client struct. This would result in use after free in > server_close_http() ev

Re: sed -i

2015-07-17 Thread Alexander Schrijver
On Fri, Jul 17, 2015 at 06:10:46PM +0200, Jasper Lievisse Adriaanse wrote: > Here's a diff to add the '-i' flag to sed to do inplace edits. It's mostly > from FreeBSD with some adjustments to prevent a race with unlink() and fopen() > during the tempfile creation. \o/

libssl cleanup

2014-05-25 Thread Alexander Schrijver
This diff boils down to: removing unused shit. src/ssl/ssl_locl.h: - FP_ICC isn't used anylonger. - The fips function was removed. - Those defines aren't used anylonger. src/ssl/ssl_lib.c: - That bit of code has been disabled since 1998 (and perhaps before, there is no archive). And the data st

Use strdup

2014-05-25 Thread Alexander Schrijver
Use strdup instead of hand-rolling one. Index: src/crypto/objects/obj_lib.c === RCS file: /backup/mirrors/cvsync/src/lib/libssl/src/crypto/objects/obj_lib.c,v retrieving revision 1.8 diff -u -p -u -r1.8 obj_lib.c --- src/crypto/object

c_rehash doesn't exist.

2014-05-25 Thread Alexander Schrijver
c_rehash doesn't exist in OpenBSD and remove a history lesson which is either not aplicable anymore or was never true. Index: openssl.1 === RCS file: /backup/mirrors/cvsync/src/usr.sbin/openssl/openssl.1,v retrieving revision 1.93 dif

libssl code disabled since 1998

2014-05-29 Thread Alexander Schrijver
The diff below removes code which has been disabled since 1998 or maybe even before. https://github.com/openssl/openssl/blame/master/ssl/ssl.h#L1758-L1764 There is a lot of interesting backwards compatibility stuff before and after this piece of code. I have a diff for the SSL_(set|get)_(time|tim

libssl remove SSL_(set|get)_(time|timeout)

2014-05-29 Thread Alexander Schrijver
I'm not sure how much, and if this breaks anything in Ports. According to github it isn't used much. https://github.com/search?q=SSL_get_time+extension%3Ac+language%3Ac&type=Code&ref=searchresults https://github.com/search?q=SSL_set_time+extension%3Ac+language%3Ac&type=Code&ref=searchresults http

Re: issues with yacc/lex(er) from OpenBSD across my rules/grammer

2011-06-07 Thread Alexander Schrijver
Your keywords aren't sorted. On Tue, Jun 7, 2011 at 12:09 PM, Rafael Sadowski wrote: > On Wed Jun 01, 2011 at 11:03:46AM +0200, Otto Moerbeek wrote: > > On Wed, Jun 01, 2011 at 10:54:05AM +0200, Rafael Sadowski wrote: > > > > > Hello @tech, > > > > > > I hope anybody can help my with my yacc rule

grep(1) integer overflow

2011-07-17 Thread Alexander Schrijver
This fixes an integer overflow with very long lines. OK? Index: util.c === RCS file: /home/alex/scm/cvsync/src/usr.bin/grep/util.c,v retrieving revision 1.41 diff -u -r1.41 util.c --- util.c 11 Jul 2011 20:43:21 - 1.41

grep(1) spacing

2011-07-17 Thread Alexander Schrijver
Fix spacing. OK? Index: mmfile.c === RCS file: /home/alex/scm/cvsync/src/usr.bin/grep/mmfile.c,v retrieving revision 1.13 diff -u -r1.13 mmfile.c --- mmfile.c2 Jul 2010 20:48:48 - 1.13 +++ mmfile.c16 Jul 2011 22:14:

Re: grep(1) integer overflow

2011-07-17 Thread Alexander Schrijver
On Sun, Jul 17, 2011 at 11:32:27AM +0200, Otto Moerbeek wrote: > On Sun, Jul 17, 2011 at 11:20:28AM +0200, Alexander Schrijver wrote: > > > This fixes an integer overflow with very long lines. > > > > OK? > > Hmm, changing from a signed to an unsigned type migh

Re: grep(1) integer overflow

2011-07-17 Thread Alexander Schrijver
> nope, only ssize_t is guaranteed. This is the only way i could think off. Index: util.c === RCS file: /home/alex/scm/cvsync/src/usr.bin/grep/util.c,v retrieving revision 1.41 diff -u -r1.41 util.c --- util.c 11 Jul 2011 20:43

lkm(4) streams implementation

2011-08-18 Thread Alexander Schrijver
Don't mention loadable streams modules are lacking. OK? Index: lkm.4 === RCS file: /home/alex/scm/cvsync/src/share/man/man4/lkm.4,v retrieving revision 1.15 diff -u -r1.15 lkm.4 --- lkm.4 2 Aug 2008 09:17:46 - 1.15 ++

uticom firmware

2010-12-16 Thread Alexander Schrijver
This diff makes the uticom(4) driver work on my machine with an Abbott USB converter, which is used to connect to the Abbott Freestyle series glucose meter. This makes the firmware loading work again. Index: usbdevs === RCS file: /ho

Re: Workaround for data corruption issue with ALI M5229 IDE chip used with Sun Blade 100/Netra X1.

2011-01-14 Thread Alexander Schrijver
> The big question of course is whether it will survive a make build > with the change that removes the restriction of only using Ultra-DMA > up to mode 2, but without the fixes in pciide.c. > > Beware, that might actually eat your filesystem. > I'm doing this right now. I'm running a make build

Re: Workaround for data corruption issue with ALI M5229 IDE chip used with Sun Blade 100/Netra X1.

2011-01-15 Thread Alexander Schrijver
On Sat, Jan 15, 2011 at 12:17:54PM +0100, Mark Kettenis wrote: > > Date: Fri, 14 Jan 2011 18:56:07 +0100 > > From: Alexander Schrijver > > > > > The big question of course is whether it will survive a make build > > > with the change that removes the restrict

Re: [patch] -H flag for grep.

2011-02-21 Thread Alexander Schrijver
On Mon, Feb 21, 2011 at 01:34:51PM +0100, Pascal Stumpf wrote: > Implement a -H flag for grep, useful for combining e.g. find and grep. -o used to do this but has been removed. (See the commit logs for the reason, i forgot it) grep(1) only prints the filename when it receives more then 1 filename

Re: [patch] -H flag for grep.

2011-02-21 Thread Alexander Schrijver
On Mon, Feb 21, 2011 at 05:05:56PM +0100, Paul de Weerd wrote: > It does not when there's only one file matching the find-experssion > (which is unclear when using find | xargs grep). > > [weerd@despair] $ find . -name pi.c > ./pi.c > [weerd@despair] $ find . -name pi.c | xargs grep main > main(in

Re: vmmap replacement -- please test

2011-12-31 Thread Alexander Schrijver
On Fri, Dec 30, 2011 at 05:55:27PM +0100, Ariane van der Steldt wrote: > I'll need testing on any and all architectures. Is this in snapshots too?

Re: vmmap replacement -- please test

2012-01-03 Thread Alexander Schrijver
On Fri, Dec 30, 2011 at 05:55:27PM +0100, Ariane van der Steldt wrote: > - it's only a 3^W 10494 line diff :P Wow, you weren't kidding. > I'll need testing on any and all architectures. I'm now running this on my sparc64, macppc and amd64 boxes, the amd64 is the only one i currently actually use