[no subject]

2023-07-27 Thread S V
I was trying (as an experiment) to build aarch64 current kernel with -march=armv8-a+simd and stumble upon error Interesting to notice that armv8-a+nofp+simd compiles and runs OK part of output with error: cc -g -Werror -Wall -Wimplicit-function-declaration -Wno-pointer-sign -Wno-constant-conve

iked: more ibuf cleanup

2023-07-27 Thread Claudio Jeker
Use ibuf_data() instead of direct access to ibuf->buf. In some cases use ibuf_add_buf(). -- :wq Claudio Index: crypto.c === RCS file: /cvs/src/sbin/iked/crypto.c,v retrieving revision 1.44 diff -u -p -r1.44 crypto.c --- crypto.c

Re: iked: more ibuf cleanup

2023-07-27 Thread Tobias Heider
On Thu, Jul 27, 2023 at 03:31:32PM +0200, Claudio Jeker wrote: > Use ibuf_data() instead of direct access to ibuf->buf. > In some cases use ibuf_add_buf(). > > -- > :wq Claudio ok tobhe@ > > Index: crypto.c > === > RCS file: /cvs/

Re:

2023-07-27 Thread Theo de Raadt
You don't explain why you are trying to enable floating point register use in the kernel. S V wrote: > I was trying (as an experiment) to build aarch64 current kernel with > -march=armv8-a+simd and stumble upon error > > Interesting to notice that armv8-a+nofp+simd compiles and runs OK > > par

use NULL for function pointer init in virtio devs

2023-07-27 Thread Dave Voutila
While hunting a perf issue with vmd's vioblk emulation, stumbled upon some virtio drivers initializing function pointers to 0 for their config change handlers. Switch to using NULL for better semantic fit. ok? diff refs/heads/master refs/heads/virtio commit - 2287d13a721783c23c3036e2df45e2d342fd

Re:

2023-07-27 Thread S V
2023-07-27 17:24 GMT+03:00, Theo de Raadt : > You don't explain why you are trying to enable floating point register > use in the kernel. I just have CPU with it (Cortex-a57 with NEON), so was toying with it trying to look if I get more performance. Got this error and decided to post, thinking - m

[no subject]

2023-07-27 Thread Theo de Raadt
S V wrote: > 2023-07-27 17:24 GMT+03:00, Theo de Raadt : > > You don't explain why you are trying to enable floating point register > > use in the kernel. > > I just have CPU with it (Cortex-a57 with NEON), so was toying with it > trying to look if I get more performance. > Got this error and de

Re:

2023-07-27 Thread S V
2023-07-27 18:14 GMT+03:00, Theo de Raadt : > S V wrote: > >> 2023-07-27 17:24 GMT+03:00, Theo de Raadt : >> > You don't explain why you are trying to enable floating point register >> > use in the kernel. >> >> I just have CPU with it (Cortex-a57 with NEON), so was toying with it >> trying to loo

Re: iked: more ibuf cleanup

2023-07-27 Thread Theo Buehler
On Thu, Jul 27, 2023 at 03:31:32PM +0200, Claudio Jeker wrote: > Use ibuf_data() instead of direct access to ibuf->buf. > In some cases use ibuf_add_buf(). ok > - print_hex(t->buf, 0, ibuf_length(t)); > + print_hex(ibuf_data(t), 0, ibuf_length(t)); There's a lot of these. Maybe worth add

Re: fix vlan handling with tcplro on ix(4)

2023-07-27 Thread Chris Cappuccio
Jan Klemkow [j.klem...@wemelug.de] wrote: > +#if NVLAN > 0 > + if (ext.evh) > + hdrlen += ETHER_VLAN_ENCAP_LEN; > +#endif > if (ext.ip4) > hdrlen += ext.ip4->ip_hl <<

Re: fix vlan handling with tcplro on ix(4)

2023-07-27 Thread Alexander Bluhm
On Thu, Jul 27, 2023 at 09:15:48AM -0700, Chris Cappuccio wrote: > Jan Klemkow [j.klem...@wemelug.de] wrote: > > +#if NVLAN > 0 > > + if (ext.evh) > > + hdrlen += ETHER_VLAN_ENCAP_LEN; > > +#endif > > if (ext.ip

Re: hardclock: move setitimer(2) code into itimer_update()

2023-07-27 Thread Scott Cheloha
On Wed, Jul 26, 2023 at 11:16:19AM -0500, Scott Cheloha wrote: > This is the next patch in the clock interrupt reorganization series. > > Now that statclock() is cleaned up we can turn to hardclock(). > > [...] > > This patch moves the setitimer(2) code out of hardclock(). The big > idea is ide