Re: new usb id for urtwn

Ping? Ok? On Thu, 21 Jun 2018 at 18:28, Mikhail wrote: > Taken from FreeBSD: > > diff --git a/sys/dev/usb/if_urtwn.c b/sys/dev/usb/if_urtwn.c > index 0e204a196b1..d9aee16b05f 100644 > --- a/sys/dev/usb/if_urtwn.c > +++ b/sys/dev/usb/if_urtwn.c > @@ -306,6 +306,7 @@ static const struct urtwn_type

Re: new usb id for urtwn

On 2018/07/11 16:27, Mikhail wrote: > Ping? Ok? > > On Thu, 21 Jun 2018 at 18:28, Mikhail wrote: > > > Taken from FreeBSD: > > > > diff --git a/sys/dev/usb/if_urtwn.c b/sys/dev/usb/if_urtwn.c > > index 0e204a196b1..d9aee16b05f 100644 > > --- a/sys/dev/usb/if_urtwn.c > > +++ b/sys/dev/usb/if_urtw

Re: new usb id for urtwn

Sorry, new patch attached. On Wed, Jul 11, 2018 at 4:45 PM, Stuart Henderson wrote: > On 2018/07/11 16:27, Mikhail wrote: >> Ping? Ok? >> >> On Thu, 21 Jun 2018 at 18:28, Mikhail wrote: >> >> > Taken from FreeBSD: >> > >> > diff --git a/sys/dev/usb/if_urtwn.c b/sys/dev/usb/if_urtwn.c >> > index

Re: ospf6d: depend on

On Wed, Jul 11, 2018 at 02:59:30PM +0200, Florian Riehm wrote: > Hi, > > successfully tested. I like the feature! Thanks! > Some (mostly cosmetic) comments inline. I fixed them. Updated diff below. > Index: ospfe.c > === > RCS fil

Re: ospf6d: depend on

On Wed, Jul 11 2018, Remi Locherer wrote: > On Wed, Jul 11, 2018 at 02:59:30PM +0200, Florian Riehm wrote: >> Hi, >> >> successfully tested. I like the feature! > Thanks! > >> Some (mostly cosmetic) comments inline. > I fixed them. Updated diff below. LGTM, ok jca@ -- jca | PGP : 0x1524E7EE /

Re: ospf6d: depend on

OK friehm@ On 07/11/18 18:21, Remi Locherer wrote: On Wed, Jul 11, 2018 at 02:59:30PM +0200, Florian Riehm wrote: Hi, successfully tested. I like the feature! Thanks! Some (mostly cosmetic) comments inline. I fixed them. Updated diff below. Index: ospfe.c =

Re: ifconfig,route,netstat: s/tableid/rtable/ for consistency

On Tue, Apr 10, 2018 at 11:23:24PM +0200, Klemens Nanni wrote: > Several tools may operate on specific routing tables (or routing domains > in special cases). > > With the exception of `tableid' in ifconfig(8), route(8) and netstat(1), > all other manuals denote the respective argument as `rtable'

Re: Remove i386 specific mention for pcvtfonts in hier.7

On Wed, Jul 11, 2018 at 10:34:39AM +0200, Frederic Cambus wrote: > Hi tech@, > > Remove the i386 specific mention for pcvtfonts, they are also installed > on alpha and amd64. > > From share/misc/Makefile: > > .if (${MACHINE} == "i386") || (${MACHINE} == "amd64") || \ > (${MACHINE} == "alpha"

bgpd: better hash functions

Especially the rde_aspath hash function is horrible. Fix this by adding more bits to the SipHash which results in a better spread. Also switch the stored hases to 64bit and save the one for rde_aspath as well since it the compare a lot quicker. -- :wq Claudio Index: rde.h ===

ospf6d: add support for rdomains

Hi, This adds rdomain support to ospf6d. It works the same as in ospfd. OK? Remi Index: ospf6ctl/ospf6ctl.c === RCS file: /cvs/src/usr.sbin/ospf6ctl/ospf6ctl.c,v retrieving revision 1.48 diff -u -p -r1.48 ospf6ctl.c --- ospf6ctl/o

__func__ to panic() calls in sys/net*

Hello, tb@ hinted to me that sys/net* can benefit from more __func__ springkling and I these are the potentially useful places that I found. ok? Index: net/if_pppx.c === RCS file: /home/nayden/cvsync/src/sys/net/if_pppx.c,v retriev

Re: __func__ to panic() calls in sys/net*

nayden(nay...@ndtm.net) on 2018.07.11 13:27:33 -0600: > Hello, > > tb@ hinted to me that sys/net* can benefit from more __func__ > springkling and I these are the potentially useful places that > I found. > > ok? if noone working on these files currently stopsyou, ok benno@ > > Index: net/if_

bgpd: check if we are running in an rtable or a rdomain

ok? (benno_check_rdomain.diff) diff --git usr.sbin/bgpd/config.c usr.sbin/bgpd/config.c index 2a2e5dfa314..4f8134e6b68 100644 --- usr.sbin/bgpd/config.c +++ usr.sbin/bgpd/config.c @@ -46,6 +46,7 @@ struct bgpd_config * new_config(void) { struct bgpd_config *conf; + u_int

Re: bgpd: check if we are running in an rtable or a rdomain

On Wed, Jul 11, 2018 at 10:18:59PM +0200, Sebastian Benoit wrote: > > ok? OK claudio@ > (benno_check_rdomain.diff) > > diff --git usr.sbin/bgpd/config.c usr.sbin/bgpd/config.c > index 2a2e5dfa314..4f8134e6b68 100644 > --- usr.sbin/bgpd/config.c > +++ usr.sbin/bgpd/config.c > @@ -46,6 +46,7 @@

kill RTM_Losing in route6d

See subject, it is not using it in any sensible way. -- :wq Claudio Index: route6d.c === RCS file: /cvs/src/usr.sbin/route6d/route6d.c,v retrieving revision 1.96 diff -u -p -r1.96 route6d.c --- route6d.c 1 Jul 2018 15:42:37 -

21st century lam(1)

Hi, some time ago, i went on a rampage to improve UTF-8 support in userland utilities. But there are still a few stragglers among the more obscure beasts out there. For example, have you met lam(1)? When LC_CTYPE=en_US.UTF-8 is set, let's fix the column alignment in the presence of width 0 and

Re: bgpd: announce prefixes with priority n

On Wed, Jul 11, 2018 at 12:43:41AM +0200, Sebastian Benoit wrote: > hi, > > allows you to announce prefixes from the kernel routing table selected by > priority. > > lightly tested, as in, the config part works. > > network inet priority 32 > > ok? This is fairly esotheric as a feature. It w

Re: fix a few clang warnings for gnu cvs

On Tue, Jul 10, 2018 at 05:00:15PM +0200, Theo Buehler wrote: > Had these Ms in my trees for a while. > > Does not fix all warnings, but a few simple ones: > > Use "%s" to print modifiable strings, add a couple of braces, ansify a > few functions and remove a few extra parens. Looks good to me!

Time to retire RTM_LOSING

On busy servers I seen multiple RTM_LOSING message per second being generated. This is not helpful (especially since nothing is doing something with it). This diff removes the part where RTM_LOSING is generated but at the same time adds some RTM_ADD / RTM_DELETE messages for the dynamic routes adde

rc(8): don't hide failures from route6d & rtadvd

at least rtadvd has it's own check and failes to start if forwarding is not enabled, not sure what route6d is doing. rc(8) should not silently hide errors. OK? diff --git etc/rc etc/rc index 21f009306cb..938f4858301 100644 --- etc/rc +++ etc/rc @@ -575,14 +575,7 @@ run_upgrade_script sysmerge

Re: soii addresses for interfaces without layer 2 addresses

On 10/07/18(Tue) 18:01, Florian Obser wrote: > When an interface doesn't have a layer 2 address in6_get_soii_ifid() > failes and then later on a in in6_get_ifid() a layer 2 address is > "borrowed" from from another interface. > > Do the "borrowing" in in6_get_soii_ifid(), too s

Re: Time to retire RTM_LOSING

On 11/07/18(Wed) 09:55, Claudio Jeker wrote: > On busy servers I seen multiple RTM_LOSING message per second being > generated. This is not helpful (especially since nothing is doing > something with it). This diff removes the part where RTM_LOSING is > generated I'm fine with that. However what

Re: soii addresses for interfaces without layer 2 addresses

On Wed, Jul 11, 2018 at 10:04:53AM +0200, Martin Pieuchot wrote: > On 10/07/18(Tue) 18:01, Florian Obser wrote: > > When an interface doesn't have a layer 2 address in6_get_soii_ifid() > > failes and then later on a in in6_get_ifid() a layer 2 address is > > "borrowed" from from another

Re: Time to retire RTM_LOSING

On Wed, Jul 11, 2018 at 10:10:50AM +0200, Martin Pieuchot wrote: > On 11/07/18(Wed) 09:55, Claudio Jeker wrote: > > On busy servers I seen multiple RTM_LOSING message per second being > > generated. This is not helpful (especially since nothing is doing > > something with it). This diff removes the

Re: rc(8): don't hide failures from route6d & rtadvd

net.inet6.ip6.forwarding=0 OK(failed) On 2018 Jul 11 (Wed) at 09:58:18 +0200 (+0200), Florian Obser wrote: :at least rtadvd has it's own check and failes to start if forwarding :is not enabled, not sure what route6d is doing. : :rc(8) should not silently hide errors. : :OK? : :diff --git etc/rc e

Remove i386 specific mention for pcvtfonts in hier.7

Hi tech@, Remove the i386 specific mention for pcvtfonts, they are also installed on alpha and amd64. >From share/misc/Makefile: .if (${MACHINE} == "i386") || (${MACHINE} == "amd64") || \ (${MACHINE} == "alpha") SUBDIR= pcvtfonts .endif Comments? OK? Index: share/man/man7/hier.7 ==

Re: bgpd: announce prefixes with priority n

On Wed, Jul 11, 2018 at 12:43:41AM +0200, Sebastian Benoit wrote: > hi, > > allows you to announce prefixes from the kernel routing table selected by > priority. > > lightly tested, as in, the config part works. > > network inet priority 32 > > ok? works in my lab setup. OK remi@ > > (benn

Re: Remove i386 specific mention for pcvtfonts in hier.7

On Wed, Jul 11, 2018 at 10:34:39AM +0200, Frederic Cambus wrote: > Hi tech@, > > Remove the i386 specific mention for pcvtfonts, they are also installed > on alpha and amd64. I guess they could be installed on all archirectures. load_font is supported on many of them and the risk of forgetting t

Re: ospfd: change control socket to ospfd.sock.

Please initialize *sockname with NULL, then OK . On 07/11/18 00:33, Remi Locherer wrote: Hi, This changes the name of the ospfd control socket to include the rdomain. It's similar to what bgpd does. OK? Remi Index: ospfd/ospfd.c ==

usbdevs(8): fewer buttons

Instead of having a button for printing the driver(s) attached to a USB device, do it when invoked with '-v'. This allows me to recycle '-d'. I'm now using it, like pcidump(8) does, to specify a specific device node. My plan is then to use '-f' to force a device to attach as ugen(4). In that ca

ospf6ctl parse.y: remove wrong comment

in parse.y from ospfd this comment is followed by md_list_clr(&globaldefs.md_list); which does not exist in ospd6d. OK? Remi Index: parse.y === RCS file: /cvs/src/usr.sbin/ospf6d/parse.y,v retrieving revision 1.34 diff -u -

Re: ospfd: change control socket to ospfd.sock.

On Wed, Jul 11 2018, Remi Locherer wrote: > Hi, > > This changes the name of the ospfd control socket to include the rdomain. > It's similar to what bgpd does. > > OK? ok with the change suggested by friehm@ -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

Re: usbdevs(8): fewer buttons

On Wed, Jul 11 2018, Martin Pieuchot wrote: > Instead of having a button for printing the driver(s) attached to a USB > device, do it when invoked with '-v'. This allows me to recycle '-d'. > > I'm now using it, like pcidump(8) does, to specify a specific device > node. > > My plan is then to use

Re: ospf6ctl parse.y: remove wrong comment

On Wed, Jul 11 2018, Remi Locherer wrote: > in parse.y from ospfd this comment is followed by > md_list_clr(&globaldefs.md_list); > which does not exist in ospd6d. > > OK? Sure. > Remi > > > Index: parse.y > === > RCS file: /c

Re: ospf6d: depend on

On Tue, Jul 10, 2018 at 03:22:43PM +0200, Remi Locherer wrote: > Hi, > > With the "depend on" option routes are sent out with a metric of 65535 if > the referenced interface is down or in state backup. This is especially > useful on a carp cluster to ensure all traffic goes to the carp master. >

ospfd printconf: print rdomain

This makes "ospfd -nv" print the rdomain config option if present. OK? Remi Index: printconf.c === RCS file: /cvs/src/usr.sbin/ospfd/printconf.c,v retrieving revision 1.18 diff -u -p -r1.18 printconf.c --- printconf.c 5 Feb 2018 12:

Re: signal to process or posix thread

On Mon, Jul 09, 2018 at 10:59:54PM +0200, Alexander Bluhm wrote: > On Mon, Jul 09, 2018 at 11:27:55AM -0900, Philip Guenther wrote: > > Those signals are handled by the first thread that > > > doesn't have them masked. In that case, it should be put on the pending > > > list of the process and any

Re: ospfd printconf: print rdomain

OK

Re: ospf6d: depend on

Hi, successfully tested. I like the feature! Some (mostly cosmetic) comments inline. Index: ospfe.c === RCS file: /cvs/src/usr.sbin/ospf6d/ospfe.c,v retrieving revision 1.51 diff -u -p -r1.51 ospfe.c --- ospfe.c 12 Aug 2017 16

Re: signal to process or posix thread

On Wed, Jul 11, 2018 at 03:40:23PM +0300, Paul Irofti wrote: > > This is my original diff with some twaeks from visa@. > > While I think this is a step in the right direction I don't think is the > proper solution to the problem. It is not intended as final solution. My problem is that posixtest