On Fri, Jul 07, 2023 at 12:07:36PM +0300, YASUOKA Masahiko wrote:
> Hi,
>
> This netstat diff is already needed to avoid compiler warnings since
> it uses struct tcpcb directly.
>
> ok?
OK bluhm@
> Index: usr.bin/netstat/inet.c
> =
Hi,
This netstat diff is already needed to avoid compiler warnings since
it uses struct tcpcb directly.
ok?
Index: usr.bin/netstat/inet.c
===
RCS file: /cvs/src/usr.bin/netstat/inet.c,v
retrieving revision 1.177
diff -u -p -r1.177 i
On Fri, Jul 07, 2023 at 10:43:21AM +0200, Claudio Jeker wrote:
> On Fri, Jul 07, 2023 at 11:38:58AM +0300, YASUOKA Masahiko wrote:
> > Hi,
> >
> > Does using 64 bit for timer in tcpcb require this?
>
> Not sure about this but one comment below.
When we introduced struct tcp_info, we discussed if
On Fri, 7 Jul 2023 10:43:21 +0200
Claudio Jeker wrote:
>> @@ -411,7 +412,7 @@ tcp_stats_display(unsigned long long tot
>> P(tcpi, rcv_up, "%u")
>> P(tcpi, rcv_wscale, "%hhu")
>> P(tcpi, rfbuf_cnt, "%u")
>> -P(tcpi,
On Fri, Jul 07, 2023 at 11:38:58AM +0300, YASUOKA Masahiko wrote:
> Hi,
>
> Does using 64 bit for timer in tcpcb require this?
Not sure about this but one comment below.
> ok?
>
> Index: sys/netinet/tcp.h
> ===
> RCS file: /cvs/sr
Hi,
Does using 64 bit for timer in tcpcb require this?
ok?
Index: sys/netinet/tcp.h
===
RCS file: /cvs/src/sys/netinet/tcp.h,v
retrieving revision 1.24
diff -u -p -r1.24 tcp.h
--- sys/netinet/tcp.h 19 May 2023 01:04:39 -
On Tue, 4 Jul 2023 12:14:47 +0300
Alexander Bluhm wrote:
> After changing tcp now tick to milliseconds, it will wrap around
> after 49 days of uptime. That may be a problem in some places of
> our stack. Better use a 64 bit counter.
I agree since we sometimes hit a problem from where we could n
Hi,
After changing tcp now tick to milliseconds, it will wrap around
after 49 days of uptime. That may be a problem in some places of
our stack. Better use a 64 bit counter.
As timestamp option is 32 bit in TCP protocol, we have to use the
lower 32 bit there. There are casts to 32 bits that sh
