Re: another syzkaller problem in pf

2022-06-26 Thread Alexander Bluhm
On Sun, Jun 26, 2022 at 12:02:41PM +0200, Moritz Buhl wrote: > On Tue, May 03, 2022 at 09:31:51PM +0200, Alexander Bluhm wrote: > ... > > The code is too complex to be sure what the reason of the syzkaller > > panic is. Sleep in malloc is correct anyway and may improve the > > situation. > > > >

Re: another syzkaller problem in pf

2022-06-26 Thread Moritz Buhl
On Tue, May 03, 2022 at 09:31:51PM +0200, Alexander Bluhm wrote: ... > The code is too complex to be sure what the reason of the syzkaller > panic is. Sleep in malloc is correct anyway and may improve the > situation. > > Functions with argument values 0 or 1 are hard to read. It would > be much

Re: [External] : Re: another syzkaller problem in pf

2022-05-04 Thread Alexandr Nedvedicky
On Wed, May 04, 2022 at 04:26:18PM +0200, Alexander Bluhm wrote: > On Wed, May 04, 2022 at 02:21:11PM +0200, Alexandr Nedvedicky wrote: > > I'm not sure flipping a flag is a right change. In general we don't want > > to hold NET_LOCK()/PF_LOCK() while waiting for memory. > > - We must not

Re: [External] : Re: another syzkaller problem in pf

2022-05-04 Thread Alexander Bluhm
On Wed, May 04, 2022 at 02:21:11PM +0200, Alexandr Nedvedicky wrote: > I'm not sure flipping a flag is a right change. In general we don't want > to hold NET_LOCK()/PF_LOCK() while waiting for memory. - We must not wait for memory when in the packet processing hot path. Drop the packet i

Re: [External] : Re: another syzkaller problem in pf

2022-05-04 Thread Alexandr Nedvedicky
On Tue, May 03, 2022 at 09:31:51PM +0200, Alexander Bluhm wrote: > On Tue, May 03, 2022 at 07:42:34PM +0200, Moritz Buhl wrote: > > commit 4b3977248902c22d96aaebdb5784840debc2631c > > Author: mikeb > > Date: Mon Nov 24 13:22:09 2008 + > > > > Fix splasserts seen in pr 5987 by propagatin

Re: another syzkaller problem in pf

2022-05-03 Thread Alexander Bluhm
On Tue, May 03, 2022 at 07:42:34PM +0200, Moritz Buhl wrote: > commit 4b3977248902c22d96aaebdb5784840debc2631c > Author: mikeb > Date: Mon Nov 24 13:22:09 2008 + > > Fix splasserts seen in pr 5987 by propagating a flag that discribes > whether we're called from the interrupt context

Re: another syzkaller problem in pf

2022-05-03 Thread Ted Unangst
On 2022-05-03, Moritz Buhl wrote: > Hi tech@, > > Syzkaller found a few crashes in pf_anchor_global_RB_REMOVE. > https://syzkaller.appspot.com/bug?id=a97f712331903ce38b8c084a489818b9bb5c6fcb > and also > https://syzkaller.appspot.com/text?tag=CrashLog&x=15ace9aaf0 > > The call stack is someth

another syzkaller problem in pf

2022-05-03 Thread Moritz Buhl
Hi tech@, Syzkaller found a few crashes in pf_anchor_global_RB_REMOVE. https://syzkaller.appspot.com/bug?id=a97f712331903ce38b8c084a489818b9bb5c6fcb and also https://syzkaller.appspot.com/text?tag=CrashLog&x=15ace9aaf0 The call stack is something like this: pf_anchor_global_RB_REMOVE pf_remov