Re: uvm_map_inentry() checks in trap()

2020-09-24 Thread Miod Vallat
> Repeating diffs from i386, amd64, sh. Improve alpha diff to handle an > additional fault case. Adding diffs for powerpc, powerc64, and m88k. The m88k diff is incomplete: - changes need to be done in both m88100_trap() and m88110_trap(). - the uvm_map_inentry() check should be put after the use

Re: uvm_map_inentry() checks in trap()

2020-09-23 Thread Theo de Raadt
Theo de Raadt wrote: > kettenis, mortimer, and I have had long discussions about the > uvm_map_inentry() checks in MD trap.c being excessively broad. We can > this check-function less often. > > I don't want to explain the full picture about how SP and PC checks > in syscall() and trap() hinder

Re: uvm_map_inentry() checks in trap()

2020-09-23 Thread Theo de Raadt
Theo de Raadt wrote: > Theo de Raadt wrote: > > > kettenis, mortimer, and I have had long discussions about the > > uvm_map_inentry() checks in MD trap.c being excessively broad. We can > > this check-function less often. > > > > I don't want to explain the full picture about how SP and PC ch

Re: uvm_map_inentry() checks in trap()

2020-09-23 Thread Theo de Raadt
Theo de Raadt wrote: > kettenis, mortimer, and I have had long discussions about the > uvm_map_inentry() checks in MD trap.c being excessively broad. We can > this check-function less often. > > I don't want to explain the full picture about how SP and PC checks > in syscall() and trap() hinder