Re: bgpd: rewrite code to send UPDATE messages

2023-07-11 Thread Theo Buehler
> Updated diff below I have now spent a lot of time on this diff. Let's commit it in after the upcoming release. ok tb

Re: bgpd: rewrite code to send UPDATE messages

2023-06-29 Thread Theo Buehler
> > > - if ((new = reallocarray(comm->communities, newsize, > > > - sizeof(struct community))) == NULL) > > > + if ((new = recallocarray(comm->communities, comm->size, > > > + newsize, sizeof(struct community))) == NULL) > > > fatal(__func__

Re: bgpd: rewrite code to send UPDATE messages

2023-06-29 Thread Claudio Jeker
On Thu, Jun 29, 2023 at 06:25:01PM +0200, Theo Buehler wrote: > On Tue, Jun 27, 2023 at 12:10:21PM +0200, Claudio Jeker wrote: > > Sorry this diff is a monster but it kind of turned into a all or nothing > > situation. > > Frankly, it's not that bad. > > > For a long time bgpd used a static 4k bu

Re: bgpd: rewrite code to send UPDATE messages

2023-06-29 Thread Theo Buehler
On Tue, Jun 27, 2023 at 12:10:21PM +0200, Claudio Jeker wrote: > Sorry this diff is a monster but it kind of turned into a all or nothing > situation. Frankly, it's not that bad. > For a long time bgpd used a static 4k buffer plus a len argument to build > updates. The result was ok but was also