Re: Use off_t for lineno in csplit

2015-12-14 Thread Michael McConville
Mark Kettenis wrote: > > Date: Sat, 12 Dec 2015 16:26:30 -0500 > > From: Michael McConville > > > > Mark Kettenis wrote: > > > It really is confusing to use off_t for something that's not a byte > > > offset. If integer overflow really is an issue you care about, use > > > "long long". > > > >

Re: Use off_t for lineno in csplit

2015-12-12 Thread Mark Kettenis
> Date: Sat, 12 Dec 2015 16:26:30 -0500 > From: Michael McConville > > Mark Kettenis wrote: > > It really is confusing to use off_t for something that's not a byte > > offset. If integer overflow really is an issue you care about, use > > "long long". > > ok for the below diff to update my grep

Re: Use off_t for lineno in csplit

2015-12-12 Thread Michael McConville
Mark Kettenis wrote: > It really is confusing to use off_t for something that's not a byte > offset. If integer overflow really is an issue you care about, use > "long long". ok for the below diff to update my grep change? > Note that on many non-BSD systems off_t is still a 32-bit integer, at >

Re: Use off_t for lineno in csplit

2015-12-09 Thread Mark Kettenis
> Date: Tue, 8 Dec 2015 13:00:49 -0500 > From: Michael McConville > > I thought I'd look for other examples after the grep fix. > > ok? It really is confusing to use off_t for something that's not a byte offset. If integer overflow really is an issue you care about, use "long long". Note that