Re: PATCH: a bit of introspection in make

2023-08-09 Thread Thomas Frohwein
On Tue, Aug 08, 2023 at 01:02:53PM +0200, Marc Espie wrote: > Actually, as far as bsd.port.mk, it doesn't need to > move too much stuff around thanks to make's lazyness. > > Note that having a list of defined MASTER_SITES variables simplifies > the check. > > I've also added a check for the right

Re: PATCH: a bit of introspection in make

2023-08-09 Thread Thomas Frohwein
On Tue, Aug 08, 2023 at 12:51:43PM +0200, Marc Espie wrote: > Here's a revised diff (reordered plus actual use of the boolean) > plus concrete example use for bsd.port.mk (disregarding the fact > _ALL_VARIABLES would have to move *after* all MASTER_SITES have been defined. I tested this on a smal

Re: PATCH: a bit of introspection in make

2023-08-08 Thread Marc Espie
Actually, as far as bsd.port.mk, it doesn't need to move too much stuff around thanks to make's lazyness. Note that having a list of defined MASTER_SITES variables simplifies the check. I've also added a check for the right MASTER_SITES to be defined, since currently we do not error out until act

Re: PATCH: a bit of introspection in make

2023-08-08 Thread Marc Espie
Here's a revised diff (reordered plus actual use of the boolean) plus concrete example use for bsd.port.mk (disregarding the fact _ALL_VARIABLES would have to move *after* all MASTER_SITES have been defined. Index: var.c === RCS file

Re: PATCH: a bit of introspection in make

2023-08-07 Thread Marc Espie
On Mon, Aug 07, 2023 at 10:05:37PM -0400, Thomas Frohwein wrote: > I looked through the file and it seems that varname_list_changed is > never set to anything but true. Is there a bit missing, like down lower > in varname_list_retrieve()? Yep, I removed it at some point because it looked like some

Re: PATCH: a bit of introspection in make

2023-08-07 Thread Thomas Frohwein
On Mon, Aug 07, 2023 at 04:42:54PM +0200, Marc Espie wrote: > I think it could be occasionally useful to know which variables have > been defined in make. > > Incidentally, this DOES exist in GNU make, so I've reused the same name > for basically the same functionality. > > I haven't checked whet