Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Theo de Raadt
Jimmy Hess wrote: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > > I don't think these are "redundant quotes" but rather ditto marks: > > The ditto mark and the quote character are not the same character, > and the comments are nonsensical since they used the wrong character. > > I

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Ingo Schwarze
Hi, Jimmy Hess wrote on Fri, Apr 20, 2018 at 06:53:44AM -0500: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: >> I don't think these are "redundant quotes" but rather ditto marks: > The ditto mark and the quote character are not the same character, > and the comments are nonsensical s

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Landry Breuil
On Fri, Apr 20, 2018 at 06:53:44AM -0500, Jimmy Hess wrote: > On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > > I don't think these are "redundant quotes" but rather ditto marks: > > The ditto mark and the quote character are not the same character, > and the comments are nonsensical sin

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Jimmy Hess
On Fri, Apr 20, 2018 at 3:57 AM, Theo Buehler wrote: > I don't think these are "redundant quotes" but rather ditto marks: The ditto mark and the quote character are not the same character, and the comments are nonsensical since they used the wrong character. If the writer means Ditto mark, the

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Nan Xiao
Hi Theo, I am very sorry for this wrong modification! Thanks! Best Regards Nan Xiao On Fri, Apr 20, 2018 at 4:57 PM, Theo Buehler wrote: > I don't think these are "redundant quotes" but rather ditto marks: > > https://en.wikipedia.org/wiki/Ditto_mark > > this is quite clear here, for example:

Re: [patch] Remove redundant quotes in sys/sys/resource.h and sys/sys/sysctl.h

2018-04-20 Thread Theo Buehler
I don't think these are "redundant quotes" but rather ditto marks: https://en.wikipedia.org/wiki/Ditto_mark this is quite clear here, for example: > u_int64_t p_uru_nvcsw; /* LONG: voluntary context switches. */ > - u_int64_t p_uru_nivcsw; /* LONG: involuntary ". */ >