Re: [patch] Add error handling in usr.bin/time/time.c

Hi, Nan Xiao wrote on Fri, Apr 20, 2018 at 10:11:55PM +0800: > Ingo Schwarze wrote: >> No. Read the manual page and /sys/kern/kern_time.c : >> >> With a valid clock id and a valid address, this function >> cannot fail, so you are just adding dead code. Worse, >> you are making future auditors

Re: [patch] Add error handling in usr.bin/time/time.c

Hi Ingo, > No. Read the manual page and /sys/kern/kern_time.c : > > With a valid clock id and a valid address, this function > cannot fail, so you are just adding dead code. Worse, > you are making future auditors wonder what the heck is > going on here. Sorry, I can't find the above words from

Re: [patch] Add error handling in usr.bin/time/time.c

Hi, Nan Xiao wrote on Fri, Apr 20, 2018 at 05:28:01PM +0800: > FYI, thanks! No. Read the manual page and /sys/kern/kern_time.c : With a valid clock id and a valid address, this function cannot fail, so you are just adding dead code. Worse, you are making future auditors wonder what the heck i