Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-28 Thread Todd C . Miller
On Tue, 28 Mar 2023 16:19:42 +0200, Omar Polo wrote: > sigh... forgot to advance the pointer after strrchr otherwise argv[0] > would have been /ksh instead of "ksh". OK millert@ for this version. - todd

Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-28 Thread Omar Polo
On 2023/03/28 10:21:59 +0200, Omar Polo wrote: > On 2023/03/27 18:58:07 -0600, Todd C. Miller wrote: > > It might be best to use the basename of the actual shell for argv[0]. > > Our ksh for instance has slightly different behavior when invoked > > as sh. > > like this? :) > > (need an up-to-da

Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-28 Thread lux
On Tue, 2023-03-28 at 11:22 +0200, Omar Polo wrote: > On 2023/03/28 17:02:18 +0800, lux wrote: > > On Mon, 2023-03-27 at 18:58 -0600, Todd C.Miller wrote: > > > > > > > -   _exit(1); > > > > -   if (path == NULL) > > > > _exit(1); > > > >  

Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-28 Thread Omar Polo
On 2023/03/28 17:02:18 +0800, lux wrote: > On Mon, 2023-03-27 at 18:58 -0600, Todd C.Miller wrote: > > > > > -   _exit(1); > > > -   if (path == NULL) > > > _exit(1); > > >   > > Hi, `pipeio' looks like a common function, so maby called in

Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-28 Thread lux
On Mon, 2023-03-27 at 18:58 -0600, Todd C.Miller wrote: > > > -   _exit(1); > > -   if (path == NULL) > > _exit(1); > >   Hi, `pipeio' looks like a common function, so maby called in others code, checking the path is NULL is a safe check, to

Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-28 Thread Omar Polo
On 2023/03/27 18:58:07 -0600, Todd C. Miller wrote: > On Mon, 27 Mar 2023 20:06:30 +0200, Omar Polo wrote: > > > Is _PATH_BSHELL portable though? I can see a few stuff that uses it > > (vi among others) but I'm not sure. > > The paths.h header is a BSD invention, though it may be present on > s

Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-27 Thread lux
On Mon, 2023-03-27 at 20:06 +0200, Omar Polo wrote: Hello, thank you for your correction. > > if (dup2(s[1], STDERR_FILENO) == -1) > -   _exit(1); > -   if (path == NULL) > _exit(1); But, I think the condition that path is

Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-27 Thread Todd C . Miller
On Mon, 27 Mar 2023 20:06:30 +0200, Omar Polo wrote: > Is _PATH_BSHELL portable though? I can see a few stuff that uses it > (vi among others) but I'm not sure. The paths.h header is a BSD invention, though it may be present on some other systems. I don't think that's a reason not to use it tho

Re: [patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-27 Thread Omar Polo
Hello, On 2023/03/28 00:53:05 +0800, lux wrote: > Index: region.c > === > RCS file: /cvs/src/usr.bin/mg/region.c,v > retrieving revision 1.40 > diff -u -p -r1.40 region.c > --- region.c 8 Mar 2023 04:43:11 - 1.40 > +++ reg

[patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-27 Thread lux
Index: region.c=== RCS file: /cvs/src/usr.bin/mg/region.c,v retrieving revision 1.40 diff -u -p -r1.40 region.c --- region.c  8 Mar 2023 04:43:11 - 1.40 +++ region.c  27 Mar 2023 16:38:41 - @@ -21,6 +21,7 @@  #incl

[patch] usr.bin/mg/region.c: Set default shell path if SHELL is NULL

2023-03-27 Thread lux
Index: region.c === RCS file: /cvs/src/usr.bin/mg/region.c,v retrieving revision 1.40 diff -u -p -r1.40 region.c --- region.c8 Mar 2023 04:43:11 - 1.40 +++ region.c27 Mar 2023 16:48:08 - @@ -21,6 +21,7 @@ #includ