Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-24 Thread Tobias Heider
On Sun, Jul 23, 2023 at 09:16:40PM +, jon@elytron.openbsd.amsterdam wrote: > If I'm not mistaken, all wskbd_{get,set}_backlight uses are in the > following drivers: acpicbkbd, acpithinkpad, asmc, pwmleds, and now > my implementation in adb. It is my impression that they are roughly > the same c

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-23 Thread jon
If I'm not mistaken, all wskbd_{get,set}_backlight uses are in the following drivers: acpicbkbd, acpithinkpad, asmc, pwmleds, and now my implementation in adb. It is my impression that they are roughly the same code, I have collected them below to ease their inspection. I would also like to acknow

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-23 Thread Mark Kettenis
> Date: Sun, 23 Jul 2023 15:21:38 +0200 > From: Anton Lindqvist > > On Sun, Jul 23, 2023 at 11:37:38AM +, jon@elytron.openbsd.amsterdam wrote: > > Hello all. Thank you very much for your input. I have taken heed of > > your suggestions in the diff below > > > > On Sat, 22 Jul 2023 20:59:04 -

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-23 Thread Anton Lindqvist
On Sun, Jul 23, 2023 at 11:37:38AM +, jon@elytron.openbsd.amsterdam wrote: > Hello all. Thank you very much for your input. I have taken heed of > your suggestions in the diff below > > On Sat, 22 Jul 2023 20:59:04 -0400 George Koehler > wrote: > > > We should check if (wskbd_get_backlight !

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-23 Thread jon
Hello all. Thank you very much for your input. I have taken heed of your suggestions in the diff below On Sat, 22 Jul 2023 20:59:04 -0400 George Koehler wrote: > We should check if (wskbd_get_backlight != NULL), like we do for > WSKBDIO_GETBACKLIGHT. Same for wskbd_set_backlight. Fixed. I am r

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-23 Thread Tobias Heider
On Sat, Jul 22, 2023 at 08:59:04PM -0400, George Koehler wrote: > On Wed, 19 Jul 2023 02:03:26 +0200 > Tobias Heider wrote: > > > > ok anyone? > > > > No one interested in working keyboard backlight shortcuts? > > Don't get scared by the powerbook part, a lot of this is reusable for other > > l

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-22 Thread George Koehler
On Wed, 19 Jul 2023 02:03:26 +0200 Tobias Heider wrote: > > ok anyone? > > No one interested in working keyboard backlight shortcuts? > Don't get scared by the powerbook part, a lot of this is reusable for other > laptop models. The arch/macppc/* part is ok gkoehler@, except for 2 minor style

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-18 Thread Tobias Heider
On Fri, Jul 14, 2023 at 09:17:20PM +0200, Tobias Heider wrote: > On Fri, Jul 14, 2023 at 05:53:41PM +, jon@elytron.openbsd.amsterdam wrote: > > Hello everyone. After a tobhe@'s recent patch [1] to add suspend > > keysyms for other mac laptops, and a brief consultation with him, > > I am reposti

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-14 Thread jon
Thank you very much for testing. > the diff looks good to me except for maybe the numlock bit in > hidkbd I agree, that was part of my incipient attempt to fix numlock on these laptops as well, please drop it from this diff, it is unrelated. > One thing I am never quite sure about is the keycode

Re: [Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-14 Thread Tobias Heider
On Fri, Jul 14, 2023 at 05:53:41PM +, jon@elytron.openbsd.amsterdam wrote: > Hello everyone. After a tobhe@'s recent patch [1] to add suspend > keysyms for other mac laptops, and a brief consultation with him, > I am reposting an updated version of my keyboard backlight > patch [2], which you c

[Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-07-14 Thread jon
Hello everyone. After a tobhe@'s recent patch [1] to add suspend keysyms for other mac laptops, and a brief consultation with him, I am reposting an updated version of my keyboard backlight patch [2], which you can find below: [1] https://marc.info/?l=openbsd-tech&m=168884670208963&w=2 [2] https:

[Diff] Keyboard backlight support for late powerbooks, plus keybindings

2023-02-27 Thread jon
Hello. Following up on my previous post https://marc.info/?l=openbsd-ppc&m=166150553627054&w=2 I actually implemented support for fn-keys controls of the keyboard backlight as outlined there, seems to work fairly ok, would appreciate any feedback Index: arch/macppc/dev/adb.c =