Re: Improve fw_update(9) output on errors somewhat

2023-09-27 Thread Andrew Hewus Fresh
Here's a slightly simpler try suggested by deraadt@. I capture ftp's STDERR and move it to the special "WARN_FD" that groups errors without confusing the status line. I also strip the "name" off the error as it looks a bit nicer than repeating it everywhere. If the fetch fails, we return 1 if we

Improve fw_update(9) output on errors somewhat

2023-09-27 Thread Andrew Hewus Fresh
I did commit a few other fw_update fixes, so if you see any problems with it, let me know soon, although I probably won't have time to look until this weekend. Theo rightly complained that the output from fw_update when the network isn't available isn't very good. $ doas fw_update fw_update:fw_u

Re: Buffer overflow in /usr/bin/deroff

2023-09-27 Thread Crystal Kolipe
On Wed, Sep 27, 2023 at 02:05:14PM -0600, Todd C. Miller wrote: > On Wed, 27 Sep 2023 10:59:26 -0600, "Todd C. Miller" wrote: > > > I think we want support for arbitrary line lengths. There is only > > one place where we need to reallocate the line buffer. > > The correct check is for "lp - line

Re: rpki-client: constraining Trust Anchors

2023-09-27 Thread Jeroen Massar
> The constraints are simple text files and parsed in a restricted > subprocess. Operators can trivially disable the imposition of > constraints by deleting /etc/rpki/*.constraints, if need be. Mmm I fully get your sentiment & concern and agree with it. The biggest problem simply lies in

video(4): make `video_filtops' mpsafe

2023-09-27 Thread Vitaliy Makkoveev
Introduce `sc_mtx` mutex(9) and use it for `sc_frames_ready' and `sc_rklist' knotes list protection. Index: sys/dev/video.c === RCS file: /cvs/src/sys/dev/video.c,v retrieving revision 1.57 diff -u -p -r1.57 video.c --- sys/dev/video.

Re: Buffer overflow in /usr/bin/deroff

2023-09-27 Thread Todd C . Miller
On Wed, 27 Sep 2023 10:59:26 -0600, "Todd C. Miller" wrote: > I think we want support for arbitrary line lengths. There is only > one place where we need to reallocate the line buffer. The correct check is for "lp - line == linesz - 1". The code will overwrite the newline with a NUL so we don't

Re: Buffer overflow in /usr/bin/deroff

2023-09-27 Thread Todd C . Miller
On Wed, 27 Sep 2023 08:37:49 -0300, Crystal Kolipe wrote: > So what do we want? > > 1. Traditional OpenBSD behaviour of breaking input lines at 2047, >(which never actually worked correctly up to now). > 2. Breaking input at 2048. > 3. Support for arbitrary line length with no breaking. > > Pr

mg: "support" for exuberant/universal ctags tags files

2023-09-27 Thread Omar Polo
TL;DR "support" because this is not about supporting the fancy new stuff, but just not breaking on a universal-ctags generated tag file. I'd just like to tell mg enough of the file format to ignore the extensions over plain tag files. The diff is mostly from troglobit' mg: https://github.com/trogl

fuse(4): make `fuse_rd_filtops' mpsafe

2023-09-27 Thread Vitaliy Makkoveev
Introduce `fd_mtx' mutex(9) and use it for `fd_fbufs_in' fuse buffers queue and `fd_rklist' knotes list protection. Index: sys/miscfs/fuse/fuse_device.c === RCS file: /cvs/src/sys/miscfs/fuse/fuse_device.c,v retrieving revision 1.39 d

Re: Buffer overflow in /usr/bin/deroff

2023-09-27 Thread Crystal Kolipe
Hi Marc, On Tue, Sep 19, 2023 at 03:24:41PM +0200, Marc Espie wrote: > On Tue, Sep 19, 2023 at 09:48:25AM -0300, Crystal Kolipe wrote: > > deroff chokes when given lines > 2048 bytes, and produces non-deterministic > > output on little endian archs. > > Since you went to the trouble of reproducin

Re: adjust example bgpd.conf GRACEFUL_SHUTDOWN rule

2023-09-27 Thread Job Snijders
On Wed, Sep 27, 2023 at 12:31:52PM +0200, Claudio Jeker wrote: > Graceful Shutdown should only be done on eBGP sessions. > If you alter the local-pref on ibgp sessions it is possible to produce > loops or other network instabilities. Now if all iBGP routers apply the > same rule it is fine but if n

adjust example bgpd.conf GRACEFUL_SHUTDOWN rule

2023-09-27 Thread Claudio Jeker
Graceful Shutdown should only be done on eBGP sessions. If you alter the local-pref on ibgp sessions it is possible to produce loops or other network instabilities. Now if all iBGP routers apply the same rule it is fine but if not you can get into trouble. So better adjust our example and only app