Re: [sysvinit-devel] [patch] Get startpar building with clang

2014-04-17 Thread Mike Frysinger
On Thu 10 Apr 2014 09:42:13 Petter Reinholdtsen wrote: > I've submitted startpar for review with Coverty, and it reported four > issues on https://scan.coverity.com/projects/1719 >. But the > project is not yet accepted, so I can not figure out which issues this > is. So I had a look at building

Re: [sysvinit-devel] [patch] Get startpar building with clang

2014-04-10 Thread Dr. Werner Fink
On Thu, Apr 10, 2014 at 08:01:35PM +0200, Petter Reinholdtsen wrote: > [Dr. Werner Fink] > > Not that I'm aware ... AFAIK the TEMP_FAILURE_RETRY() macro can not > > be handled this way by the compiler. Maybe a redefinition is required > > to do an error() if errno is not EINTR. > > What do you me

Re: [sysvinit-devel] [patch] Get startpar building with clang

2014-04-10 Thread Petter Reinholdtsen
[Dr. Werner Fink] > Not that I'm aware ... AFAIK the TEMP_FAILURE_RETRY() macro can not > be handled this way by the compiler. Maybe a redefinition is required > to do an error() if errno is not EINTR. What do you mean by 'can not be handled this way'? The definition in my /usr/include/unistd.h

Re: [sysvinit-devel] [patch] Get startpar building with clang

2014-04-10 Thread Dr. Werner Fink
On Thu, Apr 10, 2014 at 09:42:13AM +0200, Petter Reinholdtsen wrote: > > I've submitted startpar for review with Coverty, and it reported four > issues on https://scan.coverity.com/projects/1719 >. But the > project is not yet accepted, so I can not figure out which issues this > is. So I had a

[sysvinit-devel] [patch] Get startpar building with clang

2014-04-10 Thread Petter Reinholdtsen
I've submitted startpar for review with Coverty, and it reported four issues on https://scan.coverity.com/projects/1719 >. But the project is not yet accepted, so I can not figure out which issues this is. So I had a look at building it with clang, and it found a few issues with ignored return v