[systemd-devel] [PATCH v2] journald: add CAP_MAC_OVERRIDE in journald for SMACK issue

2014-09-11 Thread Juho Son
systemd-journald check the cgroup id to support rate limit option for every messages. so journald should be available to access cgroup node in each process send messages to journald. In system using SMACK, cgroup node in proc is assigned execute label as each process's execute label. so if journald

Re: [systemd-devel] Preventing automatic seat assignments

2014-09-11 Thread Tanu Kaskinen
On Wed, 2014-09-10 at 12:44 +0200, David Herrmann wrote: > Hi > > On Tue, Sep 9, 2014 at 10:49 AM, Tanu Kaskinen > wrote: > > On Wed, 2014-08-27 at 11:47 +0300, Tanu Kaskinen wrote: > >> On Tue, 2014-08-26 at 14:00 +0200, Lennart Poettering wrote: > >> > On Tue, 26.08.14 12:17, Tanu Kaskinen (tan

[systemd-devel] [RFC] runtime configurable timer

2014-09-11 Thread WaLyong Cho
(I will happy there is already similar method already exist.) systemd already has similar functionality "systemd-run" but that is only for scope or service unit. I think that is useful run a service without unit file on permanent storage. As a similar method, is it possible to generate or configu

[systemd-devel] udev database backwards compatibility guarantees

2014-09-11 Thread Alexander Larsson
Hi, I'm looking at creating a runtime/app thing for Gnome in the style of: http://0pointer.net/blog/revisiting-how-we-put-together-linux-systems.html However, I noticed that some core dependencies like mesa uses libudev. And in fact, needs user-set additional info not in sysfs. In particular, it r

Re: [systemd-devel] [PATCH] build-sys: make hibernation support configure option also handle hybrid-sleep; fix indentation

2014-09-11 Thread Ivan Shapovalov
On Tuesday 09 September 2014 at 01:40:51, Ivan Shapovalov wrote: > --- > The patch by Umut did miss at least hybrid-sleep -- it involves hibernation > as well (hybrid sleep is a hibernation followed by S3 rather than S4 > powerdown). > > Also, it messed up indentation a bit (Makefile.am s

Re: [systemd-devel] User systemd unit files

2014-09-11 Thread Colin Guthrie
Chris Morgan wrote on 11/09/14 02:32: > > On Sep 10, 2014 5:46 PM, "Zbigniew Jędrzejewski-Szmek" > mailto:zbys...@in.waw.pl>> wrote: >> >> On Tue, Sep 09, 2014 at 07:39:17PM -0400, Chris Morgan wrote: >> > >> >> Specifically, running `systemd --user` directly is not supported >> > >> >> anymore. T

Re: [systemd-devel] User systemd unit files

2014-09-11 Thread Chris Morgan
On Thu, Sep 11, 2014 at 5:03 AM, Colin Guthrie wrote: > Chris Morgan wrote on 11/09/14 02:32: >> >> On Sep 10, 2014 5:46 PM, "Zbigniew Jędrzejewski-Szmek" >> mailto:zbys...@in.waw.pl>> wrote: >>> >>> On Tue, Sep 09, 2014 at 07:39:17PM -0400, Chris Morgan wrote: >>> > >> >> Specifically, running `s

[systemd-devel] [PATCH RFC] udev: allow removing tags via TAG-="foobar"

2014-09-11 Thread David Herrmann
This extends the udev parser to support OP_REMOVE (-=) and adds support for TAG-= to remove previously set tags. We don't fail if the tag didn't exist. This is pretty handy if we ship default rules for seat-assignments and users want to exclude specific devices from that. They can easily add rules

Re: [systemd-devel] Preventing automatic seat assignments

2014-09-11 Thread David Herrmann
Hi On Thu, Sep 11, 2014 at 9:16 AM, Tanu Kaskinen wrote: > On Wed, 2014-09-10 at 12:44 +0200, David Herrmann wrote: >> Hi >> >> On Tue, Sep 9, 2014 at 10:49 AM, Tanu Kaskinen >> wrote: >> > On Wed, 2014-08-27 at 11:47 +0300, Tanu Kaskinen wrote: >> >> On Tue, 2014-08-26 at 14:00 +0200, Lennart P

Re: [systemd-devel] [PATCH RFC] udev: allow removing tags via TAG-="foobar"

2014-09-11 Thread Michael Biebl
2014-09-11 13:28 GMT+02:00 David Herrmann : > This patch is untested! Comments welcome. Should probably be documented in man udev(7) as well. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? ___

Re: [systemd-devel] [PATCH RFC] udev: allow removing tags via TAG-="foobar"

2014-09-11 Thread David Herrmann
Hi On Thu, Sep 11, 2014 at 2:15 PM, Michael Biebl wrote: > 2014-09-11 13:28 GMT+02:00 David Herrmann : >> This patch is untested! Comments welcome. > > Should probably be documented in man udev(7) as well. Indeed, now fixed. Thanks David ___ systemd-d

Re: [systemd-devel] [PATCH RFC] udev: allow removing tags via TAG-="foobar"

2014-09-11 Thread David Herrmann
Hi On Thu, Sep 11, 2014 at 1:28 PM, David Herrmann wrote: > This extends the udev parser to support OP_REMOVE (-=) and adds support > for TAG-= to remove previously set tags. We don't fail if the tag didn't > exist. > > This is pretty handy if we ship default rules for seat-assignments and > user

Re: [systemd-devel] [PATCH 1/5] [use after free] Avoid using m->kdbus after freeing it.

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 11:20 AM, wrote: > From: Philippe De Swert > > m->kdbus could be freed before it is released. Changing the > order fixes the issue. > > Found with Coverity. Fixes: CID#1237798 > > Signed-off-by: Philippe De Swert Few notes: - no punctuation characters in commit-head

Re: [systemd-devel] [PATCH 2/5] [use after free] pattern is already freed, so do not dereference it in the error print

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 11:20 AM, wrote: > From: Philippe De Swert > > In case set_consume goes wrong, the pattern name has already been > freed. So we do not try to print it in the logs, assuming the pattern > addition print will be printed just before the failure anyway. Found > with cover

Re: [systemd-devel] [PATCH 3/5] [uninitialized] No need to check if num is < 0

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 11:20 AM, wrote: > From: Philippe De Swert > > When num is < 0 we jump to the error handling. However at that time > r is not set yet by keyboard_fill so we most likely get a nonsensical > error. However the num check is not needed as the xkb_state_key_get_syms > will

Re: [systemd-devel] [PATCH 4/5] [memleak] Do not leak mmapped area when other memory allocations fail.

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 11:20 AM, wrote: > From: Philippe De Swert > > After a section of memory is succesfully allocated, some of the following > actions can still fail due to lack of memory. In this case -ENOMEM is > returned without actually freeing the already mapped memory. > Found with

Re: [systemd-devel] [PATCH 5/5] [memleak] Actually unref the buscreds on failure.

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 11:20 AM, wrote: > From: Philippe De Swert > > Actually unref the buscreds when we are not going to return a > pointer to them. As when bus_creds_add_more fails we immediately > return the error code otherwise and leak the new buscreds. > Found with coverity. Fixes: C

Re: [systemd-devel] [PATCH 1/3] [file handle leak] Close file handle when we're done with it

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 9:14 PM, wrote: > From: Philippe De Swert > > In test_read_one_char the filehandle does not get its fclose > at the end of the function, thus we are leaking fd's. > > Found with Coverity. Fixes: CID#1237749 > > Signed-off-by: Philippe De Swert > --- > src/test/test-

Re: [systemd-devel] [PATCH 3/3] [fd leak] Stop leaking fd in do_accept()

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 9:14 PM, wrote: > From: Philippe De Swert > > Found with Coverity. > > Signed-off-by: Philippe De Swert Looks good, applied! Thanks David > --- > src/activate/activate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/activate/activat

Re: [systemd-devel] [PATCH 2/3] [fd leak] Stop leaking an fd in sd_journal_sendv

2014-09-11 Thread David Herrmann
Hi On Wed, Sep 10, 2014 at 9:14 PM, wrote: > From: Philippe De Swert > > Found with Coverity. Fixes: CID#996435 > > Signed-off-by: Philippe De Swert > --- > src/journal/journal-send.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/journal/journal-send.c b/src/jou

Re: [systemd-devel] [RFC] runtime configurable timer

2014-09-11 Thread David Herrmann
Hi On Thu, Sep 11, 2014 at 10:45 AM, WaLyong Cho wrote: > (I will happy there is already similar method already exist.) > > systemd already has similar functionality "systemd-run" but that is only > for scope or service unit. I think that is useful run a service without > unit file on permanent s

Re: [systemd-devel] Suppressing automounting

2014-09-11 Thread Colin Guthrie
Dale R. Worley wrote on 10/09/14 20:56: >> From: Mantas Mikulėnas > >>> What I was thinking of is, what is the program that reads (directly or >>> indirectly) the Store.mount file and from that decides exactly how to >>> call mount(8), and when to call it? >> >> It's systemd itself (pid 1). >> >>

Re: [systemd-devel] Suppressing automounting

2014-09-11 Thread Dale R. Worley
> From: Colin Guthrie > I'm maybe missing something, but in the case of mount units, isn't that > framework program mount(8)? > > It has a mechanism for parsing default options that apply to all mounts > and then calling out to the appropriate, filesystem specific mount > program (e.g. mount.nfs

Re: [systemd-devel] Suppressing automounting

2014-09-11 Thread Tobias Geerinckx-Rice
Hallo, On 11 September 2014 19:41, Dale R. Worley wrote: > > From: Colin Guthrie > > I'm maybe missing something, but in the case of mount units, isn't that > > framework program mount(8)? > > > > It has a mechanism for parsing default options that apply to all mounts > > and then calling out to

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-09-11 Thread Tom Gundersen
On Mon, Aug 11, 2014 at 7:19 PM, Luis R. Rodriguez wrote: > On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering > wrote: >> On Mon, 11.08.14 18:39, Luis R. Rodriguez (mcg...@suse.com) wrote: >> >>> > This looks really wrong. We shouldn't permit worker processes to be >>> > blocked indefinitely w

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 1:07 PM, Tom Gundersen wrote: > On Mon, Aug 11, 2014 at 7:19 PM, Luis R. Rodriguez wrote: >> On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering >> wrote: >>> On Mon, 11.08.14 18:39, Luis R. Rodriguez (mcg...@suse.com) wrote: >>> > This looks really wrong. We should

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Tom Gundersen
On Wed, Sep 10, 2014 at 11:10 PM, Luis R. Rodriguez wrote: >>> More than two years >>> have gone by on growing design and assumptions on top of that original >>> commit. I'm not sure if *systemd folks* yet believe its was a design >>> regression? >> >> I don't think so. udev should not allow its w

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-09-11 Thread Tom Gundersen
On Thu, Sep 11, 2014 at 11:02 PM, Luis R. Rodriguez wrote: > On Thu, Sep 11, 2014 at 1:07 PM, Tom Gundersen wrote: >> On Mon, Aug 11, 2014 at 7:19 PM, Luis R. Rodriguez wrote: >>> On Mon, Aug 11, 2014 at 12:57 PM, Lennart Poettering >>> wrote: On Mon, 11.08.14 18:39, Luis R. Rodriguez (mcg

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 2:43 PM, Tom Gundersen wrote: > On Wed, Sep 10, 2014 at 11:10 PM, Luis R. Rodriguez > wrote: More than two years have gone by on growing design and assumptions on top of that original commit. I'm not sure if *systemd folks* yet believe its was a design

Re: [systemd-devel] [PATCH] udev: warn instead of killing kmod loading

2014-09-11 Thread Luis R. Rodriguez
On Thu, Sep 11, 2014 at 11:50:19PM +0200, Tom Gundersen wrote: > On Thu, Sep 11, 2014 at 11:02 PM, Luis R. Rodriguez wrote: > >> and added a warning > >> which is triggered after a third of the timeout. > > > > This is great! What commit merged this?I just looked at the latest > > commits and coul

Re: [systemd-devel] [RFC v2 3/6] kthread: warn on kill signal if not OOM

2014-09-11 Thread Tom Gundersen
On Fri, Sep 12, 2014 at 12:26 AM, Luis R. Rodriguez wrote: > On Thu, Sep 11, 2014 at 2:43 PM, Tom Gundersen wrote: >> How about simply introducing a new flag to finit_module() to indicate >> that the caller does not care about asynchronicity. We could then pass >> this from udev, but existing scr