Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-11-29 Thread Ronny Chevalier
2014-11-28 23:41 GMT+01:00 Zbigniew Jędrzejewski-Szmek : > On Fri, Nov 28, 2014 at 09:48:55PM +0100, Ronny Chevalier wrote: >> 2014-10-29 16:22 GMT+01:00 Ronny Chevalier : >> > It helps editing units by either creating a drop-in file, like >> > /etc/systemd/system/my.service.d/override.conf, or by

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-11-28 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Nov 28, 2014 at 09:48:55PM +0100, Ronny Chevalier wrote: > 2014-10-29 16:22 GMT+01:00 Ronny Chevalier : > > It helps editing units by either creating a drop-in file, like > > /etc/systemd/system/my.service.d/override.conf, or by copying the > > original unit from /usr/lib/systemd/ to /etc/s

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-11-28 Thread Zbigniew Jędrzejewski-Szmek
On Wed, Oct 29, 2014 at 04:22:02PM +0100, Ronny Chevalier wrote: > It helps editing units by either creating a drop-in file, like > /etc/systemd/system/my.service.d/override.conf, or by copying the > original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full > option is specified. > > It

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-11-28 Thread Ronny Chevalier
2014-10-29 16:22 GMT+01:00 Ronny Chevalier : > It helps editing units by either creating a drop-in file, like > /etc/systemd/system/my.service.d/override.conf, or by copying the > original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full > option is specified. > > It invokes an editor on

[systemd-devel] [PATCH] systemctl: add edit verb

2014-10-29 Thread Ronny Chevalier
It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/override.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. It invokes an editor on temporary files related to the unit files and if the edi

[systemd-devel] [PATCH] systemctl: add edit verb

2014-10-29 Thread Ronny Chevalier
It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/override.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. It invokes an editor on temporary files related to the unit files and if the edi

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-24 Thread David Timothy Strauss
On Fri, Oct 17, 2014 at 1:24 PM, Lennart Poettering wrote: > Does this make sense? Speaking as a nano user and someone who barely knows how to quit vim, I still think the decision of the default editor should be "vi" or the distribution's choice. ___ sy

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-24 Thread Ronny Chevalier
2014-10-13 13:40 GMT+02:00 David Herrmann : > Hi Hi, > > On Sat, Oct 11, 2014 at 8:17 PM, Daniel Buch wrote: >> Nice, I was in the process of implementing this. Looks good to me. But I >> think it would be better to use "vi" instead of "vim" if no &editor is set. >> Vim is not installed on every

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-20 Thread Lennart Poettering
On Mon, 13.10.14 15:13, Simon McVittie (simon.mcvit...@collabora.co.uk) wrote: > On 13/10/14 14:38, Dale R. Worley wrote: > > My general understanding is that the traditional behavior when "you > > need an editor but the user hasn't specified one" is to use "vi", and > > so people who don't want "

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-20 Thread Lennart Poettering
On Fri, 17.10.14 15:45, Mantas Mikulėnas (graw...@gmail.com) wrote: > On Fri, Oct 17, 2014 at 3:11 PM, Lennart Poettering > wrote: > > On Fri, 17.10.14 14:29, Mantas Mikulėnas (graw...@gmail.com) wrote: > > > >> > Technically proficient people will set $EDITOR or $VISUAL > >> > anyway. Non-techni

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-17 Thread Dale R. Worley
> From: Mantas Mikulėnas > Normally $VISUAL would be first, followed by $EDITOR... > > (But in practice nobody sets them to different values anyway, since no > programs aside from mailx care about the distinction. So it's fine > either way, and just ignoring $VISUAL would be just as good.) I ra

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-17 Thread Mantas Mikulėnas
On Fri, Oct 17, 2014 at 3:11 PM, Lennart Poettering wrote: > On Fri, 17.10.14 14:29, Mantas Mikulėnas (graw...@gmail.com) wrote: > >> > Technically proficient people will set $EDITOR or $VISUAL >> > anyway. Non-technical people won't. Non-technical people are likel to >> > be totally lost in vi/vi

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-17 Thread Lennart Poettering
On Fri, 17.10.14 13:30, David Timothy Strauss (da...@davidstrauss.net) wrote: > On Fri, Oct 17, 2014 at 1:24 PM, Lennart Poettering > wrote: > > Does this make sense? > > Speaking as a nano user and someone who barely knows how to quit vim, > I still think the decision of the default editor shou

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-17 Thread Lennart Poettering
On Fri, 17.10.14 14:29, Mantas Mikulėnas (graw...@gmail.com) wrote: > > Technically proficient people will set $EDITOR or $VISUAL > > anyway. Non-technical people won't. Non-technical people are likel to > > be totally lost in vi/vim. For those folks probably nano makes a > > better choice, simply

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-17 Thread Mantas Mikulėnas
On Fri, Oct 17, 2014 at 2:24 PM, Lennart Poettering wrote: > On Mon, 13.10.14 13:40, David Herrmann (dh.herrm...@gmail.com) wrote: > >> Hi >> >> On Sat, Oct 11, 2014 at 8:17 PM, Daniel Buch >> wrote: >> > Nice, I was in the process of implementing this. Looks good to me. But I >> > think it woul

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-17 Thread Lennart Poettering
On Mon, 13.10.14 13:40, David Herrmann (dh.herrm...@gmail.com) wrote: > Hi > > On Sat, Oct 11, 2014 at 8:17 PM, Daniel Buch wrote: > > Nice, I was in the process of implementing this. Looks good to me. But I > > think it would be better to use "vi" instead of "vim" if no &editor is set. > > Vim

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-14 Thread Daniel Buch
My general understanding is equal to dale. But with some consideration it led me to agree with the warning approach. Its no big deal setting EDITOR. Den 14/10/2014 01.06 skrev "Ronny Chevalier" : > 2014-10-13 16:13 GMT+02:00 Simon McVittie >: > > On 13/10/14 14:38, Dale R. Worley wrote: > >> My g

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-13 Thread Ronny Chevalier
2014-10-13 16:13 GMT+02:00 Simon McVittie : > On 13/10/14 14:38, Dale R. Worley wrote: >> My general understanding is that the traditional behavior when "you >> need an editor but the user hasn't specified one" is to use "vi", and >> so people who don't want "vi" *always* set $VISUAL in their >> en

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-13 Thread Simon McVittie
On 13/10/14 14:38, Dale R. Worley wrote: > My general understanding is that the traditional behavior when "you > need an editor but the user hasn't specified one" is to use "vi", and > so people who don't want "vi" *always* set $VISUAL in their > environment. The Right Thing™ is distro-specific. D

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-13 Thread Dale R. Worley
> From: David Herrmann > > On Sat, Oct 11, 2014 at 8:17 PM, Daniel Buch wrote: > > Nice, I was in the process of implementing this. Looks good to me. But I > > think it would be better to use "vi" instead of "vim" if no &editor is set. > > Vim is not installed on every system as default but vi i

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-13 Thread David Herrmann
Hi On Sat, Oct 11, 2014 at 8:17 PM, Daniel Buch wrote: > Nice, I was in the process of implementing this. Looks good to me. But I > think it would be better to use "vi" instead of "vim" if no &editor is set. > Vim is not installed on every system as default but vi is most likely. I'd prefer doin

Re: [systemd-devel] [PATCH] systemctl: add edit verb

2014-10-11 Thread Daniel Buch
Nice, I was in the process of implementing this. Looks good to me. But I think it would be better to use "vi" instead of "vim" if no &editor is set. Vim is not installed on every system as default but vi is most likely. Den 11/10/2014 18.37 skrev "Ronny Chevalier" : > It helps editing units by eit

[systemd-devel] [PATCH] systemctl: add edit verb

2014-10-11 Thread Ronny Chevalier
It helps editing units by either creating a drop-in file, like /etc/systemd/system/my.service.d/amendments.conf, or by copying the original unit from /usr/lib/systemd/ to /etc/systemd/ if the --full option is specified. Then it invokes the $SYSTEMD_EDITOR or $EDITOR or vim to the related files and