Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-14 Thread Michael Olbrich
On Thu, Apr 02, 2015 at 12:54:00PM +0200, Lennart Poettering wrote: > On Sun, 22.03.15 13:36, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > Love this work! Thanks. [...] > > + > > +if (a->expire_event_source) { > > +r = sd_event_source_set_time(a->expire_event_sou

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-14 Thread Karel Zak
On Sun, Apr 12, 2015 at 10:33:54PM +0200, Jan Luca Naumann wrote: > I'm not a systemd-developer so I want to ask you if it is possible to > add a hook for execute something after the unmount (for example to > delete the mount directory)? well, /proc/mount and /proc/self/mountinfo are poll-able, s

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-12 Thread Lennart Poettering
On Sun, 12.04.15 22:33, Jan Luca Naumann (j.naum...@fu-berlin.de) wrote: > Hey Michael, > > it is very nice that you add this missing but useful feature :-) > > I'm not a systemd-developer so I want to ask you if it is possible to > add a hook for execute something after the unmount (for example

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-12 Thread Jan Luca Naumann
Hey Michael, it is very nice that you add this missing but useful feature :-) I'm not a systemd-developer so I want to ask you if it is possible to add a hook for execute something after the unmount (for example to delete the mount directory)? Thank you very much and best regards, Jan signatu

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-02 Thread Lennart Poettering
On Thu, 02.04.15 13:55, Mantas Mikulėnas (graw...@gmail.com) wrote: > Isn't log_warning_errno(errno, "%m") identical to just log_warning("%m")? it's not. the former generates an ERRNO= structured journal field, the latter doesn't. Also see my reply to Tom's review about this. Lennart -- Lennar

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-02 Thread Lennart Poettering
On Fri, 27.03.15 12:36, Tom Gundersen (t...@jklm.no) wrote: > > +if (errno != EAGAIN) > > +log_error_errno(errno, "failed to expire automount: %m"); > > No need for this, it is equivalent to > log_error("failed to exprie automount: %m"); Not true rea

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-02 Thread Mantas Mikulėnas
On Thu, Apr 2, 2015 at 1:54 PM, Lennart Poettering wrote: > On Sun, 22.03.15 13:36, Michael Olbrich (m.olbr...@pengutronix.de) wrote: > > Love this work! > > > init_autofs_dev_ioctl(¶m); > > param.ioctlfd = ioctl_fd; > > -param.timeout.timeout = sec; > > + > > +/

Re: [systemd-devel] [PATCH] automount: add expire support

2015-04-02 Thread Lennart Poettering
On Sun, 22.03.15 13:36, Michael Olbrich (m.olbr...@pengutronix.de) wrote: Love this work! > init_autofs_dev_ioctl(¶m); > param.ioctlfd = ioctl_fd; > -param.timeout.timeout = sec; > + > +/* Convert to seconds, rounding up. */ > +param.timeout.timeout = use

Re: [systemd-devel] [PATCH] automount: add expire support

2015-03-27 Thread Tom Gundersen
Looks nice. Minor nitpicks below. On Sun, Mar 22, 2015 at 1:36 PM, Michael Olbrich wrote: > --- > man/systemd.automount.xml | 8 ++ > man/systemd.mount.xml | 9 ++ > src/core/automount.c | 209 > -- > src/core/auto

Re: [systemd-devel] [PATCH] automount: add expire support

2015-03-24 Thread Kay Sievers
On Sun, Mar 22, 2015 at 1:36 PM, Michael Olbrich wrote: > --- > man/systemd.automount.xml | 8 ++ > man/systemd.mount.xml | 9 ++ > src/core/automount.c | 209 > -- > src/core/automount.h | 6 +- >

[systemd-devel] [PATCH] automount: add expire support

2015-03-22 Thread Michael Olbrich
--- man/systemd.automount.xml | 8 ++ man/systemd.mount.xml | 9 ++ src/core/automount.c | 209 -- src/core/automount.h | 6 +- src/core/dbus-automount.c | 1 + src/core/load-fragment-