Re: [systemd-devel] [EXT] [PATCH] libblkid: fix spurious ext superblock checksum mismatches

2024-11-22 Thread Krister Johansen
On Thu, Nov 21, 2024 at 11:44:14AM +0100, Karel Zak wrote: > On Tue, Nov 19, 2024 at 09:49:57AM GMT, Theodore Ts'o wrote: > > The O_DIRECT read isn't a magic bullet. > > Hmm... the nice thing about this patch is that it only uses O_DIRECT > when necessary (if the ordinary method fails). This mean

Re: [systemd-devel] [EXT] [PATCH] libblkid: fix spurious ext superblock checksum mismatches

2024-11-19 Thread Krister Johansen
On Tue, Nov 19, 2024 at 09:49:57AM -0800, Theodore Ts'o wrote: > Yes, this can happen if the file system is mounted. The reason for > this is that the kernel updates metadata blocks via the block buffer > cache, with the jbd2 (journaled block layer v2) subsystem managing the > atomic updates. T

Re: [systemd-devel] [PATCH] libblkid: fix spurious ext superblock checksum mismatches

2024-11-18 Thread Krister Johansen
On Mon, Nov 18, 2024 at 11:36:48PM +0100, Lennart Poettering wrote: > On Mo, 18.11.24 12:35, Krister Johansen (k...@templeofstupid.com) wrote: > > > Reads of ext superblocks can race with updates. If libblkid observes a > > checksum mismatch, re-read the superblock with O_DIRE

[systemd-devel] [PATCH] libblkid: fix spurious ext superblock checksum mismatches

2024-11-18 Thread Krister Johansen
detected. [1] https://lore.kernel.org/linux-ext4/20230609042239.ga1436...@mit.edu/ Signed-off-by: Krister Johansen --- libblkid/src/blkidP.h | 5 + libblkid/src/probe.c | 27 +++ libblkid/src/superblocks/ext.c | 22 -- 3 files