[systemd-devel] [PATCH] sd_daemon: use secure_getenv() instead of getenv()

2015-01-23 Thread Sangjung Woo
According to the glibc manual, secure_getenv() is more trustful than getenv() since it returns a null pointer if the environment is untrusted such as setting SUID or SGID bits. Moreover, libraries should use secure_getenv(). (http://www.gnu.org/software/libc/manual/html_node/Environment-Access.html

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 15:51, Cristian Rodríguez ([email protected]) wrote: > El 23/01/15 a las 14:52, Lennart Poettering escribió: > >On Fri, 23.01.15 12:27, Cristian Rodríguez ([email protected]) wrote: > > > >>El 23/01/15 a las 10:31, Lennart Poettering escribió: > >> > >>>The rc-local

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 18:44, Simon McVittie ([email protected]) wrote: > On 23/01/15 17:52, Lennart Poettering wrote: > > On Fri, 23.01.15 12:27, Cristian Rodríguez ([email protected]) wrote: > >> El 23/01/15 a las 10:31, Lennart Poettering escribió: > >>> The rc-local generator onl

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Michael Biebl
2015-01-23 18:51 GMT+01:00 Lennart Poettering : > I'd even remove rc-local.service from Debian. If this is a normal > sysvinit script, treat it as such, and let sysv-generator do its deed > on it. The /etc/init.d/rc.local init script does nothing else then run /etc/rc.local, in case this file is e

Re: [systemd-devel] Docker vs PrivateTmp

2015-01-23 Thread Daniel J Walsh
Yes I was trying to get a comment from Alex, since he did the original patch. On 01/23/2015 12:26 PM, Lennart Poettering wrote: > On Fri, 23.01.15 11:31, Daniel J Walsh ([email protected]) wrote: > > You just sent a full quote without any comment of yours? > >> On 01/22/2015 10:02 PM, Lennart Poet

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Cristian Rodríguez
El 23/01/15 a las 14:52, Lennart Poettering escribió: On Fri, 23.01.15 12:27, Cristian Rodríguez ([email protected]) wrote: El 23/01/15 a las 10:31, Lennart Poettering escribió: The rc-local generator only exists to add compat support for those systems where it never was a sysvinit scr

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Simon McVittie
On 23/01/15 17:52, Lennart Poettering wrote: > On Fri, 23.01.15 12:27, Cristian Rodríguez ([email protected]) wrote: >> El 23/01/15 a las 10:31, Lennart Poettering escribió: >>> The rc-local generator only exists to add compat support for those >>> systems where it never was a sysvinit scrip

Re: [systemd-devel] logind vs CAP_SYS_ADMIN-lessness

2015-01-23 Thread Christian Seiler
Am 23.01.2015 um 18:57 schrieb Lennart Poettering: >> Am 2015-01-23 08:29, schrieb Mantas Mikulėnas: >>> IIRC, the reason for tmpfs on /run/user/* was lack of tmpfs quotas... >>> if thats still a problem, maybe there could be one tmpfs at /run/user, >>> still preventing users from touching root-onl

Re: [systemd-devel] [PATCH] build-sys: lookup for sulogin, it might not be in /sbin

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 14:35, Cristian Rodríguez ([email protected]) wrote: Thanks! Applied! > --- > Makefile.am | 1 + > configure.ac | 2 ++ > units/console-shell.service.m4.in | 2 +- > units/emergency.service.in| 2 +- > units/rescue.servic

Re: [systemd-devel] [PATCH] mount-setup: Do not bother with /proc/bus/usb

2015-01-23 Thread Lennart Poettering
1;3802;0cOn Fri, 23.01.15 13:25, Cristian Rodríguez ([email protected]) wrote: > Current systemd requires kernel >= 3.7 per the README file > but CONFIG_USB_DEVICEFS disappeared from the kernel in > upstream commit fb28d58b72aa9215b26f1d5478462af394a4d253 > (kernel 3.5-rc1) THanks. Applie

[systemd-devel] [PATCH] po: update Russian translation

2015-01-23 Thread Sergey Ptashnick
Add strings for importd. >From 64baca737227adef94b9b02000ce018777b1c989 Mon Sep 17 00:00:00 2001 From: Sergey Ptashnick <[email protected]> Date: Fri, 23 Jan 2015 20:56:36 +0300 Subject: [PATCH] po: update Russian translation Add strings for importd. --- po/ru.po | 10 +- 1 files chang

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Topi Miettinen
On 01/23/15 17:43, Lennart Poettering wrote: > On Fri, 23.01.15 17:29, Topi Miettinen ([email protected]) wrote: > >> On 01/23/15 03:06, Lennart Poettering wrote: >>> On Sun, 18.01.15 23:57, Topi Miettinen ([email protected]) wrote: >>> Don't use recvmsg(2) return value to check for too lon

Re: [systemd-devel] logind vs CAP_SYS_ADMIN-lessness

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 15:45, Christian Seiler ([email protected]) wrote: > Am 2015-01-23 08:29, schrieb Mantas Mikulėnas: > >IIRC, the reason for tmpfs on /run/user/* was lack of tmpfs quotas... > >if thats still a problem, maybe there could be one tmpfs at /run/user, > >still preventing users from to

Re: [systemd-devel] [PATCH] Added UFD (Uplink failure detection) support to networkd

2015-01-23 Thread Holger Winkelmann [TP]
HI, While reading this I'm just thinking about RFC5880 ff. BFD support. Anybody in the networks universe already thinking about this? Holger - On 23 Jan, 2015, at 18:20, Alin Rauta [email protected] wrote: > Hi, > > Uplink Failure Detection (UFD) is a key enhancement to networkd, that

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 12:27, Cristian Rodríguez ([email protected]) wrote: > El 23/01/15 a las 10:31, Lennart Poettering escribió: > > >The rc-local generator only exists to add compat support for those > >systems where it never was a sysvinit script anyway... > > > > They are not init scripts

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 15:57, Michael Biebl ([email protected]) wrote: > 2015-01-23 14:32 GMT+01:00 Lennart Poettering : > > On Fri, 23.01.15 04:24, Michael Biebl ([email protected]) wrote: > > > >> If distros still ship such a rc.local sysv init script, shouldn't they > >> rather symlink that to > >> the

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 17:29, Topi Miettinen ([email protected]) wrote: > On 01/23/15 03:06, Lennart Poettering wrote: > > On Sun, 18.01.15 23:57, Topi Miettinen ([email protected]) wrote: > > > >> Don't use recvmsg(2) return value to check for too long packets > >> (it doesn't work) but MSG_TRUNC fl

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 05:29:46PM +, Topi Miettinen wrote: > On 01/23/15 03:06, Lennart Poettering wrote: > > On Sun, 18.01.15 23:57, Topi Miettinen ([email protected]) wrote: > > > >> Don't use recvmsg(2) return value to check for too long packets > >> (it doesn't work) but MSG_TRUNC flag.

[systemd-devel] [PATCH] build-sys: lookup for sulogin, it might not be in /sbin

2015-01-23 Thread Cristian Rodríguez
--- Makefile.am | 1 + configure.ac | 2 ++ units/console-shell.service.m4.in | 2 +- units/emergency.service.in| 2 +- units/rescue.service.in | 2 +- 5 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile

[systemd-devel] [PATCH] Added UFD (Uplink failure detection) support to networkd

2015-01-23 Thread Alin Rauta
Hi, Uplink Failure Detection (UFD) is a key enhancement to networkd, that will provide support for the switch use case. The links can be configured as uplinks or as downlinks inside an UFD group. When all uplinks for a group are down, the failure is propagated to the downlinks, so the devices co

[systemd-devel] [PATCH] Added Uplink failure detection feature to networkd

2015-01-23 Thread Alin Rauta
--- Makefile.am |4 + man/systemd.netdev.xml | 72 +- src/libsystemd/sd-network/sd-network.c | 117 +++ src/network/networkctl.c| 153 src/network/networkd-link.c | 35 + src/network/networkd-manager.c

Re: [systemd-devel] [PATCH] libudev: fix check for too long packet

2015-01-23 Thread Topi Miettinen
On 01/23/15 03:06, Lennart Poettering wrote: > On Sun, 18.01.15 23:57, Topi Miettinen ([email protected]) wrote: > >> Don't use recvmsg(2) return value to check for too long packets >> (it doesn't work) but MSG_TRUNC flag. > > Why precisely doesn't this work? I mean, it will consider messages >

Re: [systemd-devel] Docker vs PrivateTmp

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 11:31, Daniel J Walsh ([email protected]) wrote: You just sent a full quote without any comment of yours? > > On 01/22/2015 10:02 PM, Lennart Poettering wrote: > > On Sat, 17.01.15 23:02, Lars Kellogg-Stedman ([email protected]) wrote: > > > >> See the `devicemapper` mountpoint cr

Re: [systemd-devel] [logind] retroactive lid close handle upon vt switch

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 15:43, b3nmore ([email protected]) wrote: > > Why precisely does your original session inhibit the lid switch? If > > you want to turn off the lid switch then turn it off properly, > > inhibition is not really about turning something fully off. It's about > > temporarily maki

Re: [systemd-devel] Docker vs PrivateTmp

2015-01-23 Thread Daniel J Walsh
On 01/22/2015 10:02 PM, Lennart Poettering wrote: > On Sat, 17.01.15 23:02, Lars Kellogg-Stedman ([email protected]) wrote: > >> See the `devicemapper` mountpoint created by Docker for the container: >> >> # grep devicemapper/mnt /proc/mounts >> >> /dev/mapper/docker-253:6-98310-e68df3f45d6

[systemd-devel] [PATCH] mount-setup: Do not bother with /proc/bus/usb

2015-01-23 Thread Cristian Rodríguez
Current systemd requires kernel >= 3.7 per the README file but CONFIG_USB_DEVICEFS disappeared from the kernel in upstream commit fb28d58b72aa9215b26f1d5478462af394a4d253 (kernel 3.5-rc1) --- src/core/mount-setup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/mount-setup.c b/src/c

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Cristian Rodríguez
El 23/01/15 a las 10:31, Lennart Poettering escribió: The rc-local generator only exists to add compat support for those systems where it never was a sysvinit script anyway... They are not init scripts though. but plain shell scripts with no dependency information. they are installed in /etc

Re: [systemd-devel] bug 88401 / daemon-reload causes Type=oneshot services to be re-started / path_coldplug() is non-deserialization-aware

2015-01-23 Thread Ivan Shapovalov
On 2015-01-18 at 04:21 +0300, Ivan Shapovalov wrote: > Hi folks, > > I'm trying to fix this bug: > https://bugs.freedesktop.org/show_bug.cgi?id=88401 > > The initial problem (as reported) looks following: performing a reload > (maybe implicitly) re-starts alsa-restore.service if it is enabled. >

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Michael Biebl
2015-01-23 15:15 GMT+01:00 Martin Pitt : > Michael Biebl [2015-01-23 13:27 +0100]: >> - It avoids that a rc.local.service file is generated by the sysv-generator > > Not with upstream systemd, the sysv generator doesn't check if there's > already a unit of that name (as it produces them in generato

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Michael Biebl
2015-01-23 14:32 GMT+01:00 Lennart Poettering : > On Fri, 23.01.15 04:24, Michael Biebl ([email protected]) wrote: > >> If distros still ship such a rc.local sysv init script, shouldn't they >> rather symlink that to >> the native rc-local.service? Sounds like the better alternative to me. >> Or alt

Re: [systemd-devel] logind vs CAP_SYS_ADMIN-lessness

2015-01-23 Thread Christian Seiler
Am 2015-01-23 08:29, schrieb Mantas Mikulėnas: IIRC, the reason for tmpfs on /run/user/* was lack of tmpfs quotas... if thats still a problem, maybe there could be one tmpfs at /run/user, still preventing users from touching root-only /run? Yes, that's a good idea. Initially when posting this

Re: [systemd-devel] [logind] retroactive lid close handle upon vt switch

2015-01-23 Thread b3nmore
On 01/23/2015 02:56 PM, Lennart Poettering wrote: > Yeah, this is intentional, button inhibtiros are bound to the active > session, as they are about processing input keys, and only the fg > session should be able to do that. One could argue here, that the lid close event has been already processe

Re: [systemd-devel] [PATCH] systemctl: bugfix for systemctl reboot command with argument

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 08:21:57PM +0900, Sangjung Woo wrote: > According to systemctl man page, 'systemctl reboot [arg]' should work > without any errors. However, it does not work because of 'Invalid number > of arguments' error, except for 'reboot [arg]'. This patch fixes the bug > so that both

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Matthias Urlichs
Hi, Dimitri John Ledkov: > >> foo.service.d/bar.conf sets an option like Service/ExecStartPre that > >> can be specified multiple times. > > Doesn't the manpage state that an empty entry clears the list? > > A snippet: > [Unit] > Wants= > > Does not remove want dependencies declared in the unit

Re: [systemd-devel] [PATCH] udevadm-settle: exit if event execution is disable, even if queue is not empty.

2015-01-23 Thread Robert Milasan
On Fri, 23 Jan 2015 14:31:28 +0100 "Kay Sievers" wrote: > > How does udev_ctrl_get_stop_exec_queue() operate on a ctrl object and > not a msg? > > How would udevadm process incoming control packets, or know that way > about the state of the running daemon? > > If the event execution is disabled

[systemd-devel] [PATCH 2/2] logind: chown+chmod /run/user/$UID if mount(tmpfs) fails with EPERM

2015-01-23 Thread Christian Seiler
In containers without CAP_SYS_ADMIN, it is not possible to mount tmpfs (or any filesystem for that matter) on top of /run/user/$UID. Previously, logind just failed in such a situation. Now, logind will resort to chown+chmod of the directory instead. This allows logind still to work in those enviro

[systemd-devel] [PATCH 1/2] logind: remove per-user runtime dir again if setup fails

2015-01-23 Thread Christian Seiler
If setup of per-user runtime dir fails, clean up afterwards by removing the directory before returning from the function, so we don't leave the directory behind. If this is not done, the second time the user logs in logind would assume that the directory is already set up, even though it isn't. --

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 03:12:11PM +0100, Lennart Poettering wrote: > On Fri, 23.01.15 14:57, Christian Seiler ([email protected]) wrote: > > > Am 2015-01-23 14:27, schrieb Lennart Poettering: > > >>Yes, it does, although only in the general systemd.unit(5), not in the > > >>specific options, so

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Martin Pitt
Michael Biebl [2015-01-23 13:27 +0100]: > - It avoids that a rc.local.service file is generated by the sysv-generator Not with upstream systemd, the sysv generator doesn't check if there's already a unit of that name (as it produces them in generator.late/). The Debian package has a patch for this

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Dimitri John Ledkov
On 23 January 2015 at 11:21, Matthias Urlichs wrote: > Hi, > > Igor Bukanov: >> It is not clear from the systemd.unit manual page what happens when >> foo.service.d/bar.conf sets an option like Service/ExecStartPre that >> can be specified multiple times. From experimenting I see that *.conf >> fi

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 14:57, Christian Seiler ([email protected]) wrote: > Am 2015-01-23 14:27, schrieb Lennart Poettering: > >>Yes, it does, although only in the general systemd.unit(5), not in the > >>specific options, so maybe it's not that easy to find. > > > >Actually, it kinda says it in the spe

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Christian Seiler
Am 2015-01-23 14:27, schrieb Lennart Poettering: Yes, it does, although only in the general systemd.unit(5), not in the specific options, so maybe it's not that easy to find. Actually, it kinda says it in the specific options. From the explanation of ExecStart=: "...If the empty string is ass

Re: [systemd-devel] [logind] retroactive lid close handle upon vt switch

2015-01-23 Thread Lennart Poettering
On Wed, 21.01.15 12:33, b3nmore ([email protected]) wrote: > Hello, > > consider two vt sessions vt1, vt2. On vt1 handle-lid-switch is > inhibited. Now the lid is closed and than a vt switch takes place (e.g. > "sleep 10 && loginctl activate vt2"). Now the system suspends. I guess > this is

Re: [systemd-devel] persisting sriov_numvfs

2015-01-23 Thread Martin Polednik
- Original Message - > From: "Lennart Poettering" > To: "Dan Kenigsberg" > Cc: [email protected], [email protected], > [email protected] > Sent: Friday, January 23, 2015 3:49:59 AM > Subject: Re: [systemd-devel] persisting sriov_numvfs > > On Mon, 19.01.15 14:18,

Re: [systemd-devel] Unwants

2015-01-23 Thread Dimitri John Ledkov
On 23 January 2015 at 13:11, Dimitri John Ledkov wrote: > On 22 January 2015 at 16:32, Andrei Borzenkov wrote: >> В Thu, 22 Jan 2015 15:46:26 +0100 >> Michael Biebl пишет: >> >> There was long discussion on this just recently. >> >> http://lists.freedesktop.org/archives/systemd-devel/2014-Novemb

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 04:24, Michael Biebl ([email protected]) wrote: > 2015-01-23 3:52 GMT+01:00 Cristian Rodríguez : > > --- > > src/sysv-generator/sysv-generator.c | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git a/src/sysv-generator/sysv-generator.c > > b/src/sysv-generator/sys

Re: [systemd-devel] [PATCH] udevadm-settle: exit if event execution is disable, even if queue is not empty.

2015-01-23 Thread Kay Sievers
On Fri, Jan 23, 2015 at 2:13 PM, Robert Milasan wrote: > How to reproduce: > > run: udevadm control --stop-exec-queue > add: new device, for example a usb stick/disk > (it will create /run/udev/queue) > run: udevadm settle --timeout=10 > > The last command will hang/stall, because it checks c

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Lennart Poettering
On Thu, 22.01.15 23:52, Cristian Rodríguez ([email protected]) wrote: > --- > src/sysv-generator/sysv-generator.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/src/sysv-generator/sysv-generator.c > b/src/sysv-generator/sysv-generator.c > index b8b77aa..d6e4dfa 100644 >

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 14:15, Christian Seiler ([email protected]) wrote: > Am 2015-01-23 12:21, schrieb Matthias Urlichs: > >Igor Bukanov: > >>It is not clear from the systemd.unit manual page what happens when > >>foo.service.d/bar.conf sets an option like Service/ExecStartPre that > >>can be specifi

Re: [systemd-devel] systemd-sysv-generator *.service: File exists

2015-01-23 Thread Zbigniew Jędrzejewski-Szmek
On Fri, Jan 23, 2015 at 11:53:03AM +0100, Martin Pitt wrote: > poma [2015-01-23 11:38 +0100]: > > I should have checked before, nx*3.5 files that was causing this noise is > > the backup leftover from nx4 testing. > > Removing these two files, there is no need to upgrade. > > This almost certainl

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Christian Seiler
Am 2015-01-23 12:21, schrieb Matthias Urlichs: Igor Bukanov: It is not clear from the systemd.unit manual page what happens when foo.service.d/bar.conf sets an option like Service/ExecStartPre that can be specified multiple times. From experimenting I see that *.conf files supply additional va

[systemd-devel] [PATCH] udevadm-settle: exit if event execution is disable, even if queue is not empty.

2015-01-23 Thread Robert Milasan
How to reproduce: run: udevadm control --stop-exec-queue add: new device, for example a usb stick/disk (it will create /run/udev/queue) run: udevadm settle --timeout=10 The last command will hang/stall, because it checks constantly for /run/udev/queue, which exists and always will unless th

Re: [systemd-devel] logind vs CAP_SYS_ADMIN-lessness

2015-01-23 Thread Lennart Poettering
On Fri, 23.01.15 09:29, Mantas Mikulėnas ([email protected]) wrote: > On Fri, Jan 23, 2015 at 4:04 AM, Lennart Poettering > wrote: > > > On Thu, 22.01.15 15:53, Christian Seiler ([email protected]) wrote: > > > > > Nevertheless, I think it would be great if this could also be fixed, > > > becau

Re: [systemd-devel] Unwants

2015-01-23 Thread Dimitri John Ledkov
On 22 January 2015 at 16:32, Andrei Borzenkov wrote: > В Thu, 22 Jan 2015 15:46:26 +0100 > Michael Biebl пишет: > >> 2015-01-22 15:08 GMT+01:00 Dimitri John Ledkov : >> > At the moment, I'm looking at packaging symlinks in .wants directories >> > under /usr and then allow to uninstall such a pack

Re: [systemd-devel] Swap gets activated twice (through fstab and gpt generators)

2015-01-23 Thread Peter Mattern
I saw this on an Arch Linux (systemd 218) i686 QEMU VM using BIOS and GPT, too. Couldn't see it on another x86_64 VM using UEFI (TianoCore / OVMF) and GPT but configured exactly the same apart from this. Lenovo's Yoga 2 Pro used by the said bug report's OP is featuring a BIOS, too. So perha

Re: [systemd-devel] [PATCH] Fix systemd crash (on assert) during shutdown/reboot in unprivileged container

2015-01-23 Thread Lennart Poettering
On Fri, 16.01.15 19:32, Andrei Borzenkov ([email protected]) wrote: > В Thu, 15 Jan 2015 19:24:25 -0500 > Stéphane Graber пишет: > > > @@ -871,6 +871,14 @@ static void mount_enter_unmounting(Mount *m) { > > m->control_command_id = MOUNT_EXEC_UNMOUNT; > > m->control_command =

Re: [systemd-devel] [PATCH] Fix systemd crash (on assert) during shutdown/reboot in unprivileged container

2015-01-23 Thread Lennart Poettering
On Thu, 15.01.15 19:24, Stéphane Graber ([email protected]) wrote: > On Thu, Jan 15, 2015 at 07:20:55PM +0100, Lennart Poettering wrote: > diff --git a/src/core/mount.c b/src/core/mount.c > index 612d150..4de878e 100644 > --- a/src/core/mount.c > +++ b/src/core/mount.c > @@ -871,6 +871,14 @@ sta

Re: [systemd-devel] logind vs CAP_SYS_ADMIN-lessness

2015-01-23 Thread Michael Biebl
2015-01-23 8:29 GMT+01:00 Mantas Mikulėnas : > IIRC, the reason for tmpfs on /run/user/* was lack of tmpfs quotas... if > that's still a problem, maybe there could be one tmpfs at /run/user, still > preventing users from touching root-only /run? FWIW, as long as logind didn't setup per-user tmpfs,

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Michael Biebl
2015-01-23 10:17 GMT+01:00 Colin Guthrie : > Michael Biebl wrote on 23/01/15 03:24: >> and ship a >> /lib/systemd/system/rc.local.service -> rc-local.service >> symlink in the systemd package. > > Hmm, doesn't that break the > /usr/lib/systemd/system-generators/systemd-rc-local-generator logic? Or

[systemd-devel] [PATCH] systemctl: bugfix for systemctl reboot command with argument

2015-01-23 Thread Sangjung Woo
According to systemctl man page, 'systemctl reboot [arg]' should work without any errors. However, it does not work because of 'Invalid number of arguments' error, except for 'reboot [arg]'. This patch fixes the bug so that both of commands work in exactly the same way. Signed-off-by: Sangjung Woo

Re: [systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Matthias Urlichs
Hi, Igor Bukanov: > It is not clear from the systemd.unit manual page what happens when > foo.service.d/bar.conf sets an option like Service/ExecStartPre that > can be specified multiple times. From experimenting I see that *.conf > files supply additional values to the option and to overwrite or

Re: [systemd-devel] logind vs CAP_SYS_ADMIN-lessness

2015-01-23 Thread David Herrmann
Hi On Thu, Jan 22, 2015 at 3:53 PM, Christian Seiler wrote: > [1] Note that the only other issue I stumbled upon has now been fixed, > so in general I would say that systemd already works really well > in containers without CAP_SYS_ADMIN if you know how to set them > up properly. Jus

Re: [systemd-devel] systemd-sysv-generator *.service: File exists

2015-01-23 Thread Martin Pitt
poma [2015-01-23 11:38 +0100]: > I should have checked before, nx*3.5 files that was causing this noise is the > backup leftover from nx4 testing. > Removing these two files, there is no need to upgrade. This almost certainly needs this fix: http://cgit.freedesktop.org/systemd/systemd/commit/?

Re: [systemd-devel] systemd-sysv-generator *.service: File exists

2015-01-23 Thread poma
On 22.01.2015 23:21, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Jan 22, 2015 at 10:05:48PM +0100, poma wrote: >> >> Buena noches, >> >> Maybe someone knows how to get rid of these messages? > Does systemd-216-17.fc21.x86_64 help? > > Zbyszek > I should have checked before, nx*3.5 files that w

[systemd-devel] service.d/.conf files and multi-valued options

2015-01-23 Thread Igor Bukanov
It is not clear from the systemd.unit manual page what happens when foo.service.d/bar.conf sets an option like Service/ExecStartPre that can be specified multiple times. From experimenting I see that *.conf files supply additional values to the option and to overwrite or remove already given values

[systemd-devel] Swap gets activated twice (through fstab and gpt generators)

2015-01-23 Thread Martin Pitt
Hello all, we just received a report (https://launchpad.net/bugs/1399595) that swap gets activated twice: | systemd[1]: Activating swap Swap Partition... | systemd[1]: Activating swap /dev/disk/by-uuid/73d341f1-eedc-43fc-9e53-ba4194dae3fb... | swapon[396]: swapon: /dev/disk/by-uuid/73d341f1-eedc

Re: [systemd-devel] [PATCH] sysv-generator: Do not generate units for files handled by rc-local generator

2015-01-23 Thread Colin Guthrie
Michael Biebl wrote on 23/01/15 03:24: > and ship a > /lib/systemd/system/rc.local.service -> rc-local.service > symlink in the systemd package. Hmm, doesn't that break the /usr/lib/systemd/system-generators/systemd-rc-local-generator logic? Or do you not ship that in Debian? The whole point of t