On Thu, Jun 19, 2014 at 9:14 PM, Zbigniew Jędrzejewski-Szmek
wrote:
> On Thu, Jun 19, 2014 at 07:07:02PM -0700, Michael Marineau wrote:
>> Since 12ed81d9 path_strv_canonicalize_absolute leaves the search list
>> relative to the given root directory instead of resolving paths to their
>> true locat
On Thu, Jun 19, 2014 at 07:07:02PM -0700, Michael Marineau wrote:
> Since 12ed81d9 path_strv_canonicalize_absolute leaves the search list
> relative to the given root directory instead of resolving paths to their
> true location as the name implies. To better reflect this behavior
> rename to the l
On Fri, Jun 13, 2014 at 04:41:03PM +0200, Werner Fink wrote:
> From: Frederic Crozat
>
> Otherwise any agetty on the devices of the system console will
> conflict with sulogin and its input.
>
> ---
> units/getty@.service.m4|1 +
> units/rescue.target|1 +
> units/se
Hello.
I just joined the list so I'm sorry if this is not the proper way to
propose or ask for a feature to be added to systemd. I spoke in
#systemd on Freenode a few days ago and I was pointed in this
direction for submitting feature requests.
I read this post: http://0pointer.de/blog/projects/
On Fri, Jun 13, 2014 at 04:41:07PM +0200, Werner Fink wrote:
> It was seen only once, nevertheless this change does avoid the
> assert on s->user->slice in session_start_scope()
Yeah, it seems possible that the slice will not be started and
the assert can fail. It seems that instead of checking s->
On Mon, Jun 16, 2014 at 02:59:34PM +0200, Dr. Werner Fink wrote:
> On Fri, Jun 13, 2014 at 07:09:50PM +0300, Ran Benita wrote:
> > From a cursory look, the bash-completion package deals with this issue
> > in a more systematic way. See _init_completion() in
> > /usr/share/bash-completion/bash_compl
On Wed, Jun 18, 2014 at 08:10:03PM +0200, Goffredo Baroncelli wrote:
> Hi Fink
>
> On 06/13/2014 04:41 PM, Werner Fink wrote:
> > That is: set NOATIME, NOCOW, and NOCOMP for the journal directory
>
> If I read correctly, you want set UN-conditionally the NOCOW behavior.
> Please, please, please
On Fri, Jun 13, 2014 at 04:41:05PM +0200, Werner Fink wrote:
> Therefore strip off the ANSI escape sequences for 3215 consoles
> but support 3270 consoles if found.
>
> ---
> src/core/manager.c | 24
> src/shared/util.c | 80
> +++
On Tue, Jun 17, 2014 at 06:52:04AM +0400, Andrey Borzenkov wrote:
> В Fri, 13 Jun 2014 16:41:04 +0200
> Werner Fink пишет:
>
> > From: arvidj...@gmail.com
> >
> > will terminate emergency.service due to implicit dependencies on
> > basic.target
> > and therefore sysinit.target which in turn con
On Fri, Jun 13, 2014 at 04:41:02PM +0200, Werner Fink wrote:
> From: Frederic Crozat
>
> ---
> units/systemd-ask-password-wall.service.in |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git units/systemd-ask-password-wall.service.in
> units/systemd-ask-password-wall.ser
On Fri, Jun 13, 2014 at 04:41:01PM +0200, Werner Fink wrote:
> Otherwise the add_symlink() function tries to make directories for each
> slash even for the slash after the @ symbol in the final link name.
I now pushed a simpler patch which should fix the issue. Please
test.
Zbyszek
___
This restores the original root handling logic that was present prior to
112cfb18 when path expansion moved to path_strv_canonicalize_absolute.
That behavior partially went away in 12ed81d9.
Alternatively all users of conf_files_list* could be updated to
concatenate the paths themselves as unit_fi
Update for the current behavior of path_strv_resolve which now returns
paths relative to the given root, not the full absolute paths.
---
src/shared/util.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/shared/util.c b/src/shared/util.c
index c1e1f9f..aaf109e 100644
--
---
.gitignore | 1 +
Makefile.am| 9 -
src/test/test-conf-files.c | 84 ++
3 files changed, 93 insertions(+), 1 deletion(-)
create mode 100644 src/test/test-conf-files.c
diff --git a/.gitignore b/.gitignore
index
---
src/test/test-path-util.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/src/test/test-path-util.c b/src/test/test-path-util.c
index 9f8ae4d..4ee33a9 100644
--- a/src/test/test-path-util.c
+++ b/src/test/test-path-util.c
@@ -20,10 +20,12 @@
***/
#inclu
Since 12ed81d9 path_strv_canonicalize_absolute leaves the search list
relative to the given root directory instead of resolving paths to their
true location as the name implies. To better reflect this behavior
rename to the less strongly worded path_strv_resolve.
---
src/shared/conf-files.c | 2 +
On Wed, Jun 18, 2014 at 11:54:49AM +0200, Dr. Werner Fink wrote:
> On Mon, Jun 16, 2014 at 06:02:37PM +0200, Tom Gundersen wrote:
> > On Mon, Jun 16, 2014 at 5:19 PM, Frederic Crozat wrote:
> > >
> > > See https://bugzilla.novell.com/show_bug.cgi?id=725412
> >
> > Hm, that really does not look co
On Sat, Mar 23, 2013 at 04:50:26AM +0100, Lennart Poettering wrote:
> On Sat, 23.03.13 03:54, Cristian Rodríguez (crrodrig...@opensuse.org) wrote:
>
> > Modules might or will register new sysctl options.
>
> Well, most modules are loaded asynchronously from udev, so I fear this
> won't do much...
On Fri, Jun 20, 2014 at 12:26:12AM +0200, Ronny Chevalier wrote:
> ---
> src/test/test-fdset.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied!
Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mai
On Fri, Jun 20, 2014 at 12:25:58AM +0200, Ronny Chevalier wrote:
> ---
> src/test/test-strv.c | 15 +++
> 1 file changed, 15 insertions(+)
Applied!
Zbyszek
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freed
On Fri, Jun 20, 2014 at 12:25:34AM +0200, Ronny Chevalier wrote:
> add tests for:
> - filename_is_safe
> - ascii_strlower
> - files_same
> - is_valid_documentation_url
> - file_in_same_dir
> - endswith
> - close_nointr
> - unlink_noerrno
> - readlink_and_make_absolute
> - read_o
On Thu, 19.06.14 15:27, Filipe Brandenburger (filbran...@google.com) wrote:
>
> Thanks Lennart!
>
> Any chance that testing "make dist" and "make distcheck" could be
> incorporated as part of the Jenkins run?
David Strauss runs the Jenkins instance. David, any chance you can add
"make distcheck
On Wed, 18.06.14 20:19, Alexey Shabalin (a.shaba...@gmail.com) wrote:
> Hello.
>
> I do not understand how the should work localization of console.
> - systemd-vconsole-setup.service for an early boot (for enter password
> in cryptsetup? but people do not used non-latin letters for password)
>
>
On Wed, 18.06.14 21:51, Friedrich Kröner (friedr...@mailstation.de) wrote:
> Hello,
>
> when trying systemd-networkd with >=214 and the following config:
>
> [Match]
> Name=eth*
>
> [Network]
> DHCP=yes
>
> Address=2001:db8::1234:5678/64
> DNS=8.8.8.8
> DNS=2001:db8:1::ab9:C0A8:102
> reverting
On Thu, 19.06.14 10:43, Ronny Chevalier (chevalier.ro...@gmail.com) wrote:
Applied earlier today by Zbigniew! Thanks!
> ---
> man/systemd.special.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/systemd.special.xml b/man/systemd.special.xml
> index f29cc23..2ff64
On Thu, Jun 19, 2014 at 12:28:06PM -0700, Brandon Philips wrote:
> On Sat, Jun 14, 2014 at 8:13 AM, Zbigniew Jędrzejewski-Szmek
> wrote:
> > I think that designing the api in steps like this will make it harder
> > to get a consistent design. The journal api is rather small, so I don't
> > think i
On Thu, 19.06.14 19:32, Ronny Chevalier (chevalier.ro...@gmail.com) wrote:
Looks good!
Applied! Thanks!
> Don't close the fd given to sd-icmp6-nd, since it will be aynschonously closed
> by sd_icmp6_nd_unref
> ---
> src/libsystemd-network/test-icmp6-rs.c | 1 -
> 1 file changed, 1 deletion(-)
>
On Thu, 19.06.14 19:32, Ronny Chevalier (chevalier.ro...@gmail.com) wrote:
Looks good! Applied!
> ---
> src/libsystemd-network/sd-icmp6-nd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/libsystemd-network/sd-icmp6-nd.c
> b/src/libsystemd-network/sd-icmp6-nd.c
> index f820a9c..1
Thanks Lennart!
Any chance that testing "make dist" and "make distcheck" could be
incorporated as part of the Jenkins run?
I also have some other patches I sent on Monday that fix some other
problems in dist and distcheck... It would be great if someone could
take a look at them...
Cheers,
Filip
On Thu, 19.06.14 19:44, Ronny Chevalier (chevalier.ro...@gmail.com) wrote:
Looks good! Applied!
> ---
> src/libsystemd-network/sd-dhcp6-client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libsystemd-network/sd-dhcp6-client.c
> b/src/libsystemd-network/sd-d
On Thu, 19.06.14 11:18, Filipe Brandenburger (filbran...@google.com) wrote:
> The correct path is now (from glibc-headers) and no longer
> (from libattr-devel.)
>
> Fixes: 34c10968cbe3b5591b3c0ce225b8694edd9709d0
Thanks a lot! Applied!
Lennart
--
Lennart Poettering, Red Hat
---
src/test/test-fdset.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/test/test-fdset.c b/src/test/test-fdset.c
index ed83ee1..7f52748 100644
--- a/src/test/test-fdset.c
+++ b/src/test/test-fdset.c
@@ -111,4 +111,6 @@ int main(int argc, char *argv[]) {
test_fdset_put_dup();
On Thu, 19.06.14 11:59, Filipe Brandenburger (filbran...@google.com) wrote:
> If the file is not listed, then "make dist" will not include it.
>
> Tested: "make distcheck" works after this fix is applied.
>
> Fixes: 139b011ab81ccea1d51f09e0261a1c390115c6ff
Thanks!
Applied all three!
Lennart
add tests for:
- filename_is_safe
- ascii_strlower
- files_same
- is_valid_documentation_url
- file_in_same_dir
- endswith
- close_nointr
- unlink_noerrno
- readlink_and_make_absolute
- read_one_char
- ignore_signals
- strshorten
---
src/test/test-util.c | 202 +
---
src/test/test-strv.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/src/test/test-strv.c b/src/test/test-strv.c
index c8c5fc9..24ed681 100644
--- a/src/test/test-strv.c
+++ b/src/test/test-strv.c
@@ -323,6 +323,20 @@ static void test_strv_extend(void) {
assert_se
On Thu, 19.06.14 22:48, Thomas H.P. Andersen (pho...@gmail.com) wrote:
> From: Thomas Hindoe Paaboel Andersen
>
> after 19f3934057d20c63f4c95791312038a41b4666d0 the errors from chown/chmod
> will be cleared before being read. Presumably to clear the possible EEXIST
> from copying to an existing
On Thu, Jun 19, 2014 at 12:37 PM, Dan Mace wrote:
> This is on my backburner at the moment while I work on some other things.
> Hitting the segfault while testing our primary use case and being unable to
> reproduce the error made me nervous enough that I don't feel comfortable
> promoting any
From: Thomas Hindoe Paaboel Andersen
after 19f3934057d20c63f4c95791312038a41b4666d0 the errors from chown/chmod
will be cleared before being read. Presumably to clear the possible EEXIST
from copying to an existing directory.
Note: with this patch we stop immediately on error in chown/chmod while
On Thu, Jun 19, 2014 at 12:02:39PM -0500, Dan Williams wrote:
> On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote:
> > Check that received DHCP packets actually include our MAC address in
> > chaddr field. BPF interpreter has 32 bit wide registers but MAC address
> > is 48 bits long so we ha
- Original Message -
> From: "Brandon Philips"
> To: "Zbigniew Jędrzejewski-Szmek"
> Cc: "Dan Mace" , "systemd Mailing List"
> ,
> appinfra-l...@redhat.com
> Sent: Thursday, June 19, 2014 3:28:06 PM
> Subject: Re: [systemd-devel] Soliciting feedback for golang bindings to the
> systemd
On Sat, Jun 14, 2014 at 8:13 AM, Zbigniew Jędrzejewski-Szmek
wrote:
> I think that designing the api in steps like this will make it harder
> to get a consistent design. The journal api is rather small, so I don't
> think it is hard to cover most of it in the initial design. In my
> experience, ge
Makefile.am had a reference to it but it none of the sources included it.
Tested: "make dist" works again after this patchset is applied.
Fixes: 2ea8857effb833615b16d10fc7a19a7104c19e13
---
Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 4f4eb372935
If the file is not listed, then "make dist" will not include it.
Tested: "make distcheck" works after this fix is applied.
Fixes: 139b011ab81ccea1d51f09e0261a1c390115c6ff
---
Makefile.am | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile.am b/Makefile.am
index d93b64e69d85..2427b24f59f
It was incorrectly looking for a file in src/libsystemd-network/ when the file
was actually deployed to src/systemd/ instead. This broke "make dist".
Tested: "make dist" works again after this patchset is applied.
Fixes: f20a35cc0d537dd4cfc1054cf7936b04a1700f3a
---
Makefile.am | 2 +-
1 file c
---
src/libsystemd-network/sd-dhcp6-client.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/libsystemd-network/sd-dhcp6-client.c
b/src/libsystemd-network/sd-dhcp6-client.c
index ef5fb44..97a2ba7 100644
--- a/src/libsystemd-network/sd-dhcp6-client.c
+++ b/src/libsystem
---
src/libsystemd-network/sd-icmp6-nd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/libsystemd-network/sd-icmp6-nd.c
b/src/libsystemd-network/sd-icmp6-nd.c
index f820a9c..10c5e5e 100644
--- a/src/libsystemd-network/sd-icmp6-nd.c
+++ b/src/libsystemd-network/sd-icmp6-nd.c
@@ -171,6 +1
Don't close the fd given to sd-icmp6-nd, since it will be aynschonously closed
by sd_icmp6_nd_unref
---
src/libsystemd-network/test-icmp6-rs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/libsystemd-network/test-icmp6-rs.c
b/src/libsystemd-network/test-icmp6-rs.c
index 86e02cc..cd5c476
On Tue, Jun 17, 2014 at 11:18:24PM +0200, Simon Peeters wrote:
> ---
> Makefile | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index c593b51..178257b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -17,7 +17,8 @@ kdbus$(EXT)-y := \
>
>
On Thu, 2014-06-19 at 18:59 +0200, Michal Sekletar wrote:
> Check that received DHCP packets actually include our MAC address in
> chaddr field. BPF interpreter has 32 bit wide registers but MAC address
> is 48 bits long so we have to do check in two steps.
And if the MAC address is not 48 bits (I
Check that received DHCP packets actually include our MAC address in
chaddr field. BPF interpreter has 32 bit wide registers but MAC address
is 48 bits long so we have to do check in two steps.
---
src/libsystemd-network/dhcp-internal.h| 3 ++-
src/libsystemd-network/dhcp-network.c | 15 +
---
src/libsystemd-network/dhcp-network.c | 4
1 file changed, 4 insertions(+)
diff --git a/src/libsystemd-network/dhcp-network.c
b/src/libsystemd-network/dhcp-network.c
index e5fd6a8..f500bff 100644
--- a/src/libsystemd-network/dhcp-network.c
+++ b/src/libsystemd-network/dhcp-network.c
@@
On Mon, Jun 02, 2014 at 06:03:27PM +0200, Michal Sekletar wrote:
> This should make logic in locale_setup() work as intended, hence don't
> parse /etc/locale.conf if admin passed to us explicit locale settings on
> kernel cmdline.
> ---
> src/shared/fileio.c | 28 ++--
> 1
On Fri, May 30, 2014 at 06:20:16PM +0200, Michal Sekletar wrote:
ping?
> ---
> src/locale/localed.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/src/locale/localed.c b/src/locale/localed.c
> index e3061c8..358f6c2 100644
> --- a/src/locale/localed.c
> +
The rationale for this is that libvirt first creates the machine on
machined and then starts the init process of the container. In such a
case, the leader pid can't be the proper one when registering the
machine and it needs to be updated as soon as the init process is
started.
---
src/machine/mac
Hi list,
I'm working on getting (at least the basics for now) ready to run a KF5
based Plasma Workspace session completely based on systemd user-session
services to get rid of the legacy cruft shell-based "startkde" script
and get to use all the nice things systemd offers.
I'm currently stuck try
On Thu, Jun 19, 2014 at 1:49 PM, Alexey Shabalin wrote:
>>>
>>> Oh, sorry. I have not problems with encryption passphrase.
>>> I can not see my font after getty@.service, after login.
>>
>> Are you using graphical plymouth (or may be another boot splash screen)?
>
> Yes, plymouth.
>
It sounds sim
On Wed, 2014-06-18 at 16:27 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > Go ahead and push. It is probably simpler to make further
> > suggestions/comments in terms of patches anyway.
> Agreed. I made some small comments, but the patch set looks great.
Polished a bit more and pushed, enjoy!
Chee
On Thu, Jun 19, 2014 at 02:52:06PM +0300, Patrik Flykt wrote:
> On Wed, 2014-06-18 at 16:25 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote:
> > > On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek
> > > wrote:
> > > >> +
On Wed, 2014-06-18 at 16:27 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > Go ahead and push. It is probably simpler to make further
> > suggestions/comments in terms of patches anyway.
> Agreed. I made some small comments, but the patch set looks great.
Patch set fixed according to your comments e
On Wed, 2014-06-18 at 16:25 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> On Wed, Jun 18, 2014 at 07:05:35AM -0700, Filipe Brandenburger wrote:
> > On Wed, Jun 18, 2014 at 6:58 AM, Zbigniew Jędrzejewski-Szmek
> > wrote:
> > >> +if (client->fd > 0)
> > >> +safe_close(client->f
Hello,
Simple question: is there a way to set bridge parameters (bridge forward delay,
bridge hello time, etc) using systemd networking units?
Regards,
Vlad.
___
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.or
2014-06-19 6:31 GMT+04:00 Andrey Borzenkov :
> В Thu, 19 Jun 2014 02:04:53 +0400
> Alexey Shabalin пишет:
>
>> 2014-06-19 0:06 GMT+04:00 Jason St. John :
>> > On Wed, Jun 18, 2014 at 12:19 PM, Alexey Shabalin
>> > wrote:
>> >> Hello.
>> >>
>> >> I do not understand how the should work localizati
---
man/systemd.special.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/systemd.special.xml b/man/systemd.special.xml
index f29cc23..2ff64c9 100644
--- a/man/systemd.special.xml
+++ b/man/systemd.special.xml
@@ -1137,7 +1137,7 @@
Hi,
On Wed, 2014-06-18 at 15:50 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > +if (!client->retransmit_time) {
> > +client->retransmit_time =
> > +
> > client_timeout_compute_random(init_retransmit_time);
> > +} else {
> > +
64 matches
Mail list logo
