Re: [sword-devel] Patch for Sword crash with BibleTime on Windows

2011-02-11 Thread Troy A. Griffitts
Gary, Thanks again for tracking this down and reporting the problem. I just looked at your comment and it does look like this would be a good fix. The oddity is that it looks the bug stems from the Personal module. The RawFiles::createModule method does the right thing and create the increment

Re: [sword-devel] Patch for Sword crash with BibleTime on Windows

2011-02-11 Thread Gary Holmlund
Troy, Looking at getNextFilename more, it seems that it should skip reading the file if it did not open and go on with writing the incfile a few lines later. Gary On 2/11/2011 7:39 PM, Gary Holmlund wrote: Troy, In Rawfiles::getNextFilename() it is opening this file to read it. "C:\Progra

Re: [sword-devel] Patch for Sword crash with BibleTime on Windows

2011-02-11 Thread Gary Holmlund
Troy, In Rawfiles::getNextFilename() it is opening this file to read it. "C:\ProgramData\Application Data\Sword/modules/comments/rawfiles/personal/incfile" The problem is that this file does not exist. I am not sure when this file should have been created. Gary On 2/11/2011 5:49 PM, Troy

Re: [sword-devel] Patch for Sword crash with BibleTime on Windows

2011-02-11 Thread Troy A. Griffitts
Hey Gary, Thanks for the report. The problem with your patch is that it doesn't actually fix the problem. read should fail if you try to read from an invalid file descriptor. The problem is that it sounds like the RawFiles driver has a bug which is reading from an invalid file descriptor. Does