Re: [sword-devel] module driver reorganization proposal

2014-03-27 Thread John Austin
This sounds great! Hopefully this will also result in adding support for compressing RawCom4 commentaries? Currently this is not possible, but would sure be great to have. Thanks Chris! -John On 03/18/2014 12:43 PM, Chris Little wrote: We've got quite a few classes in Sword that essentially d

Re: [sword-devel] module driver reorganization proposal

2014-03-20 Thread Peter von Kaehne
On Tue, 2014-03-18 at 12:21 -0700, Troy A. Griffitts wrote: > I think it is important to maintain the > SWCom distinction and that SWCom should not conceptually inherit SWText, > though I do understand why you propose such to reduce code duplication. Complex commentaries I have seen will re-run

Re: [sword-devel] module driver reorganization proposal

2014-03-18 Thread Troy A. Griffitts
On 03/18/2014 07:58 AM, DM Smith wrote: Chris, Your suggestion is very similar to JSword's implementation. It has simplified code maintenance. There are three types of module files: index, compression index and data files. It may do well to handle these separately. The index consists of fixed

Re: [sword-devel] module driver reorganization proposal

2014-03-18 Thread DM Smith
Chris, Your suggestion is very similar to JSword's implementation. It has simplified code maintenance. There are three types of module files: index, compression index and data files. It may do well to handle these separately. The index consists of fixed sized entries consisting of parts. For a

Re: [sword-devel] module driver reorganization proposal

2014-03-18 Thread Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18.03.2014 15:46, Jonathan Morgan wrote: > On Tue, Mar 18, 2014 at 6:24 PM, Jaak Ristioja > wrote: > > On 18.03.2014 08:43, Chris Little wrote: >> We've got quite a few classes in Sword that essentially >> duplicate code f

Re: [sword-devel] module driver reorganization proposal

2014-03-18 Thread Jonathan Morgan
Hi Jaak, On Tue, Mar 18, 2014 at 6:24 PM, Jaak Ristioja wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 18.03.2014 08:43, Chris Little wrote: > > We've got quite a few classes in Sword that essentially duplicate > > code found elsewhere in Sword, with minor changes. The module >

Re: [sword-devel] module driver reorganization proposal

2014-03-18 Thread Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 18.03.2014 08:43, Chris Little wrote: > We've got quite a few classes in Sword that essentially duplicate > code found elsewhere in Sword, with minor changes. The module > drivers are a prime example. > > Specific examples include RawText & RawText

[sword-devel] module driver reorganization proposal

2014-03-17 Thread Chris Little
We've got quite a few classes in Sword that essentially duplicate code found elsewhere in Sword, with minor changes. The module drivers are a prime example. Specific examples include RawText & RawText4, RawCom & RawCom4, zText & zText4 (new as of today), zCom & zCom4 (new as of today), and Raw