Re: [sword-devel] configure.ac defaults

2009-12-07 Thread DM Smith
As a SWORD utility developer and minor contributor elsewhere in the SWORD code, I wouldn't be bothered by having the deepest set of messages coming from the compile. I think they are invaluable in finding/fixing bugs and potential bugs as well as identifying better practices. But because platfo

Re: [sword-devel] configure.ac defaults

2009-12-07 Thread Matthew Talbert
As Jonathan says above, -Wall and -Werror should be enabled for non-debug builds as well. Although current packages in most distros are currently exempt from conforming to some standards, it wouldn't surprise me at all if these standards were made retroactive to existing packages at some point. Jus

Re: [sword-devel] configure.ac defaults

2009-12-07 Thread Karl Kleinpaste
Eeli Kaikkonen writes: > It would of course be a good > practice for any project to use -Werror for all occasions if possible. Early last year as we were getting Xiphos back into the Fedora repos, their package review folks raised questions that led us to introduce -Wall -Werror. The result was

Re: [sword-devel] configure.ac defaults (was: -O3 -g)

2009-12-07 Thread Eeli Kaikkonen
On Sun, 6 Dec 2009, Troy A. Griffitts wrote: > Finally, we added a while back turning on -Wall -Werror, I think at the > request of the Bibletime team because they started using it and some of > our headers where causing them trouble. The purpose of -Werror is to keep the code as clean and correc

Re: [sword-devel] configure.ac defaults

2009-12-06 Thread Jonathan Marsden
Troy A. Griffitts wrote: > COLORED_ECHO([BUILD TESTS: $enable_tests]) > COLORED_ECHO([BUILD EXAMPLES: $enable_examples]) > COLORED_ECHO([BUILD UTILITIES: $enable_utilities]) If we're going for comprehensiveness, we could add COLORED_ECHO([CONF: $with_conf])

[sword-devel] configure.ac defaults (was: -O3 -g)

2009-12-06 Thread Troy A. Griffitts
Thanks for all the suggestions about the defaults. Here's what we've done for this part of the this thread. Defaults changed: with-icu yes enable-tests yes Expanded the new configure summary to also include: COLORED_ECHO([BUILD TESTS: $enable_tests]) COLORED_ECHO([BUILD EXAMPL