Re: [sword-devel] Win32 FileMgr Subclass

2020-07-27 Thread David Haslam
Thanks Greg, I have just downloaded the two Xiphos builds and successfully installed the x32 edition of Xiphos. I observe afterwards that the Sword utilities all have the filedate 2020-04-26 07:26 Was this to be expected? And is this commensurate with the issue that this new build addressed? i.

Re: [sword-devel] Win32 FileMgr Subclass - BibleTime

2020-07-27 Thread Greg Hellings
b.com/tobias-klein/sword-build-win32/blob/master/build_bzip2.bat > > > > Best regards, > Tobias > > > > *From: *Gary Holmlund > *Sent: *Montag, 27. Juli 2020 21:01 > *To: *SWORD Developers' Collaboration Forum ; Greg > Hellings > *Subject: *Re: [sword-

Re: [sword-devel] Win32 FileMgr Subclass - BibleTime

2020-07-27 Thread Gary Holmlund
On 7/27/2020 7:24 AM, Greg Hellings wrote: If any other Xiphos developers want to do testing, or if BibleTime does any cross compiling from Fedora. You can also find Xiphos installers building the latest Xiphos head against this latest Sword head. I'm very far from any Windows machine I can

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-27 Thread Tobias Klein
Just to confirm. The VS-based build still works fine after the latest commit (svn rev 3771). Best regards, Tobias From: Troy A. Griffitts Sent: Montag, 27. Juli 2020 10:42 To: SWORD Developers' Collaboration Forum Subject: Re: [sword-devel] Win32 FileMgr Subclass That crazy cmake line ce

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-27 Thread Greg Hellings
On Mon, Jul 27, 2020 at 4:42 AM Troy A. Griffitts wrote: > That crazy cmake line certain did work to configure a cross-compile. > Someone needs to write that one down somewhere. > That line was taken from my RPM build script. Most of it is the standard MinGW cross-compile macro used, then a few e

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-27 Thread Troy A. Griffitts
That crazy cmake line certain did work to configure a cross-compile.  Someone needs to write that one down somewhere. So, I've included in filemgr.cpp and this seems to resolve this for mingw.  I get a bunch of .EXEs in utilities, so I think it worked. I'll commit, and then go back and be su

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Greg Hellings
If you're missing dependencies you should be able to do, "dnf builddep mingw-sword". --Greg On Mon, Jul 27, 2020 at 1:33 AM Greg Hellings wrote: > > > On Sun, Jul 26, 2020 at 4:56 PM Tobias Klein wrote: > >> Hi Troy, >> >> The latest version builds successfully. >> >> I created a new intermedi

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Greg Hellings
On Sun, Jul 26, 2020 at 4:56 PM Tobias Klein wrote: > Hi Troy, > > The latest version builds successfully. > > I created a new intermediate release of sword-build-win32 for further > testing on Windows: > It's still failing for me trying to do a cross-compile with MinGW: [ 6%] Building CXX obje

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Tobias Klein
Hi Troy, The latest version builds successfully. I created a new intermediate release of sword-build-win32 for further testing on Windows: https://github.com/tobias-klein/sword-build-win32/releases/tag/v1.8.900-2020-07-26 Best regards, Tobias On 7/26/20 8:37 PM, Troy A. Griffitts wrote: T

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Troy A. Griffitts
Thanks Tobias, I've made these updates and should have fixed the error in filemgr.cpp on line 410. I appreciate the feedback.  Please update and try this out and let me know.  Thanks for testing your compiler. Troy On 7/26/20 8:25 PM, Tobias Klein wrote: To address the errors below I had

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Tobias Klein
To address the errors below I had to add the include for both in *src/mgr/filemgr.cpp* and in *src/modules/commons/zipmgr.cpp*. After that I'm getting the next error: 1>C:\Users\tobi\Dev\sword-build-win32\sword\src\mgr\filemgr.cpp(410): error C2664: 'BOOL FindNextFileA(HANDLE,LPWIN32_FIND_DAT

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Troy A. Griffitts
Can one of you guys try simply including at the top of filemgr.cpp and see if this fixes it for you? On 7/26/20 4:01 PM, Tobias Klein wrote: I'm getting similar error messages with Visual Studio 2019. Note that I'm also generating the make files via CMake. First couple of error messages:

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Tobias Klein
I'm getting similar error messages with Visual Studio 2019. Note that I'm also generating the make files via CMake. First couple of error messages: 2>D:\a\sword-build-win32\sword-build-win32\sword\src\mgr\filemgr.cpp(395,2): error C2065: 'WIN32_FIND_DATAW': undeclared identifier 2>D:\a\sword-b

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Greg Hellings
On Sun, Jul 26, 2020 at 6:42 AM Troy A. Griffitts wrote: > I've just committed the last bit for fixing the WIN32 Unicode issues. If > anyone can try compiling and running Xiphos without the Xiphos patch or any > other projects for Windows, and let me know if things work for them in > folders whi

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-26 Thread Troy A. Griffitts
I've just committed the last bit for fixing the WIN32 Unicode issues.  If anyone can try compiling and running Xiphos without the Xiphos patch or any other projects for Windows, and let me know if things work for them in folders which include Unicode character, I would appreciate it.  I've test

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-20 Thread Greg Hellings
Sorry for the previous blank email - user error when I tried to reply: On Sun, Jul 19, 2020 at 2:40 PM Tobias Klein wrote: > Thanks for giving me the background on this, Karl! I appreciate it! > > Is Xiphos the only frontend that has been patching Sword for this purpose? > Then I suppose all oth

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-20 Thread Greg Hellings
for putting in the work to make Sword behave well with non-ascii > path names! > > > > Best regards, > Tobias > > > > *From: *Karl Kleinpaste > *Sent: *Sonntag, 19. Juli 2020 15:23 > *To: *SWORD Developers' Collaboration Forum > *Subject: *Re: [sword-de

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-19 Thread Karl Kleinpaste
On 7/19/20 3:40 PM, Tobias Klein wrote: > Is Xiphos the only frontend that has been patching Sword for this > purpose? Then I suppose all other frontends suffer from this issue, huh? As far as I know, yes to both questions, though JSword apps are of course differently insulated. __

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-19 Thread Tobias Klein
regards, Tobias From: Karl Kleinpaste Sent: Sonntag, 19. Juli 2020 15:23 To: SWORD Developers' Collaboration Forum Subject: Re: [sword-devel] Win32 FileMgr Subclass On 7/18/20 1:53 PM, Tobias Klein wrote: No, I have not tested my code properly with non-ascii characters in paths / file

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-19 Thread Karl Kleinpaste
On 7/18/20 1:53 PM, Tobias Klein wrote: > > No, I have not tested my code properly with non-ascii characters in > paths / file names. > The original cause for the Xiphos patch to Sword was because, 11 years ago when we introduced the Win32 port, as GnomeSword was renamed Xiphos, one of our first n

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread David Haslam
t: Samstag, 18. Juli 2020 15:58 > To: [SWORD Developers' Collaboration Forum](mailto:sword-devel@crosswire.org) > Subject: Re: [sword-devel] Win32 FileMgr Subclass > > Tobias, > > Has this been tested with file paths that contain characters outside of the > basic ASCII code r

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Greg Hellings
calls. >> >> >> >> On Sat, Jul 18, 2020, 08:24 Tobias Klein wrote: >> >> Maybe not a full-fledged FileMgr class, but at least everything I need in >> Ezra Project at the moment: >> >> >> https://github.com/tobias-klein/node-sword-interface/blo

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Tobias Klein
braries like Qt or Boost have solved these kind of issues somehow … Best regards, Tobias From: Greg Hellings Sent: Samstag, 18. Juli 2020 15:58 To: SWORD Developers' Collaboration Forum Subject: Re: [sword-devel] Win32 FileMgr Subclass Tobias, Has this been tested with file paths that contai

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Troy A. Griffitts
oost have solved these kind of issues somehow … Best regards, Tobias *From: *Greg Hellings <mailto:greg.helli...@gmail.com> *Sent: *Samstag, 18. Juli 2020 15:58 *To: *SWORD Developers' Collaboration Forum <mailto:sword-devel@crosswire.org> *Subject: *Re: [sword-devel] Win32 File

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Tom Sullivan
It works on Windows, macOS and Linux. Best regards, Tobias *From: *Troy A. Griffitts <mailto:scr...@crosswire.org> *Sent: *Samstag, 18. Juli 2020 14:42 *To: *SWORD Developers' Collaboration Forum <mailto:sword-devel@crosswire.org> *Subject: *[sword-de

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Tobias Klein
aboration Forum Subject: Re: [sword-devel] Win32 FileMgr Subclass Tobias, Has this been tested with file paths that contain characters outside of the basic ASCII code range? That's where current Sword fails. Not in fetching the data for the paths themselves, but the actual calls to fopen a

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Greg Hellings
gt; > > > Best regards, > Tobias > > > > *From: *Troy A. Griffitts > *Sent: *Samstag, 18. Juli 2020 14:42 > *To: *SWORD Developers' Collaboration Forum > *Subject: *[sword-devel] Win32 FileMgr Subclass > > > > I know Greg has sent me a link to the pa

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Troy A. Griffitts
macOS and Linux. > >Best regards, >Tobias > >From: Troy A. Griffitts >Sent: Samstag, 18. Juli 2020 14:42 >To: SWORD Developers' Collaboration Forum >Subject: [sword-devel] Win32 FileMgr Subclass > >I know Greg has sent me a link to the patch you guys apply to get >

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Tobias Klein
/file_system_helper.cpp It works on Windows, macOS and Linux. Best regards, Tobias From: Troy A. Griffitts Sent: Samstag, 18. Juli 2020 14:42 To: SWORD Developers' Collaboration Forum Subject: [sword-devel] Win32 FileMgr Subclass I know Greg has sent me a link to the patch you guys apply t

Re: [sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Greg Hellings
On Sat, Jul 18, 2020, 07:42 Troy A. Griffitts wrote: > I know Greg has sent me a link to the patch you guys apply to get Xiphos > to run well on Win32, but I have searched through all my past emails > with every relevant term I can thing of, and still can't find it. I am > sorry, Could you poss

[sword-devel] Win32 FileMgr Subclass

2020-07-18 Thread Troy A. Griffitts
I know Greg has sent me a link to the patch you guys apply to get Xiphos to run well on Win32, but I have searched through all my past emails with every relevant term I can thing of, and still can't find it.  I am sorry,  Could you possibly sent that again? I think you guys were using glib rout