Re: [sword-devel] SwordReader - Progress...

2008-03-31 Thread Barry Drake
Hi David . David Trotz wrote: > Feel free to chime in if there are any concerns or suggestions. No concerns at all. And since I'm the only person other than yourself that's put anything much into this project in recent years, I'm the only one that might have taken offence. And I'm jus

[sword-devel] SwordReader - Progress...

2008-03-30 Thread David Trotz
Guys, I have been spending a lot of time reorganizing the SwordReader source. In some ways its a rewrite, although I never intended it to be, I just got in deeper than I imagined I would. I have a lot of the underlying structure in place, I mimicked the MFC class structure to keep things famili

Re: [sword-devel] SwordReader - Progress report...

2008-03-17 Thread David Trotz
I found the leaks and they were in SwordReader's search code. There was a call to VerseKey::clone which returns a pointer to a SWKey, which was then being implicitly cast back into a VerseKey object, and the anonymous object was lost in the transaction. This also cleared the stdstr leak as well

[sword-devel] SwordReader - Progress

2008-03-17 Thread David Trotz
I have spent the weekend restructuring some of the SwordReader code. I removed the UString stuff and implemented a more elegant replacement called WCString. WCString can convert (typically implicitly) from const char*, const wchar_t *, and std::string. This will make string manipulations betwee

Re: [sword-devel] SwordReader - Progress report...

2008-03-17 Thread Barry Drake
Hi David . David Trotz wrote: > I have spent the weekend restructuring some of the SwordReader code. Fantastic work. I've been watching your recent commits to svn. I haven't updated and re-built as yet, but the changes look as though it's going to be great. It's wonderful to see that

[sword-devel] SwordReader - Progress report...

2008-03-16 Thread David Trotz
I have spent the weekend restructuring some of the SwordReader code. I removed the UString stuff and implemented a more elegant replacement called WCString. WCString can convert (typically implicitly) from const char*, const wchar_t *, and std::string. This will make string manipulations betwe