Isaac, Thanks for checking and confirming that trunk has been fixed.
Greg, It seems quite reasonable to applying Jaak's patch to the 1.7
branch if we intend on releasing a 1.7.4. I mention this, as this is an
exception to the rule that all patches are first applied to trunk and
then merged
On Sat, Jul 12, 2014 at 10:59:19AM -0700, Troy A. Griffitts wrote:
> Dear Jaak,
>
> Thank you so much for looking into this. I went to review your patch and it
> doesn't apply cleanly to trunk. Have you confirmed that this problem still
> exists in trunk? If so, might you consider sending a pat
For what it's worth, it didn't apply against 1.7.3 for me;
the offsets are off by a line or two.
(However, looking at the context was enough to fix it.)
Now I'll try building from VCS to check it (side note: any reason that
jsword is in git but there's still nothing at github.com/crosswire/sword?)
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Yes, that code has changed a lot since 1.7.3. I have not confirmed
whether the issue still exists in trunk, but 1.7.3 is surely affected
by this. I suggest someone more familiar with the code to confirm that.
Blessings,
Jaak
On 12.07.2014 20:59, Troy
Dear Jaak,
Thank you so much for looking into this. I went to review your patch
and it doesn't apply cleanly to trunk. Have you confirmed that this
problem still exists in trunk? If so, might you consider sending a
patch against trunk? Thank you!
Troy
On 07/10/2014 01:34 AM, Jaak Rist
This has been very long overdue, but I have committed Костя's great work
on v11n mappings to trunk.
We spent some time a few months ago proving the typical parallel Bibles
use case and Костя's implementation works wonderfully. This proof of
concept has been moved into the examples/ folder to
