Re: [sword-devel] Method Name Normalization

2013-01-20 Thread Ben Morgan
Hi Greg, On Mon, Jan 21, 2013 at 6:28 AM, Greg Hellings wrote: > > > > SWIG bindings now up-to-date. > > Bindings users, please holler if I removed things overzealously. > > I haven't tried it, but I believe that this will break BPBible for example. As the bindings are part of SWORD, I believe i

Re: [sword-devel] Patch to speed up iterator incrementation

2013-01-20 Thread Troy A. Griffitts
Applied. Thanks Jaak! On 01/20/2013 07:06 PM, Jaak Ristioja wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi! The attached patch corrects all Sword code where iterators were incremented using postfix operator++(int) in contexts where the return value of the expression was not used. Pre

Re: [sword-devel] Method Name Normalization

2013-01-20 Thread Greg Hellings
On Sun, Jan 20, 2013 at 1:28 PM, Greg Hellings wrote: > > > > On Sat, Jan 19, 2013 at 10:13 AM, Troy A. Griffitts > wrote: > >> In anticipation of a new release, I have a large checkin I'm about to >> commit which will break everything for everyone compiling with -Werror. >> >> We've been normali

Re: [sword-devel] Method Name Normalization

2013-01-20 Thread Greg Hellings
On Sat, Jan 19, 2013 at 10:13 AM, Troy A. Griffitts wrote: > In anticipation of a new release, I have a large checkin I'm about to > commit which will break everything for everyone compiling with -Werror. > > We've been normalizing method names toward a clean API interface at 2.0. > SWORD started

[sword-devel] Patch to speed up iterator incrementation

2013-01-20 Thread Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi! The attached patch corrects all Sword code where iterators were incremented using postfix operator++(int) in contexts where the return value of the expression was not used. Prefix operator++() should be used to avoid the creation of temporary iter

Re: [sword-devel] Method Name Normalization

2013-01-20 Thread Greg Hellings
Attached is a patch (I don't think I have commit privileges to that directory? If so, I can commit it directly.). --Greg On Sun, Jan 20, 2013 at 12:00 PM, Greg Hellings wrote: > Building the library (with CMake) now I get many warnings coming from > examples/cmdline. Among those I get the follo

Re: [sword-devel] Method Name Normalization

2013-01-20 Thread Greg Hellings
Building the library (with CMake) now I get many warnings coming from examples/cmdline. Among those I get the following errors: /home/greg/Source/sword/examples/cmdline/threaded_search.cpp:101: undefined reference to `sword::VerseKey::ParseVerseList(char const*, char const*, bool, bool)' collect2:

[sword-devel] Extra warnings

2013-01-20 Thread Greg Hellings
I don't know if you fixed this in this week's super-commit, as I'm just about to try and build BibleTime against that, but InstallMgr::getCipherCode has long been throwing the pair of warnings "unused parameter `modName'" and "unused parameter `config'" because it is defined with the method body "{

Re: [sword-devel] Patches to fix compiler warnings

2013-01-20 Thread Jaak Ristioja
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi! Is there any progress regarding the patches I sent? A month has passed since I submitted them and there has been no feedback. Blessings Jaak On 03.01.2013 23:11, Jaak Ristioja wrote: > On 02.01.2013 09:22, Nic Carter wrote: >> Thanks for these.

Re: [sword-devel] XHTML Filterset

2013-01-20 Thread Greg Hellings
On Sun, Jan 20, 2013 at 3:43 AM, Jonathan Morgan wrote: > Hi Greg, > > On Sun, Jan 20, 2013 at 3:52 AM, Greg Hellings wrote: > >> >> >> >> On Sat, Jan 19, 2013 at 10:28 AM, Troy A. Griffitts > > wrote: >> >>> I've done my part and changed one more tag. transChange has been >>> upgraded from: >>>

Re: [sword-devel] XHTML Filterset

2013-01-20 Thread Jonathan Morgan
Hi Greg, On Sun, Jan 20, 2013 at 3:52 AM, Greg Hellings wrote: > > > > On Sat, Jan 19, 2013 at 10:28 AM, Troy A. Griffitts > wrote: > >> I've done my part and changed one more tag. transChange has been >> upgraded from: >> >> >> to: >> >> .transChangeSupplied { >> font-style: italic; >>