Re: [swift-dev] Metadata Representation

2017-09-28 Thread Saleem Abdulrasool via swift-dev
On Mon, Sep 25, 2017 at 10:18 PM, John McCall wrote: > On Sep 26, 2017, at 12:35 AM, Saleem Abdulrasool > wrote: > On Mon, Sep 25, 2017 at 11:47 AM, John McCall wrote: > >> > On Sep 25, 2017, at 12:24 PM, Joe Groff wrote: >> >> On Sep 24, 2017, at 10:30 PM, John McCall wrote: >> >>> On Sep 22

Re: [swift-dev] Metadata Representation

2017-09-28 Thread John McCall via swift-dev
> On Sep 28, 2017, at 1:01 PM, Saleem Abdulrasool wrote: > > On Mon, Sep 25, 2017 at 10:18 PM, John McCall > wrote: >> On Sep 26, 2017, at 12:35 AM, Saleem Abdulrasool > > wrote: >> On Mon, Sep 25, 2017 at 11:47 AM, John McCall >

[swift-dev] Builtin.loadRaw

2017-09-28 Thread Sam Ding via swift-dev
I am testing a test case "KeyPath.swift" on s390x for v4.0 . It is found that " Builtin.loadRaw" as the below of "stdlib/public/core/UnsafeRawPointer.swift.gyb" returns a different value than that on x86-64. @_inlineable public func load(fromByteOffset offset: Int = 0, as type: T.Type)

Re: [swift-dev] Metadata Representation

2017-09-28 Thread Saleem Abdulrasool via swift-dev
On Thu, Sep 28, 2017 at 10:59 AM, John McCall wrote: > > On Sep 28, 2017, at 1:01 PM, Saleem Abdulrasool > wrote: > > On Mon, Sep 25, 2017 at 10:18 PM, John McCall wrote: > >> On Sep 26, 2017, at 12:35 AM, Saleem Abdulrasool >> wrote: >> On Mon, Sep 25, 2017 at 11:47 AM, John McCall wrote: >>

Re: [swift-dev] Builtin.loadRaw

2017-09-28 Thread Slava Pestov via swift-dev
Hi Sam, The builtin is defined in lib/SILGen/SILGenBuiltin.cpp, look for the function named emitBuiltinLoadRaw(). However I suspect the problem in this case is not that the builtin is implemented incorrectly (it eventually lowers to an LLVM load instruction) but that something further upstream

Re: [swift-dev] Builtin.loadRaw

2017-09-28 Thread Joe Groff via swift-dev
> On Sep 28, 2017, at 2:16 PM, Sam Ding via swift-dev > wrote: > > I am testing a test case "KeyPath.swift" on s390x for v4.0 . It is found that > " Builtin.loadRaw" as the below of > "stdlib/public/core/UnsafeRawPointer.swift.gyb" returns a different value > than that on x86-64. > @_inlin

Re: [swift-dev] Metadata Representation

2017-09-28 Thread John McCall via swift-dev
> On Sep 28, 2017, at 5:23 PM, Saleem Abdulrasool wrote: > > > > On Thu, Sep 28, 2017 at 10:59 AM, John McCall > wrote: > >> On Sep 28, 2017, at 1:01 PM, Saleem Abdulrasool > > wrote: >> >> On Mon, Sep 25, 2017 at 10:18 PM, John McCal

Re: [swift-dev] Adding a field to StrongRefCount class

2017-09-28 Thread Greg Parker via swift-dev
> On Sep 27, 2017, at 10:39 AM, John McCall via swift-dev > wrote: > >> On Sep 27, 2017, at 1:24 PM, Jiho Choi > > wrote: >> >> Thanks for the explanation. I modified those two locations you mentioned >> but the build failed during tests. I've been browsing the sou