Re: [swift-dev] "available externally" vs build time

2018-01-04 Thread Erik Eckstein via swift-dev
> On Jan 4, 2018, at 4:57 PM, Chris Lattner wrote: > >> On Jan 4, 2018, at 1:08 PM, Erik Eckstein > > wrote: 1. It looks like the MandatoryInliner is the biggest culprit at -O0 here: it deserializes the referenced function (MandatoryInlining.cpp:384) and

Re: [swift-dev] "available externally" vs build time

2018-01-04 Thread Chris Lattner via swift-dev
> On Jan 4, 2018, at 2:11 PM, Erik Eckstein via swift-dev > wrote: > >>> >>> Well, with our pass pipeline architecture I suspect it will not make a >>> difference. We process functions bottom-up. For example, the performance >>> inliner optimizes the callee first before trying to inline it (

Re: [swift-dev] "available externally" vs build time

2018-01-04 Thread Chris Lattner via swift-dev
> On Jan 4, 2018, at 1:08 PM, Erik Eckstein wrote: >>> 1. It looks like the MandatoryInliner is the biggest culprit at -O0 here: >>> it deserializes the referenced function (MandatoryInlining.cpp:384) and >>> *then* checks to see if the callee is @_transparent. Would it make sense >>> to chang

Re: [swift-dev] "available externally" vs build time

2018-01-04 Thread Erik Eckstein via swift-dev
> On Jan 4, 2018, at 1:14 PM, Slava Pestov wrote: > > > >> On Jan 4, 2018, at 1:08 PM, Erik Eckstein > > wrote: >> >> >> >>> On Jan 2, 2018, at 1:08 PM, Slava Pestov via swift-dev >> > wrote: >>> >>> >>> On Dec 28, 2017, at 4:

Re: [swift-dev] "available externally" vs build time

2018-01-04 Thread Slava Pestov via swift-dev
> On Jan 4, 2018, at 1:08 PM, Erik Eckstein wrote: > > > >> On Jan 2, 2018, at 1:08 PM, Slava Pestov via swift-dev >> wrote: >> >> >> >>> On Dec 28, 2017, at 4:32 PM, Chris Lattner via swift-dev >>> wrote: >>> >>> Folks working on the SIL optimizer, particularly those interested in fa

Re: [swift-dev] "available externally" vs build time

2018-01-04 Thread Erik Eckstein via swift-dev
> On Jan 2, 2018, at 1:08 PM, Slava Pestov via swift-dev > wrote: > > > >> On Dec 28, 2017, at 4:32 PM, Chris Lattner via swift-dev >> wrote: >> >> Folks working on the SIL optimizer, particularly those interested in faster >> builds: >> >> If I understand the SIL optimizer correctly, i

Re: [swift-dev] "available externally" vs build time

2018-01-02 Thread Slava Pestov via swift-dev
> On Dec 28, 2017, at 4:32 PM, Chris Lattner via swift-dev > wrote: > > Folks working on the SIL optimizer, particularly those interested in faster > builds: > > If I understand the SIL optimizer correctly, it seems that when the current > program references an external symbol declared as @

Re: [swift-dev] "available externally" vs build time

2017-12-29 Thread Michael Gottesman via swift-dev
> On Dec 28, 2017, at 7:32 PM, Chris Lattner via swift-dev > wrote: > > Folks working on the SIL optimizer, particularly those interested in faster > builds: > > If I understand the SIL optimizer correctly, it seems that when the current > program references an external symbol declared as @