Re: [swift-dev] Swift merge commits no diff

2016-06-22 Thread Vassil Vassilev via swift-dev
Hi Slava, Thanks for explaining. Would this be something useful for others then me? It seems the technical issue is solvable by adding a switch to the git-notifier: "--allchanges Lists branches for which /all/ changes made to them should be mailed out as straight diffs to their previ

Re: [swift-dev] Swift merge commits no diff

2016-06-21 Thread Slava Pestov via swift-dev
Hi Vassil, Since a merge commit has two parents you might potentially want to diff against, I'm assuming the tool is not smart enough to know which one is the PR and which one is trunk. Perhaps this is not too hard to fix with some kind of heuristic though. Slava > On Jun 21, 2016, at 2:49 PM

[swift-dev] Swift merge commits no diff

2016-06-21 Thread Vassil Vassilev via swift-dev
Hi, I am trying to follow the development of swift more closely recently. I noticed that there is no diff below merge commits of pull requests to swift-commits mailing lists. I'd assume this is intentional, but feels awkward. I was wondering what was the rationale for that? Many thanks, V