Re: [swift-dev] Standard shared libraries with executable stack

2016-06-18 Thread Jongsu Kim via swift-dev
Hi, Han Your PR is very helpful. Thanks a lot. The Foundation repo has some assembly files similar to swift_sections.S as follows: swift-corelibs-foundation/CoreFoundation/String.subproj/ CFCharacterSetData.S CFUniCharPropertyDatabase.S CFUnicodeData.S The generated libFoundation.s

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-18 Thread Dmitri Gribenko via swift-dev
Thank you! I merged your PR, it should be included in the next snapshot. Dmitri On Fri, Jun 17, 2016 at 2:26 PM, Sangjin Han wrote: > Please review the PR #3053. > > 2016-06-18 0:17 GMT+09:00 Dmitri Gribenko : >> >> On Fri, Jun 17, 2016 at 7:31 AM, Sangjin Han >> wrote: >> > Hi, >> > >> > When

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-17 Thread Sangjin Han via swift-dev
Please review the PR #3053. 2016-06-18 0:17 GMT+09:00 Dmitri Gribenko : > On Fri, Jun 17, 2016 at 7:31 AM, Sangjin Han > wrote: > > Hi, > > > > When linking libswiftCore.so, gold linker with --warn-execstack option > > generates following messages. > > /usr/bin/ld.gold: warning: lib/swift/linux/

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-17 Thread Dmitri Gribenko via swift-dev
On Fri, Jun 17, 2016 at 7:31 AM, Sangjin Han wrote: > Hi, > > When linking libswiftCore.so, gold linker with --warn-execstack option > generates following messages. > /usr/bin/ld.gold: warning: lib/swift/linux/x86_64/swift_begin.o: missing > .note.GNU-stack section implies executable stack > /usr/

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-17 Thread Sangjin Han via swift-dev
Hi, When linking libswiftCore.so, gold linker with --warn-execstack option generates following messages. /usr/bin/ld.gold: warning: lib/swift/linux/x86_64/swift_begin.o: missing .note.GNU-stack section implies executable stack /usr/bin/ld.gold: warning: lib/swift/linux/x86_64/swift_end.o: missing

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-17 Thread Dmitri Gribenko via swift-dev
Hi, While there wight be an issue in WSL with executable stacks, Swift does not really need one. If the binary is actually asking for one, it would be great if we could figure out a way to ask the gold linker to not mark stacks as executable. Dmitri On Thu, Jun 16, 2016 at 11:39 PM, Sangjin Han

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-16 Thread Sangjin Han via swift-dev
Hi, Kim. The test result is same on WSL build 14342. There is similar report in https://github.com/Microsoft/BashOnWindows/issues/286 . MS engineer recognized this and replied that give them feedback on the uservoice for prioritizing, currently it has only 3 votes. -Han Sangjin 2016-06-16 21:17

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-16 Thread Dmitri Gribenko via swift-dev
On Thu, Jun 16, 2016 at 5:17 AM, Jongsu Kim wrote: > Hi, > >> This could have been caused by our switch from the BFD linker to gold. >> Could you try linking a hello world program using gold linker and >> running it in WSL? > > > I tried to build Swift by not using -fuse-gold option and the result

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-16 Thread Jongsu Kim via swift-dev
Hi, This could have been caused by our switch from the BFD linker to gold. > Could you try linking a hello world program using gold linker and > running it in WSL? > I tried to build Swift by not using -fuse-gold option and the result was same. Are you sure that PROT_GROWSDOWN is the flag that

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-16 Thread 김종수 via swift-dev
Hi, Han The test code is as follows: #include #include int main() { if (!dlopen("swift-3.0-preview-1-ubuntu14.04/usr/lib/swift/linux/libswiftCore.so", RTLD_LAZY | RTLD_GLOBAL)) fprintf(stderr, "%s\n", dlerror()); } The executable stack flag is queried as follows: sudo execstack -

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-14 Thread Sangjin Han via swift-dev
Hi, Kim. I have the WSL on Windows Preview. Could you show the test source/command ? -Han Sangjin 2016-06-14 21:10 GMT+09:00 Ryan Lovelett via swift-dev : > On Mon, Jun 13, 2016, at 11:33 PM, Dmitri Gribenko via swift-dev wrote: > > On Sat, Jun 11, 2016 at 8:12 AM, 김종수 via swift-dev > > wrot

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-14 Thread Ryan Lovelett via swift-dev
On Mon, Jun 13, 2016, at 11:33 PM, Dmitri Gribenko via swift-dev wrote: > On Sat, Jun 11, 2016 at 8:12 AM, 김종수 via swift-dev > wrote: > > I am testing Swift in "Windows Subsystem for Linux" which is a new feature > > of Windows 10 Anniversary Update scheduled in this year. WSL is Ubuntu LTS > > 14

Re: [swift-dev] Standard shared libraries with executable stack

2016-06-13 Thread Dmitri Gribenko via swift-dev
On Sat, Jun 11, 2016 at 8:12 AM, 김종수 via swift-dev wrote: > I am testing Swift in "Windows Subsystem for Linux" which is a new feature > of Windows 10 Anniversary Update scheduled in this year. WSL is Ubuntu LTS > 14.04 compatible in user space. > > Swift runtime libraries such as libswiftCore.so

[swift-dev] Standard shared libraries with executable stack

2016-06-13 Thread 김종수 via swift-dev
I am testing Swift in "Windows Subsystem for Linux" which is a new feature of Windows 10 Anniversary Update scheduled in this year. WSL is Ubuntu LTS 14.04 compatible in user space. Swift runtime libraries such as libswiftCore.so are marked Executable Stack, which have no problem in Linux. dlopen