Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-27 Thread Andrew Trick via swift-dev
> On Apr 26, 2017, at 1:24 PM, Michael Gottesman via swift-dev > wrote: > > Hey everyone. > > I am currently doing some small fixes to SILSuccessor (adding some comments > and fixing some issues exposed by LLVM upstream). As I read the code it > became pretty apparent that the name is a misn

Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-27 Thread John McCall via swift-dev
> On Apr 27, 2017, at 12:01 AM, Bob Wilson wrote: >> On Apr 26, 2017, at 6:43 PM, John McCall via swift-dev > > wrote: >> >>> On Apr 26, 2017, at 6:11 PM, Michael Gottesman >> > wrote: On Apr 26, 2017, at 1:44 PM, John McCall >>>

Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread Bob Wilson via swift-dev
> On Apr 26, 2017, at 6:43 PM, John McCall via swift-dev > wrote: > >> On Apr 26, 2017, at 6:11 PM, Michael Gottesman wrote: >>> On Apr 26, 2017, at 1:44 PM, John McCall wrote: >>> On Apr 26, 2017, at 4:24 PM, Michael Gottesman via swift-dev wrote: Hey everyone. I

Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread John McCall via swift-dev
> On Apr 26, 2017, at 6:11 PM, Michael Gottesman wrote: >> On Apr 26, 2017, at 1:44 PM, John McCall wrote: >> >>> On Apr 26, 2017, at 4:24 PM, Michael Gottesman via swift-dev >>> wrote: >>> Hey everyone. >>> >>> I am currently doing some small fixes to SILSuccessor (adding some comments >>>

Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread Michael Gottesman via swift-dev
> On Apr 26, 2017, at 4:20 PM, Bob Wilson wrote: > >> >> On Apr 26, 2017, at 3:11 PM, Michael Gottesman via swift-dev >> wrote: >> >> >>> On Apr 26, 2017, at 1:44 PM, John McCall wrote: >>> On Apr 26, 2017, at 4:24 PM, Michael Gottesman via swift-dev wrote: Hey everyone.

Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread Bob Wilson via swift-dev
> On Apr 26, 2017, at 3:11 PM, Michael Gottesman via swift-dev > wrote: > > >> On Apr 26, 2017, at 1:44 PM, John McCall wrote: >> >>> On Apr 26, 2017, at 4:24 PM, Michael Gottesman via swift-dev >>> wrote: >>> Hey everyone. >>> >>> I am currently doing some small fixes to SILSuccessor (ad

Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread Michael Gottesman via swift-dev
> On Apr 26, 2017, at 1:44 PM, John McCall wrote: > >> On Apr 26, 2017, at 4:24 PM, Michael Gottesman via swift-dev >> wrote: >> Hey everyone. >> >> I am currently doing some small fixes to SILSuccessor (adding some comments >> and fixing some issues exposed by LLVM upstream). As I read the

Re: [swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread John McCall via swift-dev
> On Apr 26, 2017, at 4:24 PM, Michael Gottesman via swift-dev > wrote: > Hey everyone. > > I am currently doing some small fixes to SILSuccessor (adding some comments > and fixing some issues exposed by LLVM upstream). As I read the code it > became pretty apparent that the name is a misnomer

[swift-dev] Renaming SILSuccessor -> SILCFGEdge

2017-04-26 Thread Michael Gottesman via swift-dev
Hey everyone. I am currently doing some small fixes to SILSuccessor (adding some comments and fixing some issues exposed by LLVM upstream). As I read the code it became pretty apparent that the name is a misnomer... SILSuccessor is not just representing a successor, rather it is representing a