Re: [swift-dev] How to create my first pull request

2017-03-29 Thread Max Moiseev via swift-dev
> On Mar 29, 2017, at 11:06 AM, Pavol Vaskovic wrote: > > Thanks Max! That was very enlightening. One more question… > > On 29 Mar 2017, at 19:57, Max Moiseev > wrote: > >> [...] >> cd swift >> git checkout master >> utils/update-checkout --scheme=master >> git check

Re: [swift-dev] How to create my first pull request

2017-03-29 Thread Pavol Vaskovic via swift-dev
Thanks Max! That was very enlightening. One more question… > On 29 Mar 2017, at 19:57, Max Moiseev wrote: > > [...] > cd swift > git checkout master > utils/update-checkout --scheme=master > git checkout -b my-new-branch > ... some work gets done … > git add . > git commit -m “Adding an absolute

Re: [swift-dev] How to create my first pull request

2017-03-29 Thread Max Moiseev via swift-dev
Hi Pavol, update-checkout, as far as I know, is only there to help you work with *all* the Swift repositories at the same time. This way you won’t have to separately go to every folder and invoke `git pull origin master`. The config file for update-checkout simply lists the ‘schemes’ which are

Re: [swift-dev] How to create my first pull request

2017-03-29 Thread Pavol Vaskovic via swift-dev
Hi Max! > On 28 Mar 2017, at 01:19, Max Moiseev wrote: > > This tutorial looks very detailed and should answer most of your questions: > https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github Thank you for that link! But I'd like to hear how does that general p

Re: [swift-dev] How to create my first pull request

2017-03-27 Thread Alex Martini via swift-dev
> On Mar 27, 2017, at 1:10 PM, Pavol Vaskovic via swift-dev > wrote: > > So far I have completed the "Getting Started” steps: > * checked out the swift-source > * got it to compile on my machine (debug and release) > * manually ran benchmark suite (filed SR-4357, BTW what does SR for?) Here's

Re: [swift-dev] How to create my first pull request

2017-03-27 Thread Max Moiseev via swift-dev
This tutorial looks very detailed and should answer most of your questions: https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github If you’re not very comfortable with, or d

Re: [swift-dev] How to create my first pull request

2017-03-27 Thread David Sweeris via swift-dev
> On Mar 27, 2017, at 1:10 PM, Pavol Vaskovic via swift-dev > wrote: > > Hi! > > I’d like to create my first full request (as requested by Jordan Rose in > SR-4373 ), but I didn’t find enough > information about how to proceed on the Swift’s Contributin

[swift-dev] How to create my first pull request

2017-03-27 Thread Pavol Vaskovic via swift-dev
Hi! I’d like to create my first full request (as requested by Jordan Rose in SR-4373 ), but I didn’t find enough information about how to proceed on the Swift’s Contributing page, nor during my googling. I am not very familiar with git/github outside of brow