Re: [swift-dev] Help needed: Removing inout shadow copy from SILGen

2016-06-09 Thread Daniel Duan via swift-dev
I’ll add an assert and get rid of the conditional then. Thank you Adrian and Joe, for the great feedbacks! - Daniel > On Jun 9, 2016, at 10:09 AM, Adrian Prantl wrote: > >> >> On Jun 9, 2016, at 10:05 AM, Joe Groff wrote: >> >>> >>> On Jun 9, 2016, at 10:01 AM, Adrian Prantl wrote: >>> >

Re: [swift-dev] Help needed: Removing inout shadow copy from SILGen

2016-06-09 Thread Adrian Prantl via swift-dev
> On Jun 9, 2016, at 10:05 AM, Joe Groff wrote: > >> >> On Jun 9, 2016, at 10:01 AM, Adrian Prantl wrote: >> >> On Jun 9, 2016, at 9:55 AM, Joe Groff wrote: >>> >>> On Jun 8, 2016, at 7:38 PM, Daniel Duan via swift-dev wrote: Hi all, I'm resuming work on r

Re: [swift-dev] Help needed: Removing inout shadow copy from SILGen

2016-06-09 Thread Joe Groff via swift-dev
> On Jun 9, 2016, at 10:01 AM, Adrian Prantl wrote: > > On Jun 9, 2016, at 9:55 AM, Joe Groff wrote: >> >> >>> On Jun 8, 2016, at 7:38 PM, Daniel Duan via swift-dev >>> wrote: >>> >>> Hi all, >>> >>> I'm resuming work on removing the SILGen for the inout shadow copy. Making >>> this chang

Re: [swift-dev] Help needed: Removing inout shadow copy from SILGen

2016-06-09 Thread Adrian Prantl via swift-dev
On Jun 9, 2016, at 9:55 AM, Joe Groff wrote: > > >> On Jun 8, 2016, at 7:38 PM, Daniel Duan via swift-dev >> wrote: >> >> Hi all, >> >> I'm resuming work on removing the SILGen for the inout shadow copy. Making >> this change involes quite a bit of tests updates. I'd love some one to >> re

Re: [swift-dev] Help needed: Removing inout shadow copy from SILGen

2016-06-09 Thread Joe Groff via swift-dev
> On Jun 8, 2016, at 7:38 PM, Daniel Duan via swift-dev > wrote: > > Hi all, > > I'm resuming work on removing the SILGen for the inout shadow copy. Making > this change involes quite a bit of tests updates. I'd love some one to review > this commit in SILGenProlog.cpp before I dive back into

[swift-dev] Help needed: Removing inout shadow copy from SILGen

2016-06-08 Thread Daniel Duan via swift-dev
Hi all, I'm resuming work on removing the SILGen for the inout shadow copy. Making this change involes quite a bit of tests updates. I'd love some one to review this commit in SILGenProlog.cpp before I dive back into the deep end: https://github.com/dduan/swift/commit/e56d73c065bec7bdde7c0ffee42