Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

I feel that the SILParser crasher one is too open ended for a specific bug report. But I would suggest looking into those as well. Here are some more concrete things: https://bugs.swift.org/browse/SR-339 https://bugs.swift.org/browse/SR-340 https://bugs.swift.org/browse/SR-341 https://bugs.swift

Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

You know what, let me file some bugs. I just thought of some more. > On Dec 22, 2015, at 1:45 PM, Michael Gottesman via swift-dev > wrote: > > Here are some off the top of my head. Many are related to code quality. Tell > me what you think: > > 1. We have recently gotten some SILParser crashe

Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

Here are some off the top of my head. Many are related to code quality. Tell me what you think: 1. We have recently gotten some SILParser crashers. These need to be fixed. I looked at 1-2 of them and the ones I looked at are where we should be giving out a diagnostic but are instead just assert

Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

On Sun, Dec 13, 2015 at 4:29 PM, Michael Gottesman via swift-dev < swift-dev@swift.org> wrote: > This is a small starter project for those who are interested in working > with SIL. > > The SIL Parser currently is unable to parse switch_enum of undef. I wrote > a patch that does the work some time

Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

> On Dec 17, 2015, at 5:37 AM, Emanuel Zephir wrote: > > Okay, that works. > > I have a few questions about SR-210: > > 1) The attached patch adds support for undefined integer value-cases in the > switch_value instruction. What is the runtime meaning of this construct? > > 2) Are there any

Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

> On Dec 17, 2015, at 3:37 AM, Emanuel Zephir via swift-dev > wrote: > > Okay, that works. > > I have a few questions about SR-210: > > 1) The attached patch adds support for undefined integer value-cases in the > switch_value instruction. What is the runtime meaning of this construct? SIL

Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

Okay, that works. I have a few questions about SR-210: 1) The attached patch adds support for undefined integer value-cases in the switch_value instruction. What is the runtime meaning of this construct? 2) Are there any other SIL instructions in the select/switch family that need modifications?

Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

SGTM. If you want as you finish these, I have a list of them = ). I just filed another one: https://bugs.swift.org/browse/SR-247 Michael > On Dec 16, 2015, at 5:30 AM, Emanuel Zephir wrote: > > Unless anyone objects, I'd like to claim this. I've assigned

Re: [swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

Unless anyone objects, I'd like to claim this. I've assigned issue SR-210 to myself. --Emanuel On Sun, Dec 13, 2015 at 1:29 PM, Michael Gottesman via swift-dev < swift-dev@swift.org> wrote: > This is a small starter project for those who are interested in working > with SIL. > > The SIL Parser c

[swift-dev] [Starter Project] Teach SILParser how to parse switch_enum of undef.

This is a small starter project for those who are interested in working with SIL. The SIL Parser currently is unable to parse switch_enum of undef. I wrote a patch that does the work some time ago, but I never have had time to finish it (i.e. make sure everything works ok/write tests). I posted