Re: [swift-dev] Getting started with lib/Syntax

2017-12-11 Thread Xi Ge via swift-dev
Great to hear that! Please feel free to self-assign this task. Xi > On Dec 11, 2017, at 12:45 PM, Faiçal Tchirou wrote: > > Hi Xi, > > I would be interested in SR-6571. > > Thanks, > Faiçal >> On Mon, 11 Dec 2017 at 21:26, Xi Ge wrote: >> Hi Yurii and Faiçal, >> Currently, we are in the pro

Re: [swift-dev] Getting started with lib/Syntax

2017-12-11 Thread Xi Ge via swift-dev
Hi Yurii and Faiçal, Currently, we are in the process of extending Swift parser to generate libSyntax entities. A newly specialized libSyntax node will enable detailed client-side analysis/transformation on that node. Are you interested in helping with this (mostly compiler/parser side change)?

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

2017-11-02 Thread Xi Ge via swift-dev
It seems my tentative fix doesn't fix this issue. As Erik suggested, I've reverted the commit on master. -- Xi > On Nov 2, 2017, at 1:28 PM, Erik Eckstein wrote: > > Any update on this? > > Can you revert in the meantime if you’re not able to fix it within the next > hour? > >> On Nov 2,

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

2017-11-02 Thread Xi Ge via swift-dev
It seems to be a false positive of Asan container overflow checker. I've a PR to tentatively fix it. https://github.com/apple/swift/pull/12720 It's still testing -- Xi > On Nov 2, 2017, at 1:28 PM, Erik Eckstein wrote: > > Any update on this? >

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift ASAN - OS X (master) #526

2017-11-02 Thread Xi Ge via swift-dev
Ack, will take a look soon. Xi > On Nov 2, 2017, at 9:13 AM, Douglas Gregor wrote: > > Xi, this is failing in > > > swift::syntax::SyntaxParsingContext::ContextInfo::createFromBack(swift::syntax::SyntaxKind, > unsigned int) > > which might be related to your recent changes. > >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #1315

2017-10-27 Thread Xi Ge via swift-dev
The following builds are fine. -- Xi > On Oct 26, 2017, at 11:44 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04 [#1315] > > Build URL: > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/1315/ >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (swift 4.1) #58

2017-10-26 Thread Xi Ge via swift-dev
Another instance of Swift CI: 0. OSS - Swift Incremental RA - Ubuntu 16.04 - Long Test (master) > On Oct 26, 2017, at 5:23 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-4.1-incremental-RA-linux-ubuntu-16_04 [#58] > > Build URL: > https://ci.swift.org/job/oss-swift-4.1-incrementa

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #572

2017-10-25 Thread Xi Ge via swift-dev
Not sure why this failed, but the next build is successful. > On Oct 24, 2017, at 11:41 PM, no-re...@swift.org wrote: > > [FAILURE] swift-master-source-compat-suite [#572] > > Build URL:https://ci.swift.org/job/swift-master-source-compat-suite/572/ >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 - Long Test (master) #485

2017-10-24 Thread Xi Ge via swift-dev
Filed Swift CI: 0. OSS - Swift Incremental RA - Ubuntu 16.04 - Long Test (master) :0: error: module map file '/home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubuntu-16_04-long-test/swift-corelibs-libdispatch/dispatch/module.modulemap' not found <>:0: error: module map file '

Re: [swift-dev] [Swift CI] Build Failure: 2. Swift Source Compatibility Suite (master) #190

2017-09-08 Thread Xi Ge via swift-dev
It seems to be a bot issue. master-source-compat-suite/llvm/tools/clang/lib/CodeGen/CGObjC.cpp FATAL: command execution failed java.io.EOFException at java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2624) at java.io.ObjectInputStream$BlockDataInputStrea

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #304

2017-08-30 Thread Xi Ge via swift-dev
hmm, I’ve seen no suspicious commits. I’ll take a look if the test still fails in the next builds. Xi > On Aug 30, 2017, at 10:46 AM, Michael Ilseman wrote: > > +Xi. Any idea what could of caused this kind of failure? > > /home/buildnode/jenkins/workspace/oss-swift-incremental-RA-linux-ubu

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 16.10 (master) #1419

2017-08-04 Thread Xi Ge via swift-dev
> On Aug 4, 2017, at 10:21 AM, Bob Wilson wrote: > > Unfortunately that wasn’t good enough. Without lldb building, there was a > test failing on Linux. I tried disabling that test > (https://github.com/apple/swift/pull/11345 > ) but other things sti

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 16.10 (master) #1419

2017-08-03 Thread Xi Ge via swift-dev
Thank you, Bob! > On Aug 3, 2017, at 7:22 PM, Bob Wilson wrote: > > We’ll temporarily remove lldb from the PR testing. > >> On Aug 3, 2017, at 7:04 PM, Xi Ge mailto:xi...@apple.com>> >> wrote: >> >> Do we a radar to keep track of this? the build error seems to be blocking >> our PR testing.

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.04 (master) #3863

2017-07-07 Thread Xi Ge via swift-dev
Dave, Is this due to your change? Xi Foundation/NSRange.swift:264:40: error: '_utf16Index' is unavailable location: r.lowerBound._utf16Index - target.startIndex._utf16Index, ^~~ Swift.String.Index:14:16: note: '_utf16Index' was obsol

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #9017

2017-03-24 Thread Xi Ge via swift-dev
This seems to be fixed in the next build. I’ve integrated the radar. Xi > On Mar 23, 2017, at 8:46 PM, Slava Pestov wrote: > > I thought this was my changes but then it cleared up on the next build. > > Xi, I filed rdar://31234811 with some information. Since > you’re the build czar can you

Re: [swift-dev] [Swift CI] Build Still Failing: OSS - Swift Package - Ubuntu 14.04 (master) #410

2017-03-21 Thread Xi Ge via swift-dev
I’ve merged a tentative fix: https://github.com/apple/swift/commit/383b0abd628fbb4d039f992a8181ebdcb6d3d4bb The bot should be happy after picking it up. Xi > On Mar 21, 2017, at 11:20 AM, Mishal Shah wrote: > >

Re: [swift-dev] [Swift CI] Build Still Failing: 1. OSS - Swift ASAN - OS X (master) #123

2017-03-07 Thread Xi Ge via swift-dev
This has been fixed in our Asan bot since: https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/125/ <https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-osx/125/> Xi > On Mar 7, 2017, at 3:20 PM, Xi Ge via swift-dev wrote: > > Yes, it is. I’m investigating now. &

Re: [swift-dev] [Swift CI] Build Still Failing: 1. OSS - Swift ASAN - OS X (master) #123

2017-03-07 Thread Xi Ge via swift-dev
Yes, it is. I’m investigating now. Xi > On Mar 7, 2017, at 3:18 PM, Douglas Gregor wrote: > > Xi, this is in the area you’ve been working on recently. > > - Doug > >> On Mar 7, 2017, at 3:11 PM, no-re...@swift.org >> wrote: >> >> New issue found! >> >> [FA

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #7480

2016-12-07 Thread Xi Ge via swift-dev
I’ll disable it for now. > On Dec 7, 2016, at 4:50 PM, Douglas Gregor wrote: > > this test is behaving nondeterministically. Can somewhat slap a “REQUIRES: > deterministic-behavior” on it? > > - Doug > >> On Dec 7, 2016, at 4:48 PM, no-re...@swift.org >> wr

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #7467

2016-12-06 Thread Xi Ge via swift-dev
It seems to be one. I’ve disabled the test for now to unblock CI. > On Dec 6, 2016, at 7:44 PM, Slava Pestov wrote: > > Maybe it’s a flaky test? We’ve had a few of those lately. Mark is working on > a systemic fix for the issue they keep exposing. > >> On Dec 6, 2016, a

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - OS X (master) #7467

2016-12-06 Thread Xi Ge via swift-dev
The newly added crash is fixed. I’ll update the validation test suite. > On Dec 6, 2016, at 12:54 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-osx [#7467] > > Build URL:https://ci.swift.org/job/oss-swift-incremental-RA-osx/7467/ >

Re: [swift-dev] [swift] master: swift-api-digester: teach the tool to keep track of ownership attributes. (4475b07)

2016-10-31 Thread Xi Ge via swift-dev
> On Oct 31, 2016, at 12:00 PM, Kenny Leung via swift-dev > wrote: > > Just curious - what is the swift-api-digester? > swift-api-digester is a test utility to detect source-breaking API changes during the evolution of a Swift-compatible module. The tool works on two phases: (1) dumping modul

Re: [swift-dev] Descriptive Protocol non-conformance errors

2016-07-06 Thread Xi Ge via swift-dev
> On Jul 6, 2016, at 8:24 PM, Douglas Gregor via swift-dev > wrote: > > >> On Jun 25, 2016, at 1:19 PM, Sean Alling via swift-dev >> wrote: >> >> Hi everyone, >> >> I’m suggesting a change to the compiler that returns an error when an object >> 'does not conform to protocol’ to nest sub-e

Re: [swift-dev] Fixit for trailing closures

2016-07-06 Thread Xi Ge via swift-dev
>>> >>>> >>>> On Jul 5, 2016, at 17:19, Ben Langmuir via swift-dev >>> <mailto:swift-dev@swift.org>> wrote: >>>> >>>>> >>>>> On Jul 5, 2016, at 4:34 PM, Xi Ge via swift-dev >>>> <mailto:swif

Re: [swift-dev] Fixit for trailing closures

2016-07-05 Thread Xi Ge via swift-dev
> On Jul 5, 2016, at 8:31 PM, Jordan Rose wrote: > >> >> On Jul 5, 2016, at 17:19, Ben Langmuir via swift-dev > <mailto:swift-dev@swift.org>> wrote: >> >>> >>> On Jul 5, 2016, at 4:34 PM, Xi Ge via swift-dev >> <mailto:swift-dev

Re: [swift-dev] Fixit for trailing closures

2016-07-05 Thread Xi Ge via swift-dev
> On Jul 5, 2016, at 5:39 PM, Xi Ge via swift-dev wrote: > > > > > > >> On Jul 5, 2016, at 5:19 PM, Ben Langmuir > <mailto:blangm...@apple.com>> wrote: >> >>> >>> On Jul 5, 2016, at 4:34 PM, Xi Ge via swift-dev >> &l

Re: [swift-dev] Fixit for trailing closures

2016-07-05 Thread Xi Ge via swift-dev
> On Jul 5, 2016, at 5:19 PM, Ben Langmuir wrote: > >> >> On Jul 5, 2016, at 4:34 PM, Xi Ge via swift-dev > <mailto:swift-dev@swift.org>> wrote: >> >> Hi Swift-devs, >> I have tried to add a fixit to help developers using trailing closures m

[swift-dev] Fixit for trailing closures

2016-07-05 Thread Xi Ge via swift-dev
Hi Swift-devs, I have tried to add a fixit to help developers using trailing closures more, motivated by my observation during WWDC that some developers do not even realize that we have such a feature. In my opinion, trailing closures are more concise, and once you get used to it, more readable;

Re: [swift-dev] C Macros and Variadic functions

2016-01-05 Thread Xi Ge via swift-dev
> On Jan 5, 2016, at 11:54 AM, Ryan Lovelett via swift-dev > wrote: > > I'm beginning to try to port some of my existing C code over to Swift > (you have no idea how excited that makes me). Unfortunately, I've hit a > stumbling block. > > When interacting with some of the system/hardware inter