Re: [swift-dev] Build failing with error: Swift does not support the SDK 'MacOSX10.12.sdk'

Oh, maybe I should do a clean build… :-) On Fri, Jun 16, 2017 at 11:07 PM, Pavol Vaskovic wrote: > Hello, > > I guess this has something to do with the recent updates to build > requirements. > > I have downloaded Xcode 9 beta, and used xcode-select to use that version > from command line. What

[swift-dev] Build failing with error: Swift does not support the SDK 'MacOSX10.12.sdk'

Hello, I guess this has something to do with the recent updates to build requirements. I have downloaded Xcode 9 beta, and used xcode-select to use that version from command line. What else do I need to do to make Swift build again on Sierra with Xcode 9 beta? Best regards Pavol Vaskovic ___

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

On Tue, Jun 13, 2017 at 8:51 AM, Andrew Trick wrote: > I’m confused though because I thought we agreed that all samples need to > run with exactly the same number of iterations. So, there would be one > short run to find the desired `num_iters` for each benchmark, then each > subsequent invocatio

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

As the next two paragraphs after the part you quoted go on explaining, I'm hoping that with this approach we could adaptively sample the benchmark until we get stable population, but starting from lower iteration count. If the Python implementation bears this out, the proper solution would be to c

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

On Tue, Jun 13, 2017 at 2:31 AM, Michael Gottesman wrote: > > I don't think we can get more consistent test results just from re-running > tests that were detected as changes in the first pass, as described in > SR-4669 , because that improves > accuracy only

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

Hi Andrew, I wrote the draft of this e-mail few weeks ago, and the following sentence is not true: > > Its emitted when the new MIN falls inside the (MIN..MAX) range of the OLD > baseline. It is not checked the other way around. > See below... On Tue, Jun 13, 2017 at 1:45 AM, Pavol Vaskovic wrot

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

On Mon, Jun 12, 2017 at 11:55 PM, Michael Gottesman wrote: > > The current design assumes that in such cases, the workload will be > increased so that is not an issue. > I understand. But clearly some part of our process is failing, because there are multiple benchmarks in 10ms range in the tree

Re: [swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

Hi Andrew, On Mon, Jun 12, 2017 at 11:55 PM, Andrew Trick wrote: > To partially address this issue (I'm guessing) the last SPEEDUP column > sometimes features mysterious question mark in brackets. Its emitted when > the new MIN falls inside the (MIN..MAX) range of the OLD baseline. It is > not c

[swift-dev] Measuring MEAN Performance (was: Questions about Swift-CI)

On Tue, May 16, 2017 at 9:10 PM, Dave Abrahams via swift-dev < swift-dev@swift.org> wrote: > > on Thu May 11 2017, Pavol Vaskovic wrote: > > I have run Benchmark_O with --num-iters=100 on my machine for the the >> whole performance test suite, to get a feeling for the distribution of >> benchmark

Re: [swift-dev] Dependencies on Benchmark_O(& co.) --verbose format

On Mon, May 15, 2017 at 7:48 PM, Andrew Trick wrote: > The compare_perf_tests.py script parses that output. > I am aware of that one. But my question is specifically about the `--verbose` output. AFAIK compare_perf_tests.py parses results of normal mode and can't handle --verbose. --Pavol _

[swift-dev] Dependencies on Benchmark_O(& co.) --verbose format

Hello, I’m working of fixes to SR-4780 "Can not run performance tests that are not in precommit suite” and SR-4669 "Add a Benchmark_Driver --rerun N option” . It would make my work easier if I could slightly modify t

[swift-dev] Questions about Swift-CI

Hi Mishal, Douglas Gregor suggested in SR-4814 (that was merged as dupe into SR-4669) that I get in contact with you because I’m working on issue SR-4669 Add a Benchmark_Driver --rerun N option and I should make sure that I don’t break the Swift-CI. The

[swift-dev] PR review process

Hello! What is the process for getting a PR reviewed and merged into Swift? My experience so far is inconsistent. Sometimes I get a response in a few hours, discussion starts and I know I'm not wasting effort. At the moment I have 2 PRs open. One for 8 days without response. I understand that App

Re: [swift-dev] Mysterious memory improvement and regression

Greg! Thanks for the explanation and sorry for the report. I’m putting the attachment to dropbox, to work around the mailing list size cap. > On 25 Apr 2017, at 08:36, Greg Parker (mailto:gpar...@apple.com)> wrote: > > > On Apr 24, 2017, at 8:52 PM, Pavol Vaskovic > (mailto:p...@pali.sk)>

Re: [swift-dev] Mysterious memory improvement and regression

> On 25 Apr 2017, at 01:28, Greg Parker wrote: > > The value of MAX_RSS depends on OS behavior. Other activity on the same > machine may change MAX_RSS of the benchmark. Can you please describe the mechanism of how “other activity on the same machine may change MAX_RSS of the benchmark”.? >

Re: [swift-dev] Mysterious memory improvement and regression

On Fri, Apr 21, 2017 at 7:55 PM, Michael Gottesman wrote: > > I can't think of anything. But what I can say is that this makes me want > to track MAX_RSS over time ; ). > SR-4591 Performance monitoring: History of benchmark results https://bugs.swift.org/browse/SR-4591 _

[swift-dev] Mysterious memory improvement and regression

Hi swift-dev! I was working over the Easter holiday weekend on script that reports the benchmark results comparison. I wasn’t always up-to-date with the master, but I have noticed a mysterious change in MAX_RSS value reported from benchmarks. The change went away again in later builds. For e

Re: [swift-dev] Implementation of Existential Collection (AnySequence and co.)

Jordan Rose says in the comment on SR-4499 that Dmitri no longer works on Swift. Who owns that part of code now? Also, who is able to answer my original questions from this thread? --Pavol On Wed, 5 Apr 2017 at 18:56, Pavol Vaskovic wrote: > On Wednesday, 5 April 2017 at 16:04, rintaro ishizak

Re: [swift-dev] Using gyb with benchmarks

On Thursday, 6 April 2017 at 19:44, Michael Gottesman wrote: > > On Apr 6, 2017, at 6:16 AM, Pavol Vaskovic via swift-dev > > mailto:swift-dev@swift.org)> wrote: > > > > ... > > How do I make benchmarks work with gyb? > Upon further inspection, one

[swift-dev] Using gyb with benchmarks

Hi! I’ve been trying to use gyb to simplify maintenance of some tests in benchmark/single-source/. I have created DropLast.swift.gyb, but it appears this approach is currently not supported by the build system. Doing a clean build I got the following error: > + /usr/local/bin/cmake --build

Re: [swift-dev] Implementation of Existential Collection (AnySequence and co.)

On Wednesday, 5 April 2017 at 16:04, rintaro ishizaki wrote: > Just FYI > > Implementation of Type Erasers > https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20160905/002852.html Thanks for that link! This looks like a followup to Chris’s question, so I’m pinging Dmitri to chime in on

Re: [swift-dev] Implementation of Existential Collection (AnySequence and co.)

On Wednesday, 5 April 2017 at 14:56, Pavol Vaskovic wrote: > Thanks Ole! This explanation of type erasure makes total sense. I have > overlooked they are generic over different axis. > > But I think I have confirmed the performance implications of this design and > created https://bugs.swift.or

Re: [swift-dev] Implementation of Existential Collection (AnySequence and co.)

On Wednesday, 5 April 2017 at 11:59, Ole Begemann wrote: > On 05.04.2017 00:33, Pavol Vaskovic via swift-dev wrote: > > ## Abstract Base Class with Single Concrete Implementation > > > > What is the purpose of having an internal abstract base `class > > _AnyIterator

[swift-dev] Implementation of Existential Collection (AnySequence and co.)

Hello, I’ve been familiarizing myself with the implementation details of the `AnySequence` and related types, because I’ve encountered strange performance behavior when using them. I have a few questions as a result. I might also hold incorrect assumptions about how Swift works, so please be

Re: [swift-dev] How to create my first pull request

Thanks Max! That was very enlightening. One more question… > On 29 Mar 2017, at 19:57, Max Moiseev wrote: > > [...] > cd swift > git checkout master > utils/update-checkout --scheme=master > git checkout -b my-new-branch > ... some work gets done … > git add . > git commit -m “Adding an absolute

Re: [swift-dev] How to create my first pull request

Hi Max! > On 28 Mar 2017, at 01:19, Max Moiseev wrote: > > This tutorial looks very detailed and should answer most of your questions: > https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github Thank you for that link! But I'd like to hear how does that general p

[swift-dev] How to create my first pull request

Hi! I’d like to create my first full request (as requested by Jordan Rose in SR-4373 ), but I didn’t find enough information about how to proceed on the Swift’s Contributing page, nor during my googling. I am not very familiar with git/github outside of brow

[swift-dev] Running benchmark in release mode

Hi, I’m trying to run the benchmarks for swift-source on my machine. > ./swift/utils/build-script --benchmark works, but takes ages. So I was trying to run the benchmark in release mode: > ./swift/utils/build-script -R -B this fails with the last command being: > /Users/mondo/Developer/swif