Re: [swift-dev] String comparison improvements

2018-01-17 Thread Itai Ferber via swift-dev
Hi Lance (and Michael — I’ll keep the conversation in one thread), Sounds reasonable. My one concern is that behavior around implicitly bridged strings is going to change, in a potentially problematic and "magic" way: ```swift let s1: String = … let s2: String = … let mySet = NSMutableSet()

Re: [swift-dev] String comparison improvements

2018-01-17 Thread Itai Ferber via swift-dev
Hi Lance, I read Michael’s emails but I don’t remember at the moment — what is the new string comparison implementation going to be based on? Also, how will this affect bridged strings? If I compare two `NSString`s, I may get a different result than if I compare the same two strings as bridged

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (master) #1021

2018-01-11 Thread Itai Ferber via swift-dev
Thanks! :) On 11 Jan 2018, at 14:52, Slava Pestov wrote: That test failure is my fault. Sorry about that, I’ll fix it shortly. In the mean time you can do a smoke test instead of a full test and it won’t run i386 tests. Slava On Jan 11, 2018, at 2:51 PM, Itai Ferber wrote: Hi Doug, Slava

Re: [swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (master) #1021

2018-01-11 Thread Itai Ferber via swift-dev
Hi Doug, Slava, Looks like this is still an issue — just hit this on https://github.com/apple/swift/pull/13879 Does this failure look familiar to either of you? — Itai On 11 Jan 2018, at 7:12, swift-ci--- via swift-dev wrote: ## # [FAILURE] oss-swift-package-osx [#1021] Build URL: |

Re: [swift-dev] Conditional conformance: Removing the opt-in flag

2018-01-02 Thread Itai Ferber via swift-dev
On 27 Dec 2017, at 12:41, Douglas Gregor via swift-dev wrote: Sent from my iPhone On Dec 27, 2017, at 11:05 AM, Karl Wagner wrote: On 22. Dec 2017, at 07:13, Ted Kremenek via swift-dev wrote: On Dec 19, 2017, at 9:39 PM, Ted Kremenek via swift-dev wrote: On Dec 19, 2017, at 8