Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

> On Jan 2, 2018, at 7:00 PM, Joe Groff wrote: > > > >> On Dec 30, 2017, at 11:23 AM, Michael Gottesman via swift-dev >> wrote: >> >> No. A parameter's convention is ABI. You don't want to change ABI related >> things like that via escape analysis since it means that as a function >> cha

Re: [swift-dev] Make offset index available for String

Swift used to do this, but we switched it around so indexes couldn’t self-increment. One of the problems was that strings are value-types. So you would get an index, then append stuff to the string, but when you tried to advance the index again it would blow up. The index retained the backing,

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

> On Dec 30, 2017, at 11:23 AM, Michael Gottesman via swift-dev > wrote: > > No. A parameter's convention is ABI. You don't want to change ABI related > things like that via escape analysis since it means that as a function > changes, due to the optimizer, the ABI can change =><=. *BUT* rece

Re: [swift-dev] Conditional conformance: Removing the opt-in flag

> On Dec 27, 2017, at 11:05 AM, Karl Wagner via swift-dev > wrote: > > > >> On 22. Dec 2017, at 07:13, Ted Kremenek via swift-dev > > wrote: >> >> >> >>> On Dec 19, 2017, at 9:39 PM, Ted Kremenek via swift-dev >>> mailto:swift-dev@swift.org>> wrote: >>> >>>

Re: [swift-dev] Conditional conformance: Removing the opt-in flag

> On Jan 2, 2018, at 11:29, Douglas Gregor via swift-dev > wrote: > >> Just to be clear, what is the current impact of leaving those Codable >> conformances conditional? Having casts like [1,2,3] as? Codable fail? >> > Right. Those casts, which would have succeeded in Swift 4, will fail (wit

Re: [swift-dev] "available externally" vs build time

> On Dec 28, 2017, at 4:32 PM, Chris Lattner via swift-dev > wrote: > > Folks working on the SIL optimizer, particularly those interested in faster > builds: > > If I understand the SIL optimizer correctly, it seems that when the current > program references an external symbol declared as @

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #2156

Test Case 'TestURLSession.test_simpleUploadWithDelegate' started at 2018-01-02 20:42:08.856 <>TestFoundation/TestURLSession.swift:776: error: TestURLSession.test_simpleUploadWithDelegate : XCTAssertEqual failed: ("0") is not equal to ("16384") - Test Case 'TestURLSession.test_simpleUploadWithD

Re: [swift-dev] [swift-lldb-dev] Switching swift to C++14

On Wed, Dec 20, 2017 at 4:26 PM, Ted Kremenek wrote: > > On Dec 19, 2017, 8:33 PM -0800, Ted Kremenek via swift-dev < > swift-dev@swift.org>, wrote: > > > > On Dec 19, 2017, at 5:08 PM, Saleem Abdulrasool > wrote: > > > > On Dec 19, 2017, at 3:59 PM, Ted Kremenek wrote: > > > > On Dec 19, 2017,

Re: [swift-dev] Conditional conformance: Removing the opt-in flag

> On Jan 2, 2018, at 11:14 AM, Itai Ferber wrote: > > On 27 Dec 2017, at 12:41, Douglas Gregor via swift-dev wrote: > > > > Sent from my iPhone > > On Dec 27, 2017, at 11:05 AM, Karl Wagner > wrote: > >> >> >>> On 22. Dec 2017, at 07:13, Ted Kremenek via swift

Re: [swift-dev] Conditional conformance: Removing the opt-in flag

On 27 Dec 2017, at 12:41, Douglas Gregor via swift-dev wrote: Sent from my iPhone On Dec 27, 2017, at 11:05 AM, Karl Wagner wrote: On 22. Dec 2017, at 07:13, Ted Kremenek via swift-dev wrote: On Dec 19, 2017, at 9:39 PM, Ted Kremenek via swift-dev wrote: On Dec 19, 2017, at 8

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #156

Hi Andy, https://github.com/apple/swift/pull/13669 should fix it. Thanks, — Francis > On 2 Jan 2018, at 11:11, Andrew Trick wrote: > > Hi Francis, > > That PR is on the 4.1 branch. I can’t merge it either. > The failure below is on master though.

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

> Le 29 déc. 2017 à 20:50, Michael Gottesman a écrit : > > No worries. Happy to help = ). If you are interested, I would be happy to > help guide you in implementing one of these optimizations. That sounds fun. I'll have to check with my manager after the holidays. > The main downside is that

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

Thanks Michael! Other people might have different opinions, but knowing that a "definitive" fix is on the way is plenty for me and I'm not looking to make a fuss. If you still have some time, I have another question or two. You said that only self is passed at +0. Does this mean, for instance,

Re: [swift-dev] [arc optimization] Why doesn't enum destructuring use guaranteed references?

> Le 30 déc. 2017 à 14:22, Michael Gottesman a écrit : >> That sounds fun. I'll have to check with my manager after the holidays. > > Nerd snipe success? = p I guess so? 🤓 I'm an easy target. >> It sounds like having flexible parameter ownership rules doesn't have too >> much overhead if it c

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #2101

Me neither. It seems it fixed itself somehow (https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/2102/), maybe Slava's fix helped(?) On 12/21/17 6:03 PM, Chris Lattner wrote: This isn’t related to my patch.  Artem? -Chris On Dec 21, 2017, at 5:18 PM, swift...@swift.org

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (master) #971

Title: Report [FAILURE] oss-swift-package-osx [#971] Build URL:https://ci.swift.org/job/oss-swift-package-osx/971/ Project:oss-swift-package-osx Date of build:Tue, 02 Jan 2018 04:57:26 -0600 Build duration:34 min Identified problems:Compile Error: This build failed becaus

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - OS X (swift 4.1) #464

Title: Report [FAILURE] oss-swift-4.1-package-osx [#464] Build URL:https://ci.swift.org/job/oss-swift-4.1-package-osx/464/ Project:oss-swift-4.1-package-osx Date of build:Tue, 02 Jan 2018 04:59:43 -0600 Build duration:32 min Identified problems:Compile Error: This build f

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #156

Hi Francis, That PR is on the 4.1 branch. I can’t merge it either. The failure below is on master though. -Andy > On Jan 2, 2018, at 3:08 AM, Francis Visoiu Mistrih > wrote: > > Hi Andy, > > I have a pull request ready: https://github.com/apple/swift/pull/13668 >

Re: [swift-dev] [Swift CI] Build Failure: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #156

/Users/buildnode/jenkins/workspace/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/swift/tools/swift-ide-test/ModuleAPIDiff.cpp:243:1: error: cannot initialize return object of type 'bool' with an rvalue of type 'llvm::yaml::QuotingType' Francis, Maybe another test needs to be updated? -Andy