Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

> On Feb 8, 2017, at 12:33 AM, Slava Pestov wrote: >> On Feb 7, 2017, at 9:30 PM, Jacob Bandes-Storch > > wrote: >> >> Thanks to the magic of git blame: >> >> >> https://github.com/apple/swift/commit/f3ed7e93e142b802171bfe0dd08b88aa0d8b320b >> >>

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

2017-02-08 14:18 GMT+09:00 Jacob Bandes-Storch via swift-dev < swift-dev@swift.org>: > I don't think it would be a very big parser change to invert the > relationship. Maybe I'll try it out and put up another PR. > > On the other hand, noticed the header comment says: > > /// ...Because the captur

[swift-dev] [Swift CI] Build Still Failing: 0. OSS - LLDB Incremental - OS X (master) #5155

New issue found!Title: Report [FAILURE] oss-lldb-incremental-osx [#5155] Build URL:https://ci.swift.org/job/oss-lldb-incremental-osx/5155/ Project:oss-lldb-incremental-osx Date of build:Tue, 07 Feb 2017 19:35:18 -0800 Build duration:1 hr 59 min Identified problems:Regress

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

> On Feb 7, 2017, at 9:30 PM, Jacob Bandes-Storch wrote: > > Thanks to the magic of git blame: > > > https://github.com/apple/swift/commit/f3ed7e93e142b802171bfe0dd08b88aa0d8b320b > > > > > > Unless you thin

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

Thanks to the magic of git blame: https://github.com/apple/swift/commit/f3ed7e93e142b802171bfe0dd08b88aa0d8b320b > Unless you think there’s something to be gained, I’m not sure it’s worth it… I was going for idiot-proof-ness of the AST types. I'd never heard of CaptureListExpr before and would

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

> On Feb 8, 2017, at 12:18 AM, Jacob Bandes-Storch via swift-dev > wrote: > I don't think it would be a very big parser change to invert the > relationship. Maybe I'll try it out and put up another PR. > > On the other hand, noticed the header comment says: > > /// ...Because the capture list

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

> On Feb 7, 2017, at 9:18 PM, Jacob Bandes-Storch wrote: > > I don't think it would be a very big parser change to invert the > relationship. Maybe I'll try it out and put up another PR. Unless you think there’s something to be gained, I’m not sure it’s worth it… > > On the other hand, notic

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

I don't think it would be a very big parser change to invert the relationship. Maybe I'll try it out and put up another PR. On the other hand, noticed the header comment says: /// ...Because the capture list is evaluated outside of the closure, this /// CaptureList wraps the ClosureExpr. The dyn

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

> On Feb 7, 2017, at 9:09 PM, Jacob Bandes-Storch wrote: > > PR'd: https://github.com/apple/swift/pull/7326 > > > Although I would also ask: why is CaptureListExpr a parent of ClosureExpr and > not a child? I think it’s kind of arbitrary. You could

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

PR'd: https://github.com/apple/swift/pull/7326 Although I would also ask: why is CaptureListExpr a *parent* of ClosureExpr and not a child? Jacob On Tue, Feb 7, 2017 at 7:56 PM, Slava Pestov wrote: > > On Feb 7, 2017, at 7:30 PM, Jacob Bandes-Storch via swift-dev < > swift-dev@swift.org> wrot

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 16.04 (master) #456

Title: Report [FAILURE] oss-swift-package-linux-ubuntu-16_04 [#456] Build URL:https://ci.swift.org/job/oss-swift-package-linux-ubuntu-16_04/456/ Project:oss-swift-package-linux-ubuntu-16_04 Date of build:Tue, 07 Feb 2017 19:24:15 -0800 Build duration:1 hr 9 min Identified

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 16.10 (master) #379

Title: Report [FAILURE] oss-swift-package-linux-ubuntu-16_10 [#379] Build URL:https://ci.swift.org/job/oss-swift-package-linux-ubuntu-16_10/379/ Project:oss-swift-package-linux-ubuntu-16_10 Date of build:Tue, 07 Feb 2017 19:24:15 -0800 Build duration:58 min Identified pro

Re: [swift-dev] ArchetypeBuilder rename

It’s merged. Rename all you want, see if I care!!! > On Feb 7, 2017, at 7:46 PM, Douglas Gregor wrote: > > Go for it! I haven't even created the renaming PR and don't want to step on > toes. > > Sent from my iPhone > > On Feb 7, 2017, at 7:13 PM, Slava Pestov > wro

[swift-dev] [Swift CI] Build Failure: OSS - Swift Package - Ubuntu 14.04 (master) #224

Title: Report [FAILURE] oss-swift-package-linux-ubuntu-14_04 [#224] Build URL:https://ci.swift.org/job/oss-swift-package-linux-ubuntu-14_04/224/ Project:oss-swift-package-linux-ubuntu-14_04 Date of build:Tue, 07 Feb 2017 19:24:15 -0800 Build duration:35 min Identified pro

Re: [swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

> On Feb 7, 2017, at 7:30 PM, Jacob Bandes-Storch via swift-dev > wrote: > > I just learned about CaptureListExpr when working on some diagnostics. Is > there a particular reason that its member "closureBody" is an Expr* and not a > ClosureExpr*? There seems to be only one place it's built >

Re: [swift-dev] ArchetypeBuilder rename

Go for it! I haven't even created the renaming PR and don't want to step on toes. Sent from my iPhone > On Feb 7, 2017, at 7:13 PM, Slava Pestov wrote: > > Do you mind if I merge https://github.com/apple/swift/pull/7319 first? It’s > ready to go in. > > Slava > >> On Feb 7, 2017, at 4:59 P

[swift-dev] Why doesn't CaptureListExpr hold a ClosureExpr?

I just learned about CaptureListExpr when working on some diagnostics. Is there a particular reason that its member "closureBody" is an Expr* and not a ClosureExpr*? There seems to be only one place it's built

Re: [swift-dev] ArchetypeBuilder rename

Do you mind if I merge https://github.com/apple/swift/pull/7319 first? It’s ready to go in. Slava > On Feb 7, 2017, at 4:59 PM, Douglas Gregor via swift-dev > wrote: > > Hi all, > > The ArchetypeBuilder >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 - Long Test (master) #923

Another dupe - already fixed. DF > On Feb 7, 2017, at 5:33 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04-long-test [#923] > > Build URL: > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04-long-test/923/ > >

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 14.04 (master) #923

I fixed this in subsequent commit. David > On Feb 7, 2017, at 5:22 PM, no-re...@swift.org wrote: > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-14_04 [#923] > > Build URL: > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-14_04/923/ >

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1769

Fixed a couple more. I think that's all of them. David > On Feb 7, 2017, at 5:18 PM, no-re...@swift.org wrote: > > New issue found! > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#1769] > > Build URL: > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_10/1769/

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1768

Trivial fix - done. To github.com:apple/swift.git 86d204c..46b869e master -> master David > On Feb 7, 2017, at 5:06 PM, no-re...@swift.org wrote: > > New issue found! > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#1768] > > Build URL: > https://ci.swift.org/job/oss-swift-

[swift-dev] ArchetypeBuilder rename

Hi all, The ArchetypeBuilder class, whose primary responsibility is to validate, minimize, and canonicalize generic signatures, now has almost nothing to do with archetypes. I’d like to rename it to GenericSignat

Re: [swift-dev] [Swift CI] Build Still Failing: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1767

This is rdar://problem/30351514 . Doug G is looking into it. David > On Feb 7, 2017, at 4:49 PM, no-re...@swift.org wrote: > > New issue found! > > [FAILURE] oss-swift-incremental-RA-linux-ubuntu-16_10 [#1767] > > Build URL: > https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu

Re: [swift-dev] [Swift CI] Build Failure: 0. OSS - Swift Incremental RA - Ubuntu 16.10 (master) #1766

Let's see if this is addressed by: Commit abd39669fc2468c32d16cc163e612219e213a580 by practicalswift Re-add crasher 28680-swift-typebase-getdesugaredtype Now with "// REQUIRES: deterministic-behavior" > On Feb 7, 2017, at 4:45 PM, no-re...@swift.org wr

Re: [swift-dev] CI outage tomorrow for upgrade

Upgrade completed. Thanks, Mishal Shah > On Feb 7, 2017, at 12:55 PM, mishal_shah wrote: > > I am currently updating Xcode, please do not trigger PR testing until after I > am done. > > Thanks, > Mishal Shah >> On Feb 6, 2017, at 4:15 PM, Nicole Jacque via swift-dev >

Re: [swift-dev] CI outage tomorrow for upgrade

I am currently updating Xcode, please do not trigger PR testing until after I am done. Thanks, Mishal Shah > On Feb 6, 2017, at 4:15 PM, Nicole Jacque via swift-dev > wrote: > > Hi All- > > We will have a CI outage for a couple of hours tomorrow starting at 11 > Pacific, in order to upgrad

Re: [swift-dev] No return functions and program exit

> On Feb 7, 2017, at 11:56 AM, Andrew Trick wrote: > >> >> On Feb 6, 2017, at 12:19 PM, Michael Gottesman via swift-dev >> mailto:swift-dev@swift.org>> wrote: >> >> >>> On Feb 6, 2017, at 11:44 AM, Jordan Rose >> > wrote: >>> >>> On Feb 6, 2017, at 11:25,

Re: [swift-dev] No return functions and program exit

> On Feb 6, 2017, at 12:19 PM, Michael Gottesman via swift-dev > wrote: > > >> On Feb 6, 2017, at 11:44 AM, Jordan Rose > > wrote: >> >> >>> On Feb 6, 2017, at 11:25, Joe Groff via swift-dev >> > wrote: >>> >>> On Feb 6, 2017,

[swift-dev] [Swift CI] Build Still Failing: 1. OSS - Swift (Tools Opt+Assert, Stdlib Opt+DebInfo+Assert, Resilience) - macOS (master) #103

New issue found!Title: Report [FAILURE] oss-swift_tools-RA_stdlib-RDA_test-macos-resilience [#103] Build URL:https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-macos-resilience/103/ Project:oss-swift_tools-RA_stdlib-RDA_test-macos-resilience Date of build:Tue, 07 Feb

Re: [swift-dev] No return functions and program exit

> On Feb 6, 2017, at 9:48 AM, Michael Gottesman via swift-dev > wrote: > > One thing that is an issue that has come up with ownership is that at the SIL > level we do not distinguish in between exceptional noreturn functions and > exceptional return functions. > > This is important since in