[swift-corelibs-dev] CoreFoundation,SwiftFoundation does compile but not TestFoundation …

2017-12-18 Thread Benoit Pereira da silva via swift-corelibs-dev
Dear Core libs Dev. I ve found a serious bug on JSONSerialization https://bugs.swift.org/browse/SR-6631 I'm trying to build the swift-corelibs-foundation to try to validate a fix. And i m not able to build the master branch & run the tests. CoreFoundation,SwiftFoundation does compile but not Tes

Re: [swift-corelibs-dev] CoreFoundation,SwiftFoundation does compile but not TestFoundation …

2017-12-18 Thread Ian Partridge via swift-corelibs-dev
Hi Benoit, I guess you are trying to build on macOS? Have you checked out swift-corelibs-xctest alongside swift-corelibs-foundation? There are instructions here: https://github.com/apple/swift-corelibs-foundation/blob/master/Docs/GettingStarted.md#on-os-x Thanks, Ian On 18 December 2017 at 14:

[swift-corelibs-dev] Strange behavior the same code fails when building a Cocoa CLI and succeeds in Swift-corelibs-foundation context.

2017-12-18 Thread Benoit Pereira da silva via swift-corelibs-dev
Dear All, I do encounter a very strange Issue. I have been adding a test to `swift-corelibs-foundation/testJSONSerialization.swift` This test succeed within swift-corelibs-foundation test, but fails when repackaged to a Cocoa CLI app. The swift-corelibs-foundation test : func test_ser

Re: [swift-corelibs-dev] Strange behavior the same code fails when building a Cocoa CLI and succeeds in Swift-corelibs-foundation context.

2017-12-18 Thread Philippe Hausler via swift-corelibs-dev
Good find, You can make a pull request and we can get our continuous integration servers to start building that and testing your change – that is probably the easiest way to get validation on your tests and changes. There are a few issues however with your test that might be worth considering.

Re: [swift-corelibs-dev] Strange behavior the same code fails when building a Cocoa CLI and succeeds in Swift-corelibs-foundation context.

2017-12-18 Thread Benoit Pereira da silva via swift-corelibs-dev
Thanks Philippe, > Good find, > You can make a pull request and we can get our continuous integration servers > to start building that and testing your change – that is probably the easiest > way to get validation on your tests and changes. > There are a few issues however with your test that

Re: [swift-corelibs-dev] Strange behavior the same code fails when building a Cocoa CLI and succeeds in Swift-corelibs-foundation context.

2017-12-18 Thread Philippe Hausler via swift-corelibs-dev
> On Dec 18, 2017, at 9:29 AM, Benoit Pereira da silva wrote: > > Thanks Philippe, > > >> Good find, >> You can make a pull request and we can get our continuous integration >> servers to start building that and testing your change – that is probably >> the easiest way to get validation on

Re: [swift-corelibs-dev] I ve found a serious Bug in JSONEncoder (SR-6131) and would like to fix it.

2017-12-18 Thread Jordan Rose via swift-corelibs-dev
(moving to more relevant list) > On Dec 18, 2017, at 08:51, Benoit Pereira da silva via swift-users > wrote: > > Dear all > > I've found a serious Bug in JSONEncoder SR-6131 > and would like to fix it. > This bug cause JSON encoding issues on Double whe

Re: [swift-corelibs-dev] Strange behavior the same code fails when building a Cocoa CLI and succeeds in Swift-corelibs-foundation context.

2017-12-18 Thread Benoit Pereira da silva via swift-corelibs-dev
>> But i do think that it triggers a serious question: Should all your tests >> be ran on all the available locales? >> You will certainly find a smarter solution … > > I think it is sensible to iterate through a key list of known locales that > have certain characteristics, such as using th