Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-23 Thread Philippe Hausler via swift-corelibs-dev
Just because it was super-easy for me to fix: https://github.com/apple/swift-corelibs-foundation/pull/587 That should allow C++ to be built if desired into CoreFoundation. However round tripping that into the Darwin version of CoreFoundation may be a bit cagey. > On Aug 23, 2016, at 4:53 PM, He

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-23 Thread Henry Betts via swift-corelibs-dev
> On 23 Aug 2016, at 16:58, Philippe Hausler wrote: > > Is there a specific version of ICU that we need to pick that functionality > up? As it stands we don’t have a upper version limit on ICU but if we had a > portion of the ICU source in CF it would probably mean that we would get > symboli

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-23 Thread Philippe Hausler via swift-corelibs-dev
+Daphne since she was the one who implemented the Darwin version of the unit and measurements and I think she has some ideas on how we could perhaps build a uniform version for Linux hosts. Per the C++; the script for that phase probably needs a bit of love since we haven’t had a need for C++ t

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-22 Thread Will Stanton via swift-corelibs-dev
I recall the time formatter being deprecated in favor of measfmt, so you might be right that uatimeunitformat isn't needed. I think some functions in uatimeunitformat.cpp made combining units easier when calling from (then NS)DateComponentsFormatter, but perhaps that can be put functionality in

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-22 Thread Henry Betts via swift-corelibs-dev
> On 22 Aug 2016, at 19:07, Will Stanton via swift-corelibs-dev > mailto:swift-corelibs-dev@swift.org>> wrote: > > Since MeasureFormat ‘and friends’ are C++, for now, I also think the best > path would be a C wrapper in CF that can pass things off to Apple’s ICU or on > Linux to: > http://open

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-22 Thread Will Stanton via swift-corelibs-dev
I think there is a review related to format APIs ongoing for ICU 58, but there hasn’t been much talk about the C APIs alas: https://sourceforge.net/p/icu/mailman/message/35283778/ http://bugs.icu-project.org/trac/ticket/12029 Since MeasureFormat ‘and friends’ are C++, for now, I also think the b

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-22 Thread Chris Lattner via swift-corelibs-dev
On Aug 22, 2016, at 10:10 AM, Tony Parker via swift-corelibs-dev wrote: >> Looking for any thoughts and suggestions before I begin implementing this. >> >> Henry >> > > This approach makes sense - we have been putting stub functions into CF to > use ICU, because ICU’s headers are not module-f

Re: [swift-corelibs-dev] Measurement Formatters & ICU

2016-08-22 Thread Tony Parker via swift-corelibs-dev
Hi Henry, > On Aug 22, 2016, at 7:00 AM, Henry Betts via swift-corelibs-dev > wrote: > > Hi, > > I am new to the mailing list, and am interested in contributing to the swift > project. Welcome! > > I’ve been having a play with the ICU library’s unit formatting functions, and > have creat

[swift-corelibs-dev] Measurement Formatters & ICU

2016-08-22 Thread Henry Betts via swift-corelibs-dev
Hi, I am new to the mailing list, and am interested in contributing to the swift project. I’ve been having a play with the ICU library’s unit formatting functions, and have created a simple wrapper that could be used by the various measurement formatters as well as the date component formatte