Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-26 Thread Michael Gottesman via swift-corelibs-dev
Well in that case, isn't the obvious answer to move the libdispatch linux overlay into the swift? Michael > On Sep 26, 2016, at 1:23 PM, Jordan Rose via swift-dev > wrote: > > The problem with moving the Darwin Dispatch overlay there is that other > overlays depend on Dispatch, and we’re not

Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-26 Thread Jordan Rose via swift-corelibs-dev
The problem with moving the Darwin Dispatch overlay there is that other overlays depend on Dispatch, and we’re not ready to move those out somewhere else. That would compound this cross-repo dependency problem. Jordan > On Sep 26, 2016, at 12:32, Daniel A. Steffen wrote: > > this may be an u

Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-26 Thread Daniel A. Steffen via swift-corelibs-dev
this may be an unintended consequence of us putting the Linux overlay into the library repo (as opposed to the compiler repo). I still think that is the right place for the overlay to live though, and that we should move the Darwin overlay there as well medium term (and work out any resulting b

Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-26 Thread Brian Croom via swift-corelibs-dev
When I was working this summer on getting SourceKit to build on Linux, one challenge I encountered with getting the build to work cleanly was that SourceKit is in the Swift repo, but it has a dependency on libdispatch. Moving the dispatch overlay code such that libdispatch could always be built bef

Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-26 Thread David P Grove via swift-corelibs-dev
We think that the libdispatch incremental rebuilds didn't know that if swiftc changed it needed to invalidate the compilation of the swift dispatch overlay files (missing dependency in the make rule). A localized change that could be enough to fix the problem is libdispatch PR #178. If that isn'

Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-26 Thread Jordan Rose via swift-corelibs-dev
Oh, I didn’t realize we had a separate copy of the overlay code (almost certainly the right thing to do at this point). But in that case, why are we seeing any of these errors? Jordan > On Sep 25, 2016, at 11:38, David P Grove wrote: > > The order may need to vary by platform. On Linux, the D

Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-26 Thread Michael Gottesman via swift-corelibs-dev
> On Sep 25, 2016, at 11:38 AM, David P Grove via swift-dev > wrote: > > The order may need to vary by platform. On Linux, the DIspatch Swift overlay > code lives in swift-corelibs-libdispatch/src/swift. So it works to build (1) > Swift (2) libdispatch (both C and Swift) (3) Foundation. > Q

Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-25 Thread David P Grove via swift-corelibs-dev
The order may need to vary by platform. On Linux, the DIspatch Swift overlay code lives in swift-corelibs-libdispatch/src/swift. So it works to build (1) Swift (2) libdispatch (both C and Swift) (3) Foundation. --dave From: Jordan Rose To: David P Grove/Watson/IBM@IBMUS Cc: "Daniel

Re: [swift-corelibs-dev] [swift-dev] Swift CI PR builder dispatch linux failure

2016-09-23 Thread Jordan Rose via swift-corelibs-dev
I think the right order to build things is: 1. libdispatch (C) 2. Swift (compiler + stdlib + Dispatch overlay) 3. Foundation Otherwise we need to build Swift, then build libdispatch, then go back to "Swift" to build the overlay, and only finally get to Foundation. Jordan > On Sep 23, 2016, at