Re: [swift-corelibs-dev] URLSession tests

2016-09-17 Thread Mike Ferenduros via swift-corelibs-dev
Ah yep, I was wondering about relying on external services... will take a look. SR 2675-2682 filed, will see if any of them are easy fixes (probably at least a few are just curl options) On Sat, 17 Sep 2016 at 18:05 Pushkar N Kulkarni wrote: > Hi Mike, > > The tests look great and exhaustive to

Re: [swift-corelibs-dev] URLSession tests

2016-09-17 Thread Pushkar N Kulkarni via swift-corelibs-dev
Hi Mike, The tests look great and exhaustive to me. I just wish to mention here that we've experienced hangs in CI tests while connecting to some external URLs in the past (you can see a few tests commented out in the current TestNSURLSession for that reason).  It was then recommended, by Tony, tha

[swift-corelibs-dev] URLSession tests

2016-09-17 Thread Mike Ferenduros via swift-corelibs-dev
Hello! I was looking for a way to contribute, and I ran into a URLSession issue, so I started fleshing out the test module for it: https://github.com/mike-ferenduros/swift-corelibs-foundation/blob/more-urlsession-tests/TestFoundation/TestNSURLSession.swift It doesn't cover all of the API yet, but