Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Luke Howard via swift-corelibs-dev
https://github.com/lhoward/swift-corelibs-foundation/commit/49164ea312f0515c8a743d9cb322a78e513085f5 — Luke ___ swift-corelibs-dev mailing list swift-corelibs-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Philippe Hausler via swift-corelibs-dev
It is ok on the special types; those are harder than they may seem… NSValue in Darwin has some limitations like that especially when it comes to secure coding or non standard aligned values. > On Dec 28, 2015, at 3:52 PM, Luke Howard wrote: > > NSConcreteValue is in the current nscoding branch

Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Luke Howard via swift-corelibs-dev
NSConcreteValue is in the current nscoding branch BTW, it works for decoding (non-special types, special is todo). — Luke ___ swift-corelibs-dev mailing list swift-corelibs-dev@swift.org https://lists.swift.org/mailman/listinfo/swift-corelibs-dev

Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Luke Howard via swift-corelibs-dev
Yeah, that’s what I implemented (although I forgot the synchronized bit, ahem). I backed it out though after your earlier email. I’ll try your patch… > On 29 Dec 2015, at 10:46 AM, Philippe Hausler wrote: > >> >> On Dec 28, 2015, at 3:10 PM, Luke Howard wrote: >> >> >>> On 29 Dec 2015, at 3

Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Philippe Hausler via swift-corelibs-dev
> On Dec 28, 2015, at 3:10 PM, Luke Howard wrote: > > >> On 29 Dec 2015, at 3:01 AM, Philippe Hausler wrote: >> >> Not certain what you mean there; each NSValue is just a identity of a key in >> a dictionary to a NSConcreteValue that the methods forward to? That would >> mean that each meth

Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Luke Howard via swift-corelibs-dev
> On 29 Dec 2015, at 3:01 AM, Philippe Hausler wrote: > > Not certain what you mean there; each NSValue is just a identity of a key in > a dictionary to a NSConcreteValue that the methods forward to? That would > mean that each method call would be a dictionary lookup… that does not sound > s

Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Luke Howard via swift-corelibs-dev
> On 29 Dec 2015, at 3:01 AM, Philippe Hausler wrote: > > Not certain what you mean there; each NSValue is just a identity of a key in > a dictionary to a NSConcreteValue that the methods forward to? That would > mean that each method call would be a dictionary lookup… that does not sound > s

Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Philippe Hausler via swift-corelibs-dev
Responses inline; > On Dec 28, 2015, at 5:01 AM, Luke Howard via swift-corelibs-dev > wrote: > > >> On 27 Dec 2015, at 9:31 PM, Luke Howard via swift-corelibs-dev >> wrote: >> >> I’ve implemented but not extensively tested decodeValueOfObjCType(). Do we >> need to support NSConcreteValue?

Re: [swift-corelibs-dev] NSCoding methods

2015-12-28 Thread Luke Howard via swift-corelibs-dev
> On 27 Dec 2015, at 9:31 PM, Luke Howard via swift-corelibs-dev > wrote: > > I’ve implemented but not extensively tested decodeValueOfObjCType(). Do we > need to support NSConcreteValue? I started looking at NSConcreteValue (commit 1a9fe560) and decoding it is fine (notwithstanding implemen