Re: svn commit: r328159 - head/sys/modules

2018-01-19 Thread Peter Jeremy
ith a different compiler could completely change the behaviour. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r353640 - head/sys/kern

2019-10-23 Thread Peter Jeremy
byte value to > 16 bytes with 4 bytes of padding. When copying one of these structs the > compiler is free to copy the padding if it wishes. Are there any other structs passed from kernel to userland that include padding? -- Peter Jeremy signature.asc Description: PGP signature

svn commit: r354094 - head/sys/arm64/rockchip

2019-10-25 Thread Peter Jeremy
Author: peterj Date: Fri Oct 25 19:38:02 2019 New Revision: 354094 URL: https://svnweb.freebsd.org/changeset/base/354094 Log: Fix use of uninitialised variable. The RK805 regs array was being allocated before it's required size was known, causing the driver to use memory it didn't own. T

Re: svn commit: r351187 - head/sys/arm64/rockchip

2019-08-25 Thread Peter Jeremy
ff2300ff irq 53 on rk_pinctrl0 gpiobus2: on gpio2 gpio3: mem 0xff24-0xff2400ff irq 54 on rk_pinctrl0 gpiobus3: on gpio3 rk805_pmu0: at addr 0x30 irq 55 on iicbus0 ... I haven't dug into this further yet. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r351187 - head/sys/arm64/rockchip

2019-08-27 Thread Peter Jeremy
On 2019-Aug-27 11:56:38 +0200, Michal Meloun wrote: > > >On 25.08.2019 9:28, Peter Jeremy wrote: >> On 2019-Aug-18 09:19:33 +, Michal Meloun >> wrote: >>> Improve rk_pinctrl driver: >> >> Sorry for the late notice but this breaks my Rock64 (RK3328).

Re: svn commit: r345625 - in head: contrib/elftoolchain/readelf lib/libc lib/libthr libexec/rtld-elf sys/sys

2019-09-03 Thread Peter Jeremy
nweb.freebsd.org/changeset/base/345625 >>> >> Seems like this and the other hunk belongs to a different patch. >Indeed. It broke the build for me No, r345638 broke the build by only reverting one of the two extraneous hunks from this commit. -- Peter Jeremy signature.asc Description: PGP signature

svn commit: r346266 - head/sys/arm/conf

2019-09-03 Thread Peter Jeremy
Author: peterj Date: Tue Apr 16 09:44:46 2019 New Revision: 346266 URL: https://svnweb.freebsd.org/changeset/base/346266 Log: Specify correct Ethernet phy for RPI-B Correct a typo in the RPI-B ethernet config - the RPi-B includes a SMC LAN9512 USB bridge and Ethernet 10/100 NIC/phy. The

svn commit: r346265 - head/sys/arm/broadcom/bcm2835

2019-09-03 Thread Peter Jeremy
Author: peterj Date: Tue Apr 16 09:42:42 2019 New Revision: 346265 URL: https://svnweb.freebsd.org/changeset/base/346265 Log: Fix cpufreq(4) on RPI-B Since r324184 the root node compatible for the original Raspberry Pi is "brcm,bcm2835", add it to the compatible list of bcm2835_cpufreq.

Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline

2019-09-13 Thread Peter Jeremy
:typedef int ___wchar_t; sys/sparc64/include/_types.h:typedefint ___wchar_t; sys/x86/include/_types.h:typedefint ___wchar_t; Looking back into history, it looks like the "unsigned" is part of the ARM EABI. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r349151 - in head: lib/libufs stand/libsa sys/conf sys/dev/iscsi sys/dev/iscsi_initiator sys/dev/liquidio sys/dev/usb/net sys/fs/ext2fs sys/fs/nandfs sys/geom/part sys/geom/raid sys/ke

2019-06-22 Thread Peter Jeremy
sp = 0x00010b50 fp = 0xffff00010bb0 ... -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r349151 - in head: lib/libufs stand/libsa sys/conf sys/dev/iscsi sys/dev/iscsi_initiator sys/dev/liquidio sys/dev/usb/net sys/fs/ext2fs sys/fs/nandfs sys/geom/part sys/geom/raid sys/ke

2019-06-23 Thread Peter Jeremy
On 2019-Jun-22 17:17:03 +1000, Peter Jeremy wrote: >On 2019-Jun-17 19:49:09 +, Xin LI wrote: >>Author: delphij >>Date: Mon Jun 17 19:49:08 2019 >>New Revision: 349151 >>URL: https://svnweb.freebsd.org/changeset/base/349151 >> >>Log: >> Sepa

Re: svn commit: r362589 - in head/lib/csu: aarch64 arm i386 riscv

2020-06-25 Thread Peter Jeremy
r362580 and trying to buildworld r352310 on arm64. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r362589 - in head/lib/csu: aarch64 arm i386 riscv

2020-06-25 Thread Peter Jeremy
On 2020-Jun-26 10:25:36 +1000, Peter Jeremy wrote: >On 2020-Jun-24 17:54:25 +, John Baldwin wrote: >>Author: jhb >>Date: Wed Jun 24 17:54:24 2020 >>New Revision: 362589 >>URL: https://svnweb.freebsd.org/changeset/base/362589 >> >>Log: >> Alway

Re: svn commit: r362736 - head/sys/arm64/rockchip

2020-07-01 Thread Peter Jeremy
ect the network is dead. Normally, it runs 1000baseT . -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r362736 - head/sys/arm64/rockchip

2020-07-01 Thread Peter Jeremy
On 2020-Jul-01 18:57:47 +1000, Peter Jeremy wrote: >On 2020-Jun-28 21:11:10 +, Oleksandr Tymoshenko wrote: >>Log: >> Configure rx_delay/tx_delay values for RK3399/RK3328 GMAC >> >> For 1000Mb mode to work reliably TX/RX delays need to be configured >>

Re: svn commit: r362736 - head/sys/arm64/rockchip

2020-07-04 Thread Peter Jeremy
maybe boot and run-time configurable. It's a pity that there doesn't seem to be any documentation on what the numbers represent (or what the "default" value is) - which means that actually adjusting the delay numbers would be very time consuming. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r355487 - in head/sys: arm64/arm64 arm64/include conf

2019-12-10 Thread Peter Jeremy
read "loader_envp" instead of "static_kenv" -- as written, >it stomps over the kenv provided by loader. Which breaks diskless booting and NFS root. Changing static_kenv to loader_envp unbreaks the kernel. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r361491 - in head/sys: geom kern sys ufs/ffs ufs/ufs

2020-05-28 Thread Peter Jeremy
tions this commit adds to ffs_subr.c would be moved to a different file (though it's not immediately clear which file that would be. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r359647 - in head/sys: arm64/broadcom arm64/broadcom/brcmmdio conf dev/mdio

2020-04-07 Thread Peter Jeremy
es are only relevant to a subset of Broadcom SoCs and (IMO) should not be included merely with "options FDT", rather they should be conditional on the relevant Broadcom SoCs. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r219679 - head/sys/i386/include

2011-03-17 Thread Peter Jeremy
handled on Pentium. Another approach would be to always have cmpxchg8b instructions (followed by a suitably large NOP) always inlined in the code and if it traps, patch the code to call a function that emulates it. -- Peter Jeremy pgpSimCdanXum.pgp Description: PGP signature

Re: svn commit: r219700 - head/sys/x86/x86

2011-03-17 Thread Peter Jeremy
rdware frequencies. -- Peter Jeremy pgpeyEkoSy8te.pgp Description: PGP signature

Re: svn commit: r219700 - head/sys/x86/x86

2011-03-25 Thread Peter Jeremy
PLL can saturate at +/-500ppm and not recover. This is definitely true of the ntpd in Tru64 5.1 and (from memory) was true of ntpd in some versions of FreeBSD. -- Peter Jeremy pgpxA2RsEkndD.pgp Description: PGP signature

Re: svn commit: r206129 - head/sys/kern

2010-04-04 Thread Peter Jeremy
ick summary: db(3) has restrictions on its internal bucket size but initializes it from st_blksize with no sanity checking and ZFS can report blocksizes outside the allowed bucket size range for db(3). -- Peter Jeremy pgpXUKXHXhEFM.pgp Description: PGP signature

Re: svn commit: r206129 - head/sys/kern

2010-04-04 Thread Peter Jeremy
On 2010-Apr-05 00:27:42 +0300, Kostik Belousov wrote: >On Mon, Apr 05, 2010 at 12:11:06AM +0300, Andriy Gapon wrote: >> on 05/04/2010 00:03 Peter Jeremy said the following: >> > On 2010-Apr-03 08:39:00 +, Andriy Gapon wrote: >> >> vn_stat: take into acc

Re: svn commit: r206129 - head/sys/kern

2010-04-05 Thread Peter Jeremy
pdated bin/16 with a scenario that I believe will demonstrate the problem on FreeBSD - basically, run the db-hash.t test in perl and it should core-dump after test 21. -- Peter Jeremy pgpXwfhOJDmo8.pgp Description: PGP signature

Re: svn commit: r206814 - head/sys/vm

2010-04-20 Thread Peter Jeremy
On 2010-Apr-18 21:29:28 +, Alan Cox wrote: > Remove a nonsensical test from vm_pageout_clean(). A page can't be in the > inactive queue and have a non-zero wire count. Should this test be turned into a KASSERT()? -- Peter Jeremy pgpUBaNmfHIN6.pgp Description: PGP signature

Re: svn commit: r223637 - in head: . contrib/pf/authpf contrib/pf/ftp-proxy contrib/pf/man contrib/pf/pfctl contrib/pf/pflogd sbin/pflogd sys/conf sys/contrib/altq/altq sys/contrib/pf/net sys/modules

2011-12-13 Thread Peter Jeremy
t I've just found the following preprocessor conditionals in sys/contrib/pf/net/pfvar.h as a result of this commit (covering lines 214..282): #ifdef __FreeBSD__ ... #ifdef __FreeBSD__ ... #else ... #endif /* __FreeBSD__ */ ... #endif /* __FreeBSD__ */ Was there a mismerge here? -- Peter Jeremy

Re: svn commit: r223637 - in head: . contrib/pf/authpf contrib/pf/ftp-proxy contrib/pf/man contrib/pf/pfctl contrib/pf/pflogd sbin/pflogd sys/conf sys/contrib/altq/altq sys/contrib/pf/net sys/modules

2011-12-15 Thread Peter Jeremy
web. Is it possible that the pf code was checked out of an OpenBSD repo without the correct $OpenBSD$ tag expansion? This caused me a degree of confusion whilst trying to correlate the FreeBSD code with the OpenBSD code to try and update bin/124825 -- Peter Jeremy pgpETpzB0eUVO.pgp Description: PGP signature

Re: svn commit: r223129 - head/release

2011-06-17 Thread Peter Jeremy
t was useful for recovering hard disks -- Peter Jeremy pgpCRNIuE4pIQ.pgp Description: PGP signature

Re: svn commit: r222866 - head/sys/x86/x86

2011-06-20 Thread Peter Jeremy
s it virtually impossible to measure short periods. Luckily, AMD seem to have gotten this right. -- Peter Jeremy pgpE3vKHLWVpS.pgp Description: PGP signature

Re: svn commit: r223722 - in head/sys: kern sys

2011-07-02 Thread Peter Jeremy
tydevsw fields that aren't defined by the driver, with results that won't be pretty. -- Peter Jeremy pgp9M1Qw5KA3e.pgp Description: PGP signature

Re: svn commit: r210124 - head/sys/amd64/amd64

2010-07-16 Thread Peter Jeremy
> FFS, the reduction is 3%. I have no feeling for the cost of a TLB shootdown. What is the likely impact on buildworld on a ZFS filesystem? Barely noticable or several percent faster? -- Peter Jeremy pgpHEoJJFEwje.pgp Description: PGP signature

Re: svn commit: r210175 - head/usr.sbin/sysinstall

2010-08-17 Thread Peter Jeremy
en't used it for more than a decade. -- Peter Jeremy pgpZ37kea4Ghc.pgp Description: PGP signature

Re: svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-18 Thread Peter Jeremy
7;s guidelines require the separation of whitespace and functional changes. -- Peter Jeremy pgpGEmQhdQqnI.pgp Description: PGP signature

Re: svn commit: r212964 - head/sys/kern

2010-09-24 Thread Peter Jeremy
coredump or similar? Given /var >now defaults to 4GB, Defaulting to keeping a single core is probably >acceptable. savecore already has support for a 'minfree' file to prevent crashdumps filling the crashdir. Maybe the default install should include a minfree set to (say) 512MB.

Re: svn commit: r214489 - head/usr.sbin/bsnmpd/modules/snmp_hostres

2010-10-29 Thread Peter Jeremy
mplement > the CPU load reporting at all. I'd be very surprised if there was because (eg) HP Tru64 uses different load average times. -- Peter Jeremy pgppZGrPIN8VV.pgp Description: PGP signature

Re: svn commit: r217538 - in head/sys/dev: buslogic cs

2011-01-19 Thread Peter Jeremy
irq = cs8900_irq2eeint[irq]; > else > irq = 255; Irrespective of the signedness or otherwise of "irq", I'm fairly certain that '||' should have been '&&' before. -- Peter Jeremy pgpXUXIcy88ql.pgp Description: PGP signature

Re: svn commit: r218238 - head/sys/dev/ath

2011-02-05 Thread Peter Jeremy
t of view, the warning is useful. Also, given that the normal way of stating that is "#ifdef NOTYET", keeping the warning may help catch code where the preprocessor variable was supposed to have been defined but has been misspelt - consider "#if _FreeBSD_version > 800100". -- Peter Jeremy pgpMZbmjz1CEH.pgp Description: PGP signature

Re: svn commit: r224875 - head

2011-08-15 Thread Peter Jeremy
it somewhere but I don't see the version bump anywhere. SVN reports this commit only affects UPDATING. -- Peter Jeremy pgpARYKn6IgMs.pgp Description: PGP signature

Re: svn commit: r221233 - head/sbin/fsck_ffs

2011-08-27 Thread Peter Jeremy
ust lack of time or oversight? -- Peter Jeremy pgpgEsUmew6wj.pgp Description: PGP signature

Re: svn commit: r226046 - in head: crypto/openssh crypto/openssh/openbsd-compat secure/usr.sbin/sshd

2011-10-13 Thread Peter Jeremy
each group. Using both authorized_keys and authorized_keys2 substantially simplifies the overall key management. -- Peter Jeremy pgpAdDLGTL3l9.pgp Description: PGP signature

Re: svn commit: r227156 - head/usr.bin/cmp

2011-11-06 Thread Peter Jeremy
*); > >-extern int lflag, sflag, xflag; >+extern int lflag, sflag, xflag, zflag; That's an interesting spelling of "static". I presume this is a general cleanup of identifier visibility to prevent unexpected aliasing - in which case a more general log message may have nicer. -- Peter Jeremy pgp1NnvPnC9Bj.pgp Description: PGP signature

Re: svn commit: r227474 - head/sys/amd64/include

2011-11-13 Thread Peter Jeremy
ine SIG_ATOMIC_MIN INT64_MIN #define SIG_ATOMIC_MAX INT64_MAX -- Peter Jeremy pgp1lKweyNDep.pgp Description: PGP signature

Re: svn commit: r336025 - in head/sys: amd64/include i386/include

2018-07-08 Thread Peter Jeremy
o inlining SMP versions of atomic operations in modules is probably the correct decision now. -- Peter Jeremy signature.asc Description: PGP signature

svn commit: r336406 - head

2018-07-17 Thread Peter Jeremy
Author: peterj Date: Tue Jul 17 11:35:40 2018 New Revision: 336406 URL: https://svnweb.freebsd.org/changeset/base/336406 Log: Retrospectively document SVN branch point for stable-11 Approved by: jhb (mentor) Differential Revision:https://reviews.freebsd.org/D16262 Modified: he

Re: svn commit: r345625 - in head: contrib/elftoolchain/readelf lib/libc lib/libthr libexec/rtld-elf sys/sys

2019-03-28 Thread Peter Jeremy
nweb.freebsd.org/changeset/base/345625 >>> >> Seems like this and the other hunk belongs to a different patch. >Indeed. It broke the build for me No, r345638 broke the build by only reverting one of the two extraneous hunks from this commit. -- Peter Jeremy signature.asc Description: PGP signature

svn commit: r346265 - head/sys/arm/broadcom/bcm2835

2019-04-16 Thread Peter Jeremy
Author: peterj Date: Tue Apr 16 09:42:42 2019 New Revision: 346265 URL: https://svnweb.freebsd.org/changeset/base/346265 Log: Fix cpufreq(4) on RPI-B Since r324184 the root node compatible for the original Raspberry Pi is "brcm,bcm2835", add it to the compatible list of bcm2835_cpufreq.

svn commit: r346266 - head/sys/arm/conf

2019-04-16 Thread Peter Jeremy
Author: peterj Date: Tue Apr 16 09:44:46 2019 New Revision: 346266 URL: https://svnweb.freebsd.org/changeset/base/346266 Log: Specify correct Ethernet phy for RPI-B Correct a typo in the RPI-B ethernet config - the RPi-B includes a SMC LAN9512 USB bridge and Ethernet 10/100 NIC/phy. The

Re: svn commit: r347151 - in head: libexec/rtld-elf sys/compat/linux sys/fs/deadfs sys/fs/nfsclient sys/fs/nullfs sys/fs/unionfs sys/kern sys/sys sys/ufs/ufs sys/vm

2019-05-06 Thread Peter Jeremy
533200 lr = 0x00221420 sp = 0x56b1dba0 fp = 0xe760 KDB: enter: panic [ thread pid 1 tid 12 ] Stopped at 0x28d598: undefined 54000042 db> -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r347151 - in head: libexec/rtld-elf sys/compat/linux sys/fs/deadfs sys/fs/nfsclient sys/fs/nullfs sys/fs/unionfs sys/kern sys/sys sys/ufs/ufs sys/vm

2019-05-06 Thread Peter Jeremy
On 2019-May-06 12:09:20 +0300, Konstantin Belousov wrote: >On Mon, May 06, 2019 at 06:56:41PM +1000, Peter Jeremy wrote: >> On 2019-May-05 11:20:44 +, Konstantin Belousov wrote: >> >Log: >> > Switch to use shared vnode locks for text files during image activation

Re: svn commit: r347890 - in head/sys/dev: aac bge

2019-05-16 Thread Peter Jeremy
ommits because these devices have 64-bit issues - the commit log should document this. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r347984 - in head/sys: amd64/vmm/io arm/allwinner arm/allwinner/a10 arm/allwinner/clkng arm/arm arm/broadcom/bcm2835 arm/freescale/imx arm/mv arm/mv/armada arm/nvidia arm/nvidia/tegra1

2019-05-20 Thread Peter Jeremy
error: implicit declaration of function 'EVENTHANDLER_REGISTER' is invalid in C99 [-Werror,-Wimplicit-function-declaration] nd_detach_cookie = EVENTHANDLER_REGISTER(ifnet_departure_event, ^ -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r312910 - in head: . etc/etc.pc98 etc/rc.d lib/libsysdecode libexec release release/doc release/doc/en_US.ISO8859-1/hardware release/doc/en_US.ISO8859-1/readme release/doc/share/exampl

2017-02-01 Thread Peter Jeremy
ITH_PKGNG=yes/PKGSUFFIX=.txz. And you are doing so in the clear knowledge that what you are doing is not supported by the FreeBSD Project. -- Peter Jeremy signature.asc Description: PGP signature

svn commit: r343953 - head/lib/msun/src

2019-02-10 Thread Peter Jeremy
Author: peterj Date: Sun Feb 10 08:46:07 2019 New Revision: 343953 URL: https://svnweb.freebsd.org/changeset/base/343953 Log: Replace calls to sin(x) and cos(x) with a single call to sincos(). Replace calls to sinf(x) and cosf(x) with a single call to sincosf(). Submitted by: Steve Kargl

Re: svn commit: r344970 - head

2019-03-11 Thread Peter Jeremy
lines of: "A GENERIC kernel will include suitable compatibility options to run binaries from older branches. Note that the ability to run binaries from unsupported branches is not guaranteed." -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r251886 - in head: contrib/apr contrib/apr-util contrib/serf contrib/sqlite3 contrib/subversion share/mk usr.bin usr.bin/svn usr.bin/svn/lib usr.bin/svn/lib/libapr usr.bin/svn/lib/liba

2013-06-29 Thread Peter Jeremy
27;s a reason for not getting rid of one copy of SQLite). (I'm concerned in general at the duplication of code in base - we already have about 4 copies of gzip and 2 different IEEE floating point emulators). -- Peter Jeremy pgpHTT8c0y97Z.pgp Description: PGP signature

Re: svn commit: r262282 - in head: contrib/dma contrib/dma/debian contrib/dma/debian/migrate contrib/dma/debian/source contrib/dma/test etc/mtree libexec libexec/dma share/mk tools/build/mk tools/buil

2014-02-22 Thread Peter Jeremy
loading to also refer to a MTA is not going to end well. I'd also query the reason for including Debian-specific code in the FreeBSD base. -- Peter Jeremy pgpmzMVf62Z1f.pgp Description: PGP signature

Re: svn commit: r262282 - in head: contrib/dma contrib/dma/debian contrib/dma/debian/migrate contrib/dma/debian/source contrib/dma/test etc/mtree libexec libexec/dma share/mk tools/build/mk tools/buil

2014-02-24 Thread Peter Jeremy
On 2014-Feb-22 13:14:38 +0100, Baptiste Daroussin wrote: >On Sat, Feb 22, 2014 at 07:23:50PM +1100, Peter Jeremy wrote: >> I'd also query the reason for including Debian-specific code in the >> FreeBSD base. >Where have you seen debian specific code? /usr/src/contrib/d

svn commit: r275298 - head/share/man/man4

2014-11-29 Thread Peter Jeremy
Author: peterj Date: Sun Nov 30 04:50:13 2014 New Revision: 275298 URL: https://svnweb.freebsd.org/changeset/base/275298 Log: Cross reference tap(4) and tun(4) and include a short explanation as to how they differ. This will assist users in selecting which interface is more appropriate for

Re: svn commit: r260188 - head/sys/netinet

2014-01-02 Thread Peter Jeremy
ay). And, whilst it's _really_ late in the 10.0 release cycle, I'm not sure we want to roll a release with broken multicast. -- Peter Jeremy pgp2NmtUnk4Au.pgp Description: PGP signature

Re: svn commit: r277652 - in head/usr.sbin/pw: . tests

2015-01-25 Thread Peter Jeremy
2012 tcl-8.5.11.tbz -> >../All/tcl-8.5.11.tbz >lrwxr-xr-x 1 4294967294 wheel 29 Mar 17 2012 tcl-modules-8.5.11.tbz -> >../All/tcl-modules-8.5.11.tbz All this means is that you have some files with that uid. It's not clear how they were created. -- Peter Jeremy pgpqGPRNMM0Af.pgp Description: PGP signature

Re: svn commit: r277652 - in head/usr.sbin/pw: . tests

2015-01-25 Thread Peter Jeremy
VM do write as 'root'. root maped to >nobody. When this is created -- host 9.1, VM -- 6.x. I can reproduce this with FreeBSD 10/r276177 client and server running NFSv3 using the "new" NFS code. It appears to be due to the (broken) initialisation of def_anon in mountd(8) with '(uid_t)-2' - as noted by bde. It's nothing to do with ZFS. -- Peter Jeremy pgp5sYqdZFoIr.pgp Description: PGP signature

Re: svn commit: r279814 - head/sys/arm/conf

2015-03-10 Thread Peter Jeremy
there are a few specific modules that aren't good for arm, we should >be fixing that in the modules makefiles. For the most popular ARM SoCs, I'd suggest that about half of the modules don't make sense: There's no ISA or PCI bus available so there's no point i

Re: svn commit: r280120 - head/sys/dev/wpi

2015-03-15 Thread Peter Jeremy
On 2015-Mar-15 14:35:23 -0700, Adrian Chadd wrote: >.. promise I'm done for now. 69 commits (68 to the same file) and the perfect sequence only broken by pav@ and jilles@. I think you deserve some sort of reward. -- Peter Jeremy pgp3zSX3Ppitu.pgp Description: PGP signature

Re: svn commit: r280727 - in head: share/mk sys/conf

2015-03-28 Thread Peter Jeremy
A. As linimon pointed out, FreeBSD no longer supports Alpha. >FreeBSD support Digi EISA card. The digi(4) driver was removed from FreeBSD because it wasn't adapted for TTYng. I had some patches for PCI digi cards (see pr/152253 and pr/158086) but no longer have access to the hard

Re: svn commit: r303811 - in head/sys: net net80211

2016-08-07 Thread Peter Jeremy
st 2 accessible bytes beyond the address), the following has the added advantage of only referencing (addr) once. (I'm not suggesting it as a replacement though). #define ETHER_IS_BROADCAST(addr) \ ((*(const long *)(addr) & 0x00ffl) == 0x00ffl) -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r303716 - head/crypto/openssh

2016-08-07 Thread Peter Jeremy
talk to a server using 1024-bit DSA. Note that the handbook still talks about using DSA - that needs updating as well. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r304513 - in head: . share/man/man4/man4.i386 sys/conf sys/dev/ie sys/i386/conf sys/modules sys/modules/ie sys/pc98/conf

2016-08-21 Thread Peter Jeremy
to leave > sio(4), but the other disconnected drivers are candidates I think. I have digi(4) patches but no longer have any digi cards. Judging by the time since they were disconnected, I think they can be deleted. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r297902 - head

2016-04-13 Thread Peter Jeremy
r/local/bin/svn or /usr/bin/svnlite (in that order) but a non-standard configuration could result in different results. -- Peter Jeremy signature.asc Description: PGP signature

Re: svn commit: r284711 - head/sys/netinet

2015-06-22 Thread Peter Jeremy
d have been capitalized if it was an acronym. It's not an acronym. I've only ever seen it written as 'iff'. -- Peter Jeremy pgpwUzM9GtUbM.pgp Description: PGP signature

Re: svn commit: r285439 - head/sys/dev/random

2015-07-13 Thread Peter Jeremy
a multiple of RANDOM_BLOCKSIZE, this will pad it by an additional RANDOM_BLOCKSIZE. I don't think this matters but it's not what the comment implies. (The comment also goes over 80 columns). -- Peter Jeremy pgpVYCudlMOLy.pgp Description: PGP signature

Re: svn commit: r285644 - head/contrib/sqlite3

2015-07-17 Thread Peter Jeremy
sizeof(WalIndexHdr)); If the compiler complained about that, the compiler is broken. 'const' is a promise to the caller that the given parameter will not be modified by the callee. There's no requirement that the passed argument be const. As bde commented, the casts are all spurious. -- Peter Jeremy pgpPxoiGTYYng.pgp Description: PGP signature

Re: svn commit: r234403 - head/sys/net

2012-04-17 Thread Peter Jeremy
you which variable was NULL without needing to trawl through the crashdump to find what caused the NULL pointer dereference trap. -- Peter Jeremy pgpsXLkOs02z8.pgp Description: PGP signature

Re: svn commit: r234528 - head/lib/libc/stdio

2012-04-21 Thread Peter Jeremy
fix is to move the "wsp = ws;" outside the loop. > It's remarkable that the > patch that introduced the bug was never tested, but even more > remarkable that nobody noticed for over two years. It took me a while to work out that the problem was libc and not my code.

Re: svn commit: r233925 - in head: sys/kern sys/sys sys/vm usr.bin/kdump usr.bin/ktrace

2012-05-30 Thread Peter Jeremy
This expired some time ago, do you intend to MFC these changes in the near future? -- Peter Jeremy pgpOmnDjf6jih.pgp Description: PGP signature

svn commit: r240548 - in head: share/misc usr.bin/calendar/calendars

2012-09-15 Thread Peter Jeremy
[label="Peter Wemm\npe...@freebsd.org\n/??/??"] +peterj [label="Peter Jeremy\npet...@freebsd.org\n2012/09/14"] pfg [label="Pedro Giffuni\n...@freebsd.org\n2011/12/01"] philip [label="Philip Paeps\nphi...@freebsd.org\n2004/01/21"] phk [label="Poul-Henning K

Re: svn commit: r241221 - in head: contrib/tcpdump usr.sbin/tcpdump/tcpdump

2012-10-08 Thread Peter Jeremy
al interface like Ethernet. You might like to look at bin/124825 as well. -- Peter Jeremy pgpFEsnxzNhtD.pgp Description: PGP signature

svn commit: r241708 - head/etc

2012-10-18 Thread Peter Jeremy
Author: peterj Date: Thu Oct 18 22:20:02 2012 New Revision: 241708 URL: http://svn.freebsd.org/changeset/base/241708 Log: Explicitly specify 'np' so that getty(8) does not simulate even parity on local.9600. Whilst the actual binary termios(4) definitions and preceeding comments for local.9

Re: svn commit: r242402 - in head/sys: kern vm

2012-10-31 Thread Peter Jeremy
ory usage may override ABI compatibility in an embedded environment. >All that assuming you can actually prove a real performance loss even >in the new cases. The issue with padding on embedded systems is memory utilisation rather than performance. -- Peter Jeremy pgpX2JHZy0tEP.pgp Description: PGP signature

Re: svn commit: r242625 - in head/sys: dev/ale dev/ata dev/ata/chipsets dev/ath/ath_hal/ar5212 dev/bge dev/cas dev/dc dev/flash dev/fxp dev/gem dev/lge dev/mii dev/nge dev/pci dev/re dev/sis dev/ste d

2012-11-16 Thread Peter Jeremy
something that a maintainer is actively working on, they need to take the time to work out if the change is still relevant and whether it impacts the testing they have done. -- Peter Jeremy pgpu5eCghInCr.pgp Description: PGP signature

Re: svn commit: r242102 - in head: contrib/bmake usr.bin/bmake

2012-11-30 Thread Peter Jeremy
locate all the space in the jemalloc arenas, this dominates the runtime - in the case of /bin/echo, I measured 87 page faults with MALLOC_PRODUCTION and 2133 without. -- Peter Jeremy pgphpUgGtnqNK.pgp Description: PGP signature

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Peter Jeremy
ple.freebsd.org/~pjd/patches/savecore.patch Adding a "maxdumps" parameter seems a good idea. The behaviour when it hits the limit is less clear - throwing away the latest crashdump is probably as easy to justify as throwing away the oldest one. A further downside to enabling crashdumps is the time overhead - initially writing the dump, copying it to /var/crash and running crashinfo. This all directly increases the length of the outage. -- Peter Jeremy pgp5wkhrNBmFs.pgp Description: PGP signature

Re: svn commit: r244469 - head/sys/arm/arm

2012-12-24 Thread Peter Jeremy
rm/busdma_machdep-v6.c Do you have any plans to make similar changes to the other busdma_machdep.c files? -- Peter Jeremy pgpZzphQqYmZT.pgp Description: PGP signature

Re: svn commit: r234352 - in head/sys: amd64/linux32 compat/linux i386/linux kern

2012-06-28 Thread Peter Jeremy
you have any plans to MFC this? I've had a quick look but there are non-trivial conflicts in kern/sys_pipe.c on both 8.x & 9.x and I don't want to spend time resolving them if you have already done so. -- Peter Jeremy pgppROok72FQy.pgp Description: PGP signature

Re: svn commit: r238722 - in head/lib/msun: . ld128 ld80 man src

2012-07-25 Thread Peter Jeremy
we bump OSVERSION for this, we are probably looking at another half-dozen or so bumps. Do any ports actually have a hard-wired decision for expl() (or other libm functions)? I would hope most ports that are interested in complex and/or long double functions have some sort of configure-time test

Re: svn commit: r239077 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2012-08-06 Thread Peter Jeremy
ions of zlib (1.2.3 & 1.0.4, respectively) and the original files have been munged is different ways. (And there's a third inflate(9) based on unzip-5.12 in sys/kern/inflate.c, as well as another complete zlib-1.2.7 in lib/libz) -- Peter Jeremy pgpHOcGlx1AxP.pgp Description: PGP signature

Re: svn commit: r238536 - head/sys/vm

2012-08-09 Thread Peter Jeremy
if you intend to MFC this (and hopefully r238456) soon. I've had a quick try at merging this back to 8.x but it relies on vm_pageout_page_lock() and vm_page_unlock() which were added in r207694 and I'm not sure about the impact of merging that. -- Peter Jeremy pgpScNm7Hck6X.pgp Description: PGP signature

Re: svn commit: r239301 - in head/sys: kern nlm sys

2012-08-16 Thread Peter Jeremy
t;+"Maximum allowed pid"); I don't see anything in this code that would prevent setting max_pid to an unusably low (as in making the system unusable) or even negative value >+ TUNABLE_INT_FETCH("kern.pid_max", &pid_max); >+ if (pid_max > PID_MAX) >+ pid_max = PID_MAX; > } Likewise, this needs a lower bounds check. -- Peter Jeremy pgpjSBXtQZhiY.pgp Description: PGP signature

Re: svn commit: r252373 - head/usr.bin

2013-07-06 Thread Peter Jeremy
d_fetch_4 is supposed to be a gcc builtin so I'm not sure why it's being emitted without a definition. -- Peter Jeremy pgps0GUq2Y7ib.pgp Description: PGP signature

svn commit: r247274 - in head: bin/test tools/regression/bin/test

2013-02-25 Thread Peter Jeremy
Author: peterj Date: Mon Feb 25 19:05:40 2013 New Revision: 247274 URL: http://svnweb.freebsd.org/changeset/base/247274 Log: Enhance test(1) by adding provision to compare any combination of the access, birth, change and modify times of two files, instead of only being able to compare modify

Re: svn commit: r247274 - in head: bin/test tools/regression/bin/test

2013-02-27 Thread Peter Jeremy
ree the other sleep(1)s should be able to be replaced with touch(1) but I ran into problems with my initial efforts to do everything using touch(1). I will revisit it. -- Peter Jeremy pgpB_uIyxsx0n.pgp Description: PGP signature

Re: svn commit: r249484 - head/lib

2013-04-15 Thread Peter Jeremy
ers). I don't see why base needs to grow an ugly symlink to support a couple of ports. Surely if ports rely on an undocumented features of the toolchain, the correct solution is to fix the ports. -- Peter Jeremy pgpBX5YdK28Ts.pgp Description: PGP signature

Re: svn commit: r204309 - in head/sys: amd64/amd64 amd64/isa conf i386/bios i386/cpufreq i386/i386 i386/isa i386/xen isa modules/bios/smbios modules/bios/vpd modules/cpufreq pc98/pc98 x86 x86/bios x86

2010-02-28 Thread Peter Jeremy
at something like this is also critical for getting i386/amd64 cross compilation to work - one of the blocking issues is that the correct machine/ includes are not available in cross-compilatio mode. -- Peter Jeremy pgpbufYZ0Fc1p.pgp Description: PGP signature

Re: svn commit: r204309 - in head/sys: amd64/amd64 amd64/isa conf i386/bios i386/cpufreq i386/i386 i386/isa i386/xen isa modules/bios/smbios modules/bios/vpd modules/cpufreq pc98/pc98 x86 x86/bios x86

2010-03-01 Thread Peter Jeremy
On 2010-Feb-28 16:07:32 -0700, "M. Warner Losh" wrote: >In message: <4b8af55c.6040...@freebsd.org> >Nathan Whitehorn writes: >: M. Warner Losh wrote: >: > In message: <20100228195041.ga68...@server.vk2pj.dyndns.org> >: > Peter

Re: svn commit: r204974 - head/lib/libc/sparc64/fpu

2010-03-10 Thread Peter Jeremy
are used as indexes into opmask[]. Somewhere along the line, FTYPE_LNG has changed from 4 to 5 but the opmask[] initialisers still assume 4. (It might be worth adding a comment into opmask[] so this relationship is noted in future). -- Peter Jeremy pgpwZwYNidf71.pgp Description: PGP signature

svn commit: r312984 - in head: lib/libsysdecode libexec/rtld-elf

2017-01-30 Thread Peter Jeremy
Author: peterj Date: Mon Jan 30 08:38:32 2017 New Revision: 312984 URL: https://svnweb.freebsd.org/changeset/base/312984 Log: Extend LD_UTRACE by also generating utrace(2) log events for runtime linker errors. Reviewed by: kib, jhb Approved by: jhb(mentor) MFC after:1 week Dif