Author: tuexen
Date: Mon May 14 13:50:17 2018
New Revision: 333603
URL: https://svnweb.freebsd.org/changeset/base/333603
Log:
Ensure that the MTU's used are multiple of 4.
The length of SCTP packets is always a multiple of 4. Therefore,
ensure that the MTUs used are also a multiple of 4.
Author: tuexen
Date: Mon May 14 15:16:51 2018
New Revision: 333604
URL: https://svnweb.freebsd.org/changeset/base/333604
Log:
sctp_get_mbuf_for_msg() should honor the allinone parameter.
When it is not required that the buffer is not a chain, return
a chain. This is based on a patch provi
Author: tuexen
Date: Mon May 21 14:51:20 2018
New Revision: 333979
URL: https://svnweb.freebsd.org/changeset/base/333979
Log:
Make clear why there is an assignment, which is not necessary.
Modified:
head/sys/netinet/sctp_indata.c
Modified: head/sys/netinet/sctp_indata.c
=
Author: tuexen
Date: Mon May 21 14:52:18 2018
New Revision: 333980
URL: https://svnweb.freebsd.org/changeset/base/333980
Log:
Do the appropriate accounting when ip_output() fails.
Modified:
head/sys/netinet/sctp_output.c
Modified: head/sys/netinet/sctp_output.c
==
Author: tuexen
Date: Mon May 21 14:53:22 2018
New Revision: 333981
URL: https://svnweb.freebsd.org/changeset/base/333981
Log:
Only fillin data srucuture when actually stored.
Modified:
head/sys/netinet/sctputil.c
Modified: head/sys/netinet/sctputil.c
=
> On 24. May 2018, at 06:51, Matthew Macy wrote:
>
> Warnings find bugs PERIOD. Although most are not useful, I've found
Some warnings indicate bugs, some warnings are just wrong. If you
have a "may be used uninitialized" warning being a false positive, you
may silences the warning by just set it
> On 24. May 2018, at 08:36, Matthew Macy wrote:
>
> On Wed, May 23, 2018 at 11:35 PM, Michael Tuexen
> wrote:
>>> On 24. May 2018, at 06:51, Matthew Macy wrote:
>>>
>>> Warnings find bugs PERIOD. Although most are not useful, I've found
>> S
Author: tuexen
Date: Mon May 28 13:31:47 2018
New Revision: 334286
URL: https://svnweb.freebsd.org/changeset/base/334286
Log:
Use correct mask.
Introduced in https://svnweb.freebsd.org/changeset/base/333603.
Thanks to Irene Ruengler for testing and reporting the issue.
MFC after:
Author: tuexen
Date: Fri Jun 1 19:58:19 2018
New Revision: 334494
URL: https://svnweb.freebsd.org/changeset/base/334494
Log:
Ensure net.inet.tcp.syncache.rexmtlimit is limited by TCP_MAXRXTSHIFT.
If the sysctl variable is set to a value larger than TCP_MAXRXTSHIFT+1,
the array tcp_syn_ba
Author: tuexen
Date: Fri Jun 1 21:24:27 2018
New Revision: 334497
URL: https://svnweb.freebsd.org/changeset/base/334497
Log:
Limit the retransmission timer for SYN-ACKs by TCPTV_REXMTMAX.
Use the same logic to handle the SYN-ACK retransmission when sent from
the syn cache code as when se
Author: tuexen
Date: Sat Jun 2 16:28:10 2018
New Revision: 334532
URL: https://svnweb.freebsd.org/changeset/base/334532
Log:
Don't overflow a buffer if we receive an INIT or INIT-ACK chunk
without a RANDOM parameter but with a CHUNKS or HMAC-ALGO parameter.
Please note that sending this com
top doesn't work on a amd64 (64 logical cores) and on an arm64 (8 cores)
system anymore (world and kernel are in sync):
tuexen@epyc:~ % uname -a
FreeBSD epyc.nplab.de 12.0-CURRENT FreeBSD 12.0-CURRENT #5 r334554: Sun Jun 3
11:26:58 CEST 2018
r...@epyc.nplab.de:/usr/obj/usr/home/tuexen/head/
Author: tuexen
Date: Wed Jun 6 19:27:06 2018
New Revision: 334725
URL: https://svnweb.freebsd.org/changeset/base/334725
Log:
Improve compliance with RFC 4895 and RFC 6458.
Silently dicard SCTP chunks which have been requested to be
authenticated but are received unauthenticated no matter
Author: tuexen
Date: Thu Jun 14 21:22:14 2018
New Revision: 335176
URL: https://svnweb.freebsd.org/changeset/base/335176
Log:
Whitespace changes.
Modified:
head/sys/netinet/sctp_output.c
Modified: head/sys/netinet/sctp_output.c
Author: tuexen
Date: Thu Jun 14 21:30:52 2018
New Revision: 335179
URL: https://svnweb.freebsd.org/changeset/base/335179
Log:
Provide the ip6_plen in network byte order when calling ip6_output().
This is not strictly required by ip6_output(), since it overrides it,
but it is needed for up
Author: tuexen
Date: Fri Jun 15 12:28:43 2018
New Revision: 335194
URL: https://svnweb.freebsd.org/changeset/base/335194
Log:
When retransmitting TCP SYN-ACK segments with the TCP timestamp option
enabled use an updated timestamp instead of reusing the one used in
the initial TCP SYN-ACK seg
Author: tuexen
Date: Mon Jun 18 18:35:29 2018
New Revision: 335325
URL: https://svnweb.freebsd.org/changeset/base/335325
Log:
The IP, TCP, and UDP provider report IP addresses as strings.
In some cases, the required information is not available and the
UDP provider reported an empty string i
Author: tuexen
Date: Thu Dec 7 22:19:08 2017
New Revision: 326672
URL: https://svnweb.freebsd.org/changeset/base/326672
Log:
Retire SCTP_WITH_NO_CSUM option.
This option was used in the early days to allow performance measurements
extrapolating the use of SCTP checksum offloading. Since
> On 11. Dec 2017, at 17:21, Eugene Grosbein wrote:
>
> 11.12.2017 22:08, Konstantin Belousov пишет:
>> On Mon, Dec 11, 2017 at 06:03:36PM +0700, Eugene Grosbein wrote:
>>> I do not try to contradict other usage patterns. In fact, I'm eager to know
>>> a practical example of such pattern: a task,
Author: tuexen
Date: Wed Dec 13 17:11:57 2017
New Revision: 326829
URL: https://svnweb.freebsd.org/changeset/base/326829
Log:
Cleaup, no functional change.
Modified:
head/sys/netinet/sctp_input.c
head/sys/netinet/sctp_output.c
Modified: head/sys/netinet/sctp_input.c
===
Author: tuexen
Date: Tue Dec 26 12:35:02 2017
New Revision: 327200
URL: https://svnweb.freebsd.org/changeset/base/327200
Log:
When adding support for sending SCTP packets containing an ABORT chunk
to ipfw in https://svnweb.freebsd.org/changeset/base/326233,
a dependency on the SCTP stack was
> On 26. Dec 2017, at 13:35, Michael Tuexen wrote:
>
> Author: tuexen
> Date: Tue Dec 26 12:35:02 2017
> New Revision: 327200
> URL: https://svnweb.freebsd.org/changeset/base/327200
>
> Log:
> When adding support for sending SCTP packets containing an ABOR
Author: tuexen
Date: Tue Dec 26 14:37:47 2017
New Revision: 327203
URL: https://svnweb.freebsd.org/changeset/base/327203
Log:
Allow the first (and second) argument of sn_calloc() be a sum.
This fixes a bug reported in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224103
PR: 2
Author: tuexen
Date: Tue Dec 26 15:24:42 2017
New Revision: 327205
URL: https://svnweb.freebsd.org/changeset/base/327205
Log:
Fix CID 1008936.
Modified:
head/sys/netinet/libalias/alias_sctp.c
Modified: head/sys/netinet/libalias/alias_sctp.c
===
Author: tuexen
Date: Tue Dec 26 15:29:11 2017
New Revision: 327206
URL: https://svnweb.freebsd.org/changeset/base/327206
Log:
Fix CID 1008428.
MFC after:1 week
Modified:
head/sys/netinet/libalias/alias_sctp.c
Modified: head/sys/netinet/libalias/alias_sctp.c
=
Author: tuexen
Date: Tue Dec 26 16:06:11 2017
New Revision: 327208
URL: https://svnweb.freebsd.org/changeset/base/327208
Log:
Clearify issue reported in CID 1008198.
MFC after:3 days
Modified:
head/sys/netinet/libalias/alias_sctp.c
Modified: head/sys/netinet/libalias/alias_sctp.c
==
Author: tuexen
Date: Tue Dec 26 16:12:04 2017
New Revision: 327209
URL: https://svnweb.freebsd.org/changeset/base/327209
Log:
Clearify CID 1008197.
MFC after:3 days
Modified:
head/sys/netinet/libalias/alias_sctp.c
Modified: head/sys/netinet/libalias/alias_sctp.c
Author: tuexen
Date: Tue Dec 26 16:33:55 2017
New Revision: 327214
URL: https://svnweb.freebsd.org/changeset/base/327214
Log:
White cleanups.
Modified:
head/sys/netinet/libalias/alias_sctp.c
Modified: head/sys/netinet/libalias/alias_sctp.c
> On 26. Dec 2017, at 17:00, Alexey Dokuchaev wrote:
>
> On Tue, Dec 26, 2017 at 03:24:42PM +, Michael Tuexen wrote:
>> New Revision: 327205
>> URL: https://svnweb.freebsd.org/changeset/base/327205
>>
>> Log:
>> Fix CID 1008936.
>
> I'
> On 26. Dec 2017, at 17:14, Alexey Dokuchaev wrote:
>
> On Tue, Dec 26, 2017 at 04:12:04PM +, Michael Tuexen wrote:
>> New Revision: 327209
>> URL: https://svnweb.freebsd.org/changeset/base/327209
>>
>> Log:
>> Clearify CID 1008197.
>
> Again
> On 4. Jan 2018, at 23:37, Kyle Evans wrote:
>
> Author: kevans
> Date: Thu Jan 4 22:37:15 2018
> New Revision: 327563
> URL: https://svnweb.freebsd.org/changeset/base/327563
>
> Log:
> if_awg: Use syscon prop if it exists
>
> The emac bindings that are landing in Linux 4.15 specify a sysco
> On 6. Jan 2018, at 15:24, Kyle Evans wrote:
>
> On Sat, Jan 6, 2018 at 7:23 AM, Michael Tuexen wrote:
>>> On 4. Jan 2018, at 23:37, Kyle Evans wrote:
>>>
>>> Author: kevans
>>> Date: Thu Jan 4 22:37:15 2018
>>> New Revision: 327563
>
Author: tuexen
Date: Thu Jan 11 20:26:17 2018
New Revision: 327844
URL: https://svnweb.freebsd.org/changeset/base/327844
Log:
Ensure that the vnet is set when calling pru_sockaddr() and
pru_peeraddr().
This is already true when called via kern_getsockname() and
kern_getpeername(). This
Author: tuexen
Date: Thu Jan 11 21:17:05 2018
New Revision: 327846
URL: https://svnweb.freebsd.org/changeset/base/327846
Log:
Build systrace_freebsd32 on arm64.
Since r326501 which added COMPAT_FREEBSD32 to the GENERIC config for arm64,
we need to build systrace_freebsd32, since dtraceall
Author: tuexen
Date: Sat Jan 13 13:59:35 2018
New Revision: 327919
URL: https://svnweb.freebsd.org/changeset/base/327919
Log:
Add support for readv() and writev() to truss.
Sponsored by: Netflix, Inc.
Modified:
head/usr.bin/truss/syscall.h
head/usr.bin/truss/syscalls.c
Modified: head/
Author: tuexen
Date: Sat Jan 13 14:10:45 2018
New Revision: 327921
URL: https://svnweb.freebsd.org/changeset/base/327921
Log:
Fix a typo introduced in r327919.
Modified:
head/usr.bin/truss/syscalls.c
Modified: head/usr.bin/truss/syscalls.c
Author: tuexen
Date: Sun Jan 14 09:51:25 2018
New Revision: 327961
URL: https://svnweb.freebsd.org/changeset/base/327961
Log:
Mark the iovec parameters of writev() and readv() as IN and OUT.
This makes truss work on readv() as expected.
Modified:
head/usr.bin/truss/syscalls.c
Modified: hea
Author: tuexen
Date: Sun Jan 14 12:08:41 2018
New Revision: 327962
URL: https://svnweb.freebsd.org/changeset/base/327962
Log:
Add suppor for the supported PR-SCTP policies.
Modified:
head/lib/libsysdecode/Makefile
head/lib/libsysdecode/flags.c
head/lib/libsysdecode/mktables
head/lib/lib
sysdecode_sctp_sinfo_flags.3
==
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/lib/libsysdecode/sysdecode_sctp_sinfo_flags.3 Sun Jan 14 14:27:42
2018(r327966)
@@ -0,0 +1,55 @@
+.\"
Author: tuexen
Date: Sun Jan 14 14:33:22 2018
New Revision: 327967
URL: https://svnweb.freebsd.org/changeset/base/327967
Log:
Improve support for sctp_generic_recvmsg() and sctp_generic_sendmsg()
and add support for sctp_generic_sendmsg_iov().
Handle the struct iovec argument and the stru
Author: tuexen
Date: Mon Jan 15 08:32:49 2018
New Revision: 327994
URL: https://svnweb.freebsd.org/changeset/base/327994
Log:
Simplify table generation.
Modified:
head/lib/libsysdecode/mktables
Modified: head/lib/libsysdecode/mktables
=
tptr_t _arg, int _base);
Added: head/lib/libsysdecode/sysdecode_cmsg_type.3
==
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/lib/libsysdecode/sysdecode_cmsg_type.3 Mon Jan 15 10:59:04 20
Author: tuexen
Date: Mon Jan 15 20:37:11 2018
New Revision: 328014
URL: https://svnweb.freebsd.org/changeset/base/328014
Log:
Add support for decoding the nxt_flags, rcv_flags, and snd_flags of
SCTP level cmsgs.
Modified:
head/lib/libsysdecode/Makefile
head/lib/libsysdecode/flags.c
head
Author: tuexen
Date: Mon Jan 15 20:39:42 2018
New Revision: 328015
URL: https://svnweb.freebsd.org/changeset/base/328015
Log:
Decode msghdr argument of sendmsg() and recvmsg().
Sponsored by: Netflix, Inc.
Modified:
head/usr.bin/truss/syscall.h
head/usr.bin/truss/syscalls.c
Mod
Author: tuexen
Date: Mon Jan 15 21:59:20 2018
New Revision: 328028
URL: https://svnweb.freebsd.org/changeset/base/328028
Log:
Don't provide a (meaningless) cmsg when proving a notification
in a recvmsg() call.
MFC after:1 week
Modified:
head/sys/netinet/sctputil.c
Modified: head/s
Author: tuexen
Date: Mon Jan 15 23:12:54 2018
New Revision: 328033
URL: https://svnweb.freebsd.org/changeset/base/328033
Log:
Bump date, which I missed in r328014. Thanks to jhb@ for reporting.
Modified:
head/lib/libsysdecode/sysdecode_mask.3
Modified: head/lib/libsysdecode/sysdecode_mask.3
Author: tuexen
Date: Mon Jan 15 23:17:12 2018
New Revision: 328034
URL: https://svnweb.freebsd.org/changeset/base/328034
Log:
Keep list sorted. Thanks to jhb@ to pointing out that I put it at the
wrong place in r327919.
Modified:
head/usr.bin/truss/syscalls.c
Modified: head/usr.bin/truss/s
> On 15. Jan 2018, at 20:08, John Baldwin wrote:
>
> On Saturday, January 13, 2018 01:59:35 PM Michael Tuexen wrote:
>> Author: tuexen
>> Date: Sat Jan 13 13:59:35 2018
>> New Revision: 327919
>> URL: https://svnweb.freebsd.org/changeset/base/327919
>>
Author: tuexen
Date: Tue Jan 16 19:57:30 2018
New Revision: 328058
URL: https://svnweb.freebsd.org/changeset/base/328058
Log:
Using %p already prints "0x", so don't do it explicitly.
Modified:
head/usr.bin/truss/syscalls.c
Modified: head/usr.bin/truss/syscalls.c
=
Author: tuexen
Date: Tue Jan 16 20:02:07 2018
New Revision: 328059
URL: https://svnweb.freebsd.org/changeset/base/328059
Log:
Improve the printing of cmgs when the length is 0. Fix error handling.
Modified:
head/usr.bin/truss/syscalls.c
Modified: head/usr.bin/truss/syscalls.c
===
Author: tuexen
Date: Tue Jan 16 21:58:38 2018
New Revision: 328066
URL: https://svnweb.freebsd.org/changeset/base/328066
Log:
Fix a bug related to fast retransmissions.
When processing a SACK advancing the cumtsn-ack in fast recovery,
increment the miss-indications for all TSN's reported
Author: tuexen
Date: Wed Jan 17 10:30:49 2018
New Revision: 328081
URL: https://svnweb.freebsd.org/changeset/base/328081
Log:
Add missing assignment to make sure non-first cmsgs are handled as such.
Modified:
head/usr.bin/truss/syscalls.c
Modified: head/usr.bin/truss/syscalls.c
=
Author: tuexen
Date: Sat Jan 27 13:43:03 2018
New Revision: 328477
URL: https://svnweb.freebsd.org/changeset/base/328477
Log:
Update references in comments, since the IDs have become an RFC long
time ago. Also cleanup whitespaces. No functional change.
MFC after:1 week
Modified:
he
Author: tuexen
Date: Sat Jan 27 13:46:55 2018
New Revision: 328478
URL: https://svnweb.freebsd.org/changeset/base/328478
Log:
Add constant for the PAD chunk as defined in RFC 4820.
This will be used by traceroute and traceroute6 soon.
MFC after:1 week
Modified:
head/sys/netinet/sct
Author: tuexen
Date: Sat Jan 27 19:23:42 2018
New Revision: 328488
URL: https://svnweb.freebsd.org/changeset/base/328488
Log:
When using SCTP for sending probe packets, use INIT chunks for payloads
larger than or equal to 32 bytes. For smaller probe packets, keep using
SHUTDOWN-ACK chunks, p
Author: tuexen
Date: Sun Apr 8 11:37:00 2018
New Revision: 332269
URL: https://svnweb.freebsd.org/changeset/base/332269
Log:
Fix a signed/unsigned warning showing up for the userland stack
on some platforms.
Thanks to Felix Weinrank for reporting the issue.
MFC after:i 3 days
Modifi
Author: tuexen
Date: Sun Apr 8 11:50:06 2018
New Revision: 332271
URL: https://svnweb.freebsd.org/changeset/base/332271
Log:
Small cleanup, no functional change.
MFC after:3 days
Modified:
head/sys/netinet/sctp_usrreq.c
Modified: head/sys/netinet/sctp_usrreq.c
=
Author: tuexen
Date: Sun Apr 8 12:08:20 2018
New Revision: 332273
URL: https://svnweb.freebsd.org/changeset/base/332273
Log:
Fix a logical inversion bug.
Thanks to Irene Ruengeler for finding and reporting this bug.
MFC after:3 days
Modified:
head/sys/netinet/sctp_usrreq.c
he
Author: tuexen
Date: Tue Apr 10 08:19:14 2018
New Revision: 332353
URL: https://svnweb.freebsd.org/changeset/base/332353
Log:
Don't show the number of currently established SCTP associations,
since this is not monotonically increasing. It's number can be
derived from the other counters shown
Author: tuexen
Date: Wed May 2 19:36:46 2018
New Revision: 333176
URL: https://svnweb.freebsd.org/changeset/base/333176
Log:
Fix in the documentation that the default hop limit is not 30, but
the value of the sysctl variable net.inet6.ip6.hlim.
This is true since
https://svnweb.freebsd.or
Author: tuexen
Date: Wed May 2 20:04:31 2018
New Revision: 333178
URL: https://svnweb.freebsd.org/changeset/base/333178
Log:
SImplify the call to tcp_drop(), since the handling of soft error
is also done in tcp_drop(). No functional change.
Sponsored by: Netflix, Inc.
Modified:
head/s
Author: tuexen
Date: Wed May 2 22:11:16 2018
New Revision: 333186
URL: https://svnweb.freebsd.org/changeset/base/333186
Log:
Send an ICMPv6 PacketTooBig message in case of forwading a packet which
is too big for the outgoing interface and no firewall is involed.
This problem was introduced
Author: tuexen
Date: Sun May 6 14:19:50 2018
New Revision: 04
URL: https://svnweb.freebsd.org/changeset/base/04
Log:
Ensure we are not dereferencing a NULL pointer.
This was found by Coverity scanning the usrsctp stack (CID 203808).
MFC after:3 days
Modified:
head/sys/n
so I didn't know the number. This has now been resolved.
Best regards
Michael
>
> Best,
> Conrad
>
> On Sun, May 6, 2018 at 7:19 AM, Michael Tuexen wrote:
>> Author: tuexen
>> Date: Sun May 6 14:19:50 2018
>> New Revision: 04
>> URL: https://sv
Author: tuexen
Date: Tue May 8 18:48:51 2018
New Revision: 82
URL: https://svnweb.freebsd.org/changeset/base/82
Log:
When reporting ERROR or ABORT chunks, don't use more data
that is guaranteed to be contigous.
Thanks to Felix Weinrank for finding and reporting this bug
by fuzzing
Author: tuexen
Date: Tue May 8 20:39:35 2018
New Revision: 86
URL: https://svnweb.freebsd.org/changeset/base/86
Log:
Fix two typos reported by N. J. Mann, which were introduced in
https://svnweb.freebsd.org/changeset/base/82 by me.
MFC after:3 days
Modified:
head/sys/n
> On 16. May 2017, at 20:28, John Baldwin wrote:
>
> On Wednesday, May 03, 2017 09:23:14 AM Michael Tuexen wrote:
>> Author: tuexen
>> Date: Wed May 3 09:23:13 2017
>> New Revision: 317732
>> URL: https://svnweb.freebsd.org/changeset/base/317732
>>
&
Author: tuexen
Date: Mon May 22 15:29:10 2017
New Revision: 318649
URL: https://svnweb.freebsd.org/changeset/base/318649
Log:
The connect() system call should return -1 and set errno to EAFNOSUPPORT
if it is called on a TCP socket
* with an IPv6 address and the socket is bound to an
I
Author: tuexen
Date: Thu May 25 14:27:54 2017
New Revision: 318879
URL: https://svnweb.freebsd.org/changeset/base/318879
Log:
Improve the decoding of the third argument of the socket() call.
Decoding of the third argument depends on the first one. For doing this,
add a corresponding funct
Author: tuexen
Date: Fri May 26 16:29:00 2017
New Revision: 318958
URL: https://svnweb.freebsd.org/changeset/base/318958
Log:
Use the SCTP_PCB_FLAGS_ACCEPTING flags to check for listeners.
While there, use a macro for checking the listen state to allow for
easier changes if required.
Author: tuexen
Date: Thu Jun 1 15:11:18 2017
New Revision: 319433
URL: https://svnweb.freebsd.org/changeset/base/319433
Log:
Improve comments to describe what the code does.
Reported by: jtl
Sponsored by: Netflix, Inc.
Modified:
head/sys/netinet/tcp_input.c
head/sys
Author: tuexen
Date: Sat Jun 3 21:53:58 2017
New Revision: 319556
URL: https://svnweb.freebsd.org/changeset/base/319556
Log:
Fix the ICMP6 handling for TCP.
The ICMP6 packets might not be contained in a single mbuf. So don't
assume this. Keep the IPv4 and IPv6 code in sync and make expli
> On 7. Jun 2017, at 23:56, Ed Maste wrote:
>
> On 7 June 2017 at 18:18, Ed Maste wrote:
>> On 27 April 2017 at 13:53, Michael Tuexen wrote:
>>> Author: tuexen
>>> Date: Thu Apr 27 17:53:05 2017
>>> New Revision: 317512
>>> URL: https://svnwe
Author: tuexen
Date: Fri Jun 23 08:34:01 2017
New Revision: 320260
URL: https://svnweb.freebsd.org/changeset/base/320260
Log:
Improve compilation on platforms different from FreeBSD.
Modified:
head/sys/netinet/sctp_input.c
head/sys/netinet/sctputil.c
head/sys/netinet/sctputil.h
Modified:
Author: tuexen
Date: Fri Jun 23 08:35:54 2017
New Revision: 320261
URL: https://svnweb.freebsd.org/changeset/base/320261
Log:
Honor the backlog field.
Modified:
head/sys/netinet/sctp_usrreq.c
Modified: head/sys/netinet/sctp_usrreq.c
===
Author: tuexen
Date: Fri Jun 23 09:27:31 2017
New Revision: 320263
URL: https://svnweb.freebsd.org/changeset/base/320263
Log:
Use a longer buffer for messages in ERROR chunks.
This allows them to be sent in a non truncated way and addresses a warning
given by newver versions of gcc.
Tha
Author: tuexen
Date: Fri Jun 23 10:09:49 2017
New Revision: 320264
URL: https://svnweb.freebsd.org/changeset/base/320264
Log:
Check the length of a COOKIE chunk before accessing fields in it.
Thanks to Felix Weinrank for reporting the issue he found by using
libFuzzer.
MFC after:
Author: tuexen
Date: Fri Jun 23 21:01:57 2017
New Revision: 320300
URL: https://svnweb.freebsd.org/changeset/base/320300
Log:
Handle sctp_get_next_param() in a consistent way.
This addresses an issue found by Felix Weinrank using libfuzz.
While there, use also consistent nameing.
MFC
Author: tuexen
Date: Tue Jul 4 18:04:44 2017
New Revision: 320650
URL: https://svnweb.freebsd.org/changeset/base/320650
Log:
Don't hold if refcount on an stcb when it is not needed.
This improves the consistency with other parts of the code.
Modified:
head/sys/netinet/sctp_input.c
Modifie
Author: tuexen
Date: Tue Jul 4 18:24:50 2017
New Revision: 320653
URL: https://svnweb.freebsd.org/changeset/base/320653
Log:
Move to open state after plausibility checks.
When doing this too early, the MIB counters go wrong.
MFC after:1 week
Modified:
head/sys/netinet/sctp_inpu
Author: tuexen
Date: Sat Jul 15 19:54:03 2017
New Revision: 321034
URL: https://svnweb.freebsd.org/changeset/base/321034
Log:
Fix the handling of Explicit EOR mode.
While there, appropriately handle the overhead depending on
the usage of DATA or I-DATA chunks. Take the overhead only
int
Author: tuexen
Date: Fri Oct 21 10:32:57 2016
New Revision: 307726
URL: https://svnweb.freebsd.org/changeset/base/307726
Log:
Make ICMPv6 hard error handling for TCP consistent with the ICMPv4
handling. Ensure that:
* Protocol unreachable errors are handled by indicating ECONNREFUSED
to
Author: tuexen
Date: Fri Oct 21 11:29:25 2016
New Revision: 307727
URL: https://svnweb.freebsd.org/changeset/base/307727
Log:
Document the TCP sysctl variables insecure_rst and insecure_syn.
MFC after: 1 month
Sponsored by: netflix
Modified:
head/share/man/man4/tcp.4
Modified: head/sh
Author: tuexen
Date: Fri Oct 21 18:45:09 2016
New Revision: 307746
URL: https://svnweb.freebsd.org/changeset/base/307746
Log:
Fix a grammar error.
Reported by:i hiren, vangyzen
MFC after: 1 month
X-MFC:r307727
Sponsored by: Netflix
Modified:
head/share/man/man4/tcp.4
Modif
> On 21 Oct 2016, at 17:26, Eric van Gyzen wrote:
>
> On 10/21/2016 09:28, hiren panchasara wrote:
>> On 10/21/16 at 11:29P, Michael Tuexen wrote:
>>> Author: tuexen
>>> Date: Fri Oct 21 11:29:25 2016
>>> New Revision: 307727
>>> URL: https://sv
> On 21 Oct 2016, at 16:36, Marcelo Araujo wrote:
>
> Bump date too.
It was bumped, wasn't it?
Best regards
Michael
>
>
> On Oct 21, 2016 10:28 PM, "hiren panchasara"
> wrote:
> On 10/21/16 at 11:29P, Michael Tuexen wrote:
> > Author: tuex
Author: tuexen
Date: Sat Oct 22 17:21:21 2016
New Revision: 307779
URL: https://svnweb.freebsd.org/changeset/base/307779
Log:
No functional changes, mostly getting the whitespace changes resulting
from an updated formatting tool chain.
MFC after: 1 month
Modified:
head/sys/netinet/sctp
Author: tuexen
Date: Sun Nov 13 17:55:27 2016
New Revision: 308616
URL: https://svnweb.freebsd.org/changeset/base/308616
Log:
Fix typo.
MFC after: 1 month
Sponsored by: Netflix
Modified:
head/usr.sbin/bhyvectl/bhyvectl.8
Modified: head/usr.sbin/bhyvectl/bhyvectl.8
Author: tuexen
Date: Thu Nov 17 08:15:02 2016
New Revision: 308745
URL: https://svnweb.freebsd.org/changeset/base/308745
Log:
Notify the use via setting errno when a TCP RST segment is received
either in the CLOSING or LAST-ACK state.
Reviewed by: hiren
MFC after:3
Author: tuexen
Date: Sat Nov 19 14:45:08 2016
New Revision: 308832
URL: https://svnweb.freebsd.org/changeset/base/308832
Log:
Ensure that TCP state changes to state-closing are reported via dtrace.
This does not cover state changes from TIME-WAIT.
Reviewed by: gnn
MFC after:
Author: tuexen
Date: Fri Dec 2 08:02:31 2016
New Revision: 309397
URL: https://svnweb.freebsd.org/changeset/base/309397
Log:
Fix the handling of TCP FIN-segments in the CLOSED state
When a TCP segment with the FIN bit set was received in the CLOSED state,
a TCP RST-ACK-segment is sent.
Author: tuexen
Date: Tue Dec 6 10:21:25 2016
New Revision: 309607
URL: https://svnweb.freebsd.org/changeset/base/309607
Log:
Whitespace changes.
The tools using to generate the sources has been updated and produces
different whitespaces. Commit this seperately to avoid intermixing
thes
Author: tuexen
Date: Wed Dec 7 19:30:59 2016
New Revision: 309682
URL: https://svnweb.freebsd.org/changeset/base/309682
Log:
Cleanup the names of SSN, SID, TSN, FSN, PPID and MID.
This made a couple of bugs visible in handling SSN wrap-arounds
when using DATA chunks. Now bulk transfer se
Author: tuexen
Date: Wed Dec 7 21:24:49 2016
New Revision: 309683
URL: https://svnweb.freebsd.org/changeset/base/309683
Log:
Fix a bug in sctp_sendmsgx(), where the sid provided by the user
was hot honored.
MFC after:3 days
Modified:
head/lib/libc/net/sctp_sys_calls.c
Modified: h
Author: tuexen
Date: Wed Dec 7 22:01:09 2016
New Revision: 309685
URL: https://svnweb.freebsd.org/changeset/base/309685
Log:
Silence a warning produced by newer versions of gcc.
MFC after:1 week
Modified:
head/sys/netinet/sctp_output.c
Modified: head/sys/netinet/sctp_output.c
=
Author: tuexen
Date: Fri Dec 9 17:57:17 2016
New Revision: 309743
URL: https://svnweb.freebsd.org/changeset/base/309743
Log:
Don't send multiple SHUTDOWN chunks in a single packet.
Thanks to Felix Weinrank for making me aware of this issue.
MFC after:1 week
Modified:
head/sys/n
Author: tuexen
Date: Fri Dec 9 17:58:07 2016
New Revision: 309744
URL: https://svnweb.freebsd.org/changeset/base/309744
Log:
Don't bundle a SACK chunk with a SHUTDOWN chunk if it is not required.
MFC after:1 week
Modified:
head/sys/netinet/sctp_indata.c
Modified: head/sys/netinet/s
Author: tuexen
Date: Sun Dec 11 13:26:35 2016
New Revision: 309851
URL: https://svnweb.freebsd.org/changeset/base/309851
Log:
Ensure that the reported ppid and tsn are taken from the first fragment.
This fixes a bug where the wrong ppid was reported, if
* I-DATA was used on the first frag
Author: tuexen
Date: Thu Oct 3 18:36:54 2019
New Revision: 353060
URL: https://svnweb.freebsd.org/changeset/base/353060
Log:
Add missing input validation. This could result in reading from
uninitialized memory.
The issue was found by OSS-Fuzz for usrsctp and reported in
https://bugs.chro
Author: tuexen
Date: Thu Oct 3 20:39:17 2019
New Revision: 353069
URL: https://svnweb.freebsd.org/changeset/base/353069
Log:
Cleanup sctp_asconf_error_response() and ensure that the parameter
is padded as required. This fixes the followig bug reported by
OSS-Fuzz for the usersctp stack:
h
1 - 100 of 1365 matches
Mail list logo